From: Simon Ser <contact@emersion.fr>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: mripard@kernel.org, linux-graphics-maintainer@vmware.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] drm: Allow PRIME 'self-import' for all drivers
Date: Thu, 15 Jun 2023 14:50:08 +0000 [thread overview]
Message-ID: <O78vhvv6qtN2Fjh9tljnBnBeNwr-eASqyXaUG3e8cWPZ2MqoOSWR_D8S_ce2gqSvbLkJwX72tmc6ReUry0OTqJQWwhDcyrZrQP4hgg7iH30=@emersion.fr> (raw)
In-Reply-To: <20230615094206.4424-1-tzimmermann@suse.de>
On Thursday, June 15th, 2023 at 11:31, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> Set drm_gem_prime_handle_to_fd() and drm_gem_prime_fd_to_handle()
> for all DRM drivers. Even drivers that do not support PRIME import
> or export of dma-bufs can now import their own buffer objects. This
> is required by some userspace, such as wlroots-based compositors, to
> share buffers among processes.
>
> The only driver that does not use the drm_gem_prime_*() helpers is
> vmwgfx. Once it has been converted, the callbacks in struct drm_driver
> can be removed.
>
> Simon Ser implemented the feature for drivers based on GEM VRAM helpers
> in [1]. This patchset generalizes the code for all drivers that do not
> otherwise support PRIME. Tested by running sway with gma500 hardware.
Very nice! Thanks a lot for doing this!
Just one minor comment about docs. I think there are also some remaining
references to drm_gem_prime_handle_to_fd() and drm_gem_prime_fd_to_handle()
in the drm_prime.c overview. These become stale since this series unexports
these functions.
With that fixed:
Reviewed-by: Simon Ser <contact@emersion.fr>
next prev parent reply other threads:[~2023-06-15 14:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 9:31 [PATCH 0/3] drm: Allow PRIME 'self-import' for all drivers Thomas Zimmermann
2023-06-15 9:31 ` [PATCH 1/3] drm: Enable PRIME import/export " Thomas Zimmermann
2023-06-15 14:47 ` Simon Ser
2023-06-15 9:31 ` [PATCH 2/3] drm: Clear fd/handle callbacks in struct drm_driver Thomas Zimmermann
2023-06-15 9:31 ` [PATCH 3/3] drm/prime: Unexport helpers for fd/handle conversion Thomas Zimmermann
2023-06-15 14:50 ` Simon Ser [this message]
2023-06-15 14:56 ` [PATCH 0/3] drm: Allow PRIME 'self-import' for all drivers Thomas Zimmermann
2023-06-16 3:59 ` Zack Rusin
2023-06-16 7:11 ` Thomas Zimmermann
2023-06-16 17:00 ` Jeffrey Hugo
2023-06-19 8:52 ` Thomas Zimmermann
2023-06-16 17:22 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='O78vhvv6qtN2Fjh9tljnBnBeNwr-eASqyXaUG3e8cWPZ2MqoOSWR_D8S_ce2gqSvbLkJwX72tmc6ReUry0OTqJQWwhDcyrZrQP4hgg7iH30=@emersion.fr' \
--to=contact@emersion.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).