* [PATCH] drm/i915/guc/slpc: Correct the param count for unset param
@ 2022-02-16 18:15 Vinay Belgaumkar
2022-02-17 9:41 ` [Intel-gfx] " Tvrtko Ursulin
2022-02-17 19:12 ` Umesh Nerlige Ramappa
0 siblings, 2 replies; 5+ messages in thread
From: Vinay Belgaumkar @ 2022-02-16 18:15 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Vinay Belgaumkar, Umesh Nerlige Ramappa
SLPC unset param H2G only needs one parameter - the id of the
param.
Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency limits")
Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
index 13b27b8ff74e..ba21ace973da 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
@@ -110,7 +110,7 @@ static int guc_action_slpc_unset_param(struct intel_guc *guc, u8 id)
{
u32 request[] = {
GUC_ACTION_HOST2GUC_PC_SLPC_REQUEST,
- SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 2),
+ SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 1),
id,
};
--
2.34.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Correct the param count for unset param
2022-02-16 18:15 [PATCH] drm/i915/guc/slpc: Correct the param count for unset param Vinay Belgaumkar
@ 2022-02-17 9:41 ` Tvrtko Ursulin
2022-02-17 17:04 ` Belgaumkar, Vinay
2022-02-17 19:12 ` Umesh Nerlige Ramappa
1 sibling, 1 reply; 5+ messages in thread
From: Tvrtko Ursulin @ 2022-02-17 9:41 UTC (permalink / raw)
To: Vinay Belgaumkar, intel-gfx, dri-devel
On 16/02/2022 18:15, Vinay Belgaumkar wrote:
> SLPC unset param H2G only needs one parameter - the id of the
> param.
>
> Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency limits")
How serious is this? Does it need backporting? If so:
Cc: <stable@vger.kernel.org> # v5.15+
?
Regards,
Tvrtko
> Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> index 13b27b8ff74e..ba21ace973da 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> @@ -110,7 +110,7 @@ static int guc_action_slpc_unset_param(struct intel_guc *guc, u8 id)
> {
> u32 request[] = {
> GUC_ACTION_HOST2GUC_PC_SLPC_REQUEST,
> - SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 2),
> + SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 1),
> id,
> };
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Correct the param count for unset param
2022-02-17 9:41 ` [Intel-gfx] " Tvrtko Ursulin
@ 2022-02-17 17:04 ` Belgaumkar, Vinay
2022-02-17 17:09 ` Tvrtko Ursulin
0 siblings, 1 reply; 5+ messages in thread
From: Belgaumkar, Vinay @ 2022-02-17 17:04 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx, dri-devel
On 2/17/2022 1:41 AM, Tvrtko Ursulin wrote:
>
> On 16/02/2022 18:15, Vinay Belgaumkar wrote:
>> SLPC unset param H2G only needs one parameter - the id of the
>> param.
>>
>> Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency
>> limits")
>
> How serious is this? Does it need backporting? If so:
>
> Cc: <stable@vger.kernel.org> # v5.15+
>
> ?
This path (unset_param) is not being exercised currently, so not very
serious.
Thanks,
Vinay.
>
> Regards,
>
> Tvrtko
>
>> Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>> ---
>> drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>> b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>> index 13b27b8ff74e..ba21ace973da 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>> @@ -110,7 +110,7 @@ static int guc_action_slpc_unset_param(struct
>> intel_guc *guc, u8 id)
>> {
>> u32 request[] = {
>> GUC_ACTION_HOST2GUC_PC_SLPC_REQUEST,
>> - SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 2),
>> + SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 1),
>> id,
>> };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Correct the param count for unset param
2022-02-17 17:04 ` Belgaumkar, Vinay
@ 2022-02-17 17:09 ` Tvrtko Ursulin
0 siblings, 0 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2022-02-17 17:09 UTC (permalink / raw)
To: Belgaumkar, Vinay, intel-gfx, dri-devel
On 17/02/2022 17:04, Belgaumkar, Vinay wrote:
>
> On 2/17/2022 1:41 AM, Tvrtko Ursulin wrote:
>>
>> On 16/02/2022 18:15, Vinay Belgaumkar wrote:
>>> SLPC unset param H2G only needs one parameter - the id of the
>>> param.
>>>
>>> Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency
>>> limits")
>>
>> How serious is this? Does it need backporting? If so:
>>
>> Cc: <stable@vger.kernel.org> # v5.15+
>>
>> ?
>
> This path (unset_param) is not being exercised currently, so not very
> serious.
Got it, and looking at the code it seems to hold - no possible entry to
the path at the moment.
Note for the future - this is useful stuff to put in commit messages,
especially when Fixes: is present. ;)
Regards,
Tvrtko
> Thanks,
>
> Vinay.
>
>>
>> Regards,
>>
>> Tvrtko
>>
>>> Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>>> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>>> b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>>> index 13b27b8ff74e..ba21ace973da 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>>> @@ -110,7 +110,7 @@ static int guc_action_slpc_unset_param(struct
>>> intel_guc *guc, u8 id)
>>> {
>>> u32 request[] = {
>>> GUC_ACTION_HOST2GUC_PC_SLPC_REQUEST,
>>> - SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 2),
>>> + SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 1),
>>> id,
>>> };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/guc/slpc: Correct the param count for unset param
2022-02-16 18:15 [PATCH] drm/i915/guc/slpc: Correct the param count for unset param Vinay Belgaumkar
2022-02-17 9:41 ` [Intel-gfx] " Tvrtko Ursulin
@ 2022-02-17 19:12 ` Umesh Nerlige Ramappa
1 sibling, 0 replies; 5+ messages in thread
From: Umesh Nerlige Ramappa @ 2022-02-17 19:12 UTC (permalink / raw)
To: Vinay Belgaumkar; +Cc: intel-gfx, dri-devel
On Wed, Feb 16, 2022 at 10:15:04AM -0800, Vinay Belgaumkar wrote:
>SLPC unset param H2G only needs one parameter - the id of the
>param.
>
>Fixes: 025cb07bebfa ("drm/i915/guc/slpc: Cache platform frequency limits")
>
>Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>---
> drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>index 13b27b8ff74e..ba21ace973da 100644
>--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
>@@ -110,7 +110,7 @@ static int guc_action_slpc_unset_param(struct intel_guc *guc, u8 id)
> {
> u32 request[] = {
> GUC_ACTION_HOST2GUC_PC_SLPC_REQUEST,
>- SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 2),
>+ SLPC_EVENT(SLPC_EVENT_PARAMETER_UNSET, 1),
lgtm,
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Thanks,
Umesh
> id,
> };
>
>--
>2.34.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-17 19:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 18:15 [PATCH] drm/i915/guc/slpc: Correct the param count for unset param Vinay Belgaumkar
2022-02-17 9:41 ` [Intel-gfx] " Tvrtko Ursulin
2022-02-17 17:04 ` Belgaumkar, Vinay
2022-02-17 17:09 ` Tvrtko Ursulin
2022-02-17 19:12 ` Umesh Nerlige Ramappa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).