* [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel
@ 2020-09-15 12:19 Neil Armstrong
2020-09-15 12:19 ` [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix Neil Armstrong
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Neil Armstrong @ 2020-09-15 12:19 UTC (permalink / raw)
To: thierry.reding, sam
Cc: linux-amlogic, linux-kernel, dri-devel, Neil Armstrong
This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel
module shipped with the Amlogic S400 Development Kit.
The panel has a 1024×600 resolution and uses 24 bit RGB per pixel.
It provides a MIPI DSI interface to the host, a built-in LED backlight
and touch controller.
Changes since v3 at [3]:
- reordered tdo vendor prefix
Changes since v2 at [2]:
- added reset gpio to panel-simple-dsi bindings
- moved bindings to panel-simple
- re-ordered prepare/unprepare
- added back refresh print
- moved regulator/reset handling in prepare/unprepare
- aligned remove/shutdown with panel-simple
- added sentinel comment into dt match table
Changes since v1 at [1]:
- added missing vendor-prefixes patch
- removed vrefresh
- fixed warning on add_panel return
- removed DRM logging
[1] https://patchwork.freedesktop.org/series/81376/#rev1
[2] https://patchwork.freedesktop.org/series/81376/#rev2
[3] https://patchwork.freedesktop.org/series/81376/#rev3
Neil Armstrong (4):
dt-bindings: vendor-prefixes: Add Shanghai Top Display
Optolelectronics vendor prefix
dt-bindings: display: panel-simple-dsi: add optional reset gpio
dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel
bindings
drm: panel: add TDO tl070wsh30 panel driver
.../display/panel/panel-simple-dsi.yaml | 3 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
drivers/gpu/drm/panel/Kconfig | 11 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 250 ++++++++++++++++++
5 files changed, 267 insertions(+)
create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
--
2.22.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix
2020-09-15 12:19 [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel Neil Armstrong
@ 2020-09-15 12:19 ` Neil Armstrong
2020-09-23 1:28 ` Rob Herring
2020-09-15 12:19 ` [PATCH v4 2/4] dt-bindings: display: panel-simple-dsi: add optional reset gpio Neil Armstrong
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Neil Armstrong @ 2020-09-15 12:19 UTC (permalink / raw)
To: thierry.reding, sam, devicetree
Cc: linux-amlogic, linux-kernel, dri-devel, Neil Armstrong
Shanghai Top Display Optolelectronics Co., Ltd is a display manufacturer
from Shanghai.
Web site of the company: http://www.shtdo.com/
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index a1e4356cf522..fecdc7200b40 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1037,6 +1037,8 @@ patternProperties:
description: Trusted Computing Group
"^tcl,.*":
description: Toby Churchill Ltd.
+ "^tdo,.*":
+ description: Shangai Top Display Optoelectronics Co., Ltd
"^technexion,.*":
description: TechNexion
"^technologic,.*":
--
2.22.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 2/4] dt-bindings: display: panel-simple-dsi: add optional reset gpio
2020-09-15 12:19 [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel Neil Armstrong
2020-09-15 12:19 ` [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix Neil Armstrong
@ 2020-09-15 12:19 ` Neil Armstrong
2020-09-23 1:28 ` Rob Herring
2020-09-15 12:19 ` [PATCH v4 3/4] dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel bindings Neil Armstrong
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Neil Armstrong @ 2020-09-15 12:19 UTC (permalink / raw)
To: thierry.reding, sam, devicetree
Cc: linux-amlogic, linux-kernel, dri-devel, Neil Armstrong
Simple DSI panels can also have a reset GPIO signal in addition/instead of an
enable GPIO signal.
This adds an optional reset-gpios property.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
.../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
index c0dd9fa29f1d..4d08e746cb21 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
@@ -54,6 +54,7 @@ properties:
backlight: true
enable-gpios: true
+ reset-gpios: true
port: true
power-supply: true
--
2.22.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 3/4] dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel bindings
2020-09-15 12:19 [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel Neil Armstrong
2020-09-15 12:19 ` [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix Neil Armstrong
2020-09-15 12:19 ` [PATCH v4 2/4] dt-bindings: display: panel-simple-dsi: add optional reset gpio Neil Armstrong
@ 2020-09-15 12:19 ` Neil Armstrong
2020-09-23 1:28 ` Rob Herring
2020-09-15 12:19 ` [PATCH v4 4/4] drm: panel: add TDO tl070wsh30 panel driver Neil Armstrong
2020-09-29 9:25 ` [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel Neil Armstrong
4 siblings, 1 reply; 11+ messages in thread
From: Neil Armstrong @ 2020-09-15 12:19 UTC (permalink / raw)
To: thierry.reding, sam, devicetree
Cc: linux-amlogic, linux-kernel, dri-devel, Neil Armstrong
This add the bindings for the 1024x600 TFT LCD TL070WSH30 DSI panel to panel-simple-dsi.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
.../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
index 4d08e746cb21..a29ab65507f0 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
@@ -47,6 +47,8 @@ properties:
- panasonic,vvx10f004b00
# Panasonic 10" WUXGA TFT LCD panel
- panasonic,vvx10f034n00
+ # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT LCD panel
+ - tdo,tl070wsh30
reg:
maxItems: 1
--
2.22.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 4/4] drm: panel: add TDO tl070wsh30 panel driver
2020-09-15 12:19 [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel Neil Armstrong
` (2 preceding siblings ...)
2020-09-15 12:19 ` [PATCH v4 3/4] dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel bindings Neil Armstrong
@ 2020-09-15 12:19 ` Neil Armstrong
2020-09-29 9:25 ` [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel Neil Armstrong
4 siblings, 0 replies; 11+ messages in thread
From: Neil Armstrong @ 2020-09-15 12:19 UTC (permalink / raw)
To: thierry.reding, sam
Cc: linux-amlogic, linux-kernel, dri-devel, Neil Armstrong
This adds support for the TDO TL070WSH30 TFT-LCD panel module.
The panel has a 1024×600 resolution and uses 24 bit RGB per pixel.
It provides a MIPI DSI interface to the host, a built-in LED backlight
and touch controller.
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/gpu/drm/panel/Kconfig | 11 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 250 +++++++++++++++++++
3 files changed, 262 insertions(+)
create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 8d97d07c5871..2d488a875b99 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -433,6 +433,17 @@ config DRM_PANEL_SONY_ACX565AKM
Say Y here if you want to enable support for the Sony ACX565AKM
800x600 3.5" panel (found on the Nokia N900).
+config DRM_PANEL_TDO_TL070WSH30
+ tristate "TDO TL070WSH30 DSI panel"
+ depends on OF
+ depends on DRM_MIPI_DSI
+ depends on BACKLIGHT_CLASS_DEVICE
+ help
+ Say Y here if you want to enable support for TDO TL070WSH30 TFT-LCD
+ panel module. The panel has a 1024×600 resolution and uses
+ 24 bit RGB per pixel. It provides a MIPI DSI interface to
+ the host, a built-in LED backlight and touch controller.
+
config DRM_PANEL_TPO_TD028TTEC1
tristate "Toppoly (TPO) TD028TTEC1 panel driver"
depends on OF && SPI
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
index 15a4e7752951..35ee06a1b5c2 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -45,6 +45,7 @@ obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o
obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o
obj-$(CONFIG_DRM_PANEL_SONY_ACX424AKP) += panel-sony-acx424akp.o
obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o
+obj-$(CONFIG_DRM_PANEL_TDO_TL070WSH30) += panel-tdo-tl070wsh30.o
obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o
obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o
obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.o
diff --git a/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c b/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
new file mode 100644
index 000000000000..820731be7147
--- /dev/null
+++ b/drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
@@ -0,0 +1,250 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2020 BayLibre, SAS
+ * Author: Neil Armstrong <narmstrong@baylibre.com>
+ */
+
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/regulator/consumer.h>
+
+#include <video/mipi_display.h>
+
+#include <drm/drm_crtc.h>
+#include <drm/drm_device.h>
+#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modes.h>
+#include <drm/drm_panel.h>
+
+struct tdo_tl070wsh30_panel {
+ struct drm_panel base;
+ struct mipi_dsi_device *link;
+
+ struct regulator *supply;
+ struct gpio_desc *reset_gpio;
+
+ bool prepared;
+};
+
+static inline
+struct tdo_tl070wsh30_panel *to_tdo_tl070wsh30_panel(struct drm_panel *panel)
+{
+ return container_of(panel, struct tdo_tl070wsh30_panel, base);
+}
+
+static int tdo_tl070wsh30_panel_prepare(struct drm_panel *panel)
+{
+ struct tdo_tl070wsh30_panel *tdo_tl070wsh30 = to_tdo_tl070wsh30_panel(panel);
+ int err;
+
+ if (tdo_tl070wsh30->prepared)
+ return 0;
+
+ err = regulator_enable(tdo_tl070wsh30->supply);
+ if (err < 0)
+ return err;
+
+ usleep_range(10000, 11000);
+
+ gpiod_set_value_cansleep(tdo_tl070wsh30->reset_gpio, 1);
+
+ usleep_range(10000, 11000);
+
+ gpiod_set_value_cansleep(tdo_tl070wsh30->reset_gpio, 0);
+
+ msleep(200);
+
+ err = mipi_dsi_dcs_exit_sleep_mode(tdo_tl070wsh30->link);
+ if (err < 0) {
+ dev_err(panel->dev, "failed to exit sleep mode: %d\n", err);
+ regulator_disable(tdo_tl070wsh30->supply);
+ return err;
+ }
+
+ msleep(200);
+
+ err = mipi_dsi_dcs_set_display_on(tdo_tl070wsh30->link);
+ if (err < 0) {
+ dev_err(panel->dev, "failed to set display on: %d\n", err);
+ regulator_disable(tdo_tl070wsh30->supply);
+ return err;
+ }
+
+ msleep(20);
+
+ tdo_tl070wsh30->prepared = true;
+
+ return 0;
+}
+
+static int tdo_tl070wsh30_panel_unprepare(struct drm_panel *panel)
+{
+ struct tdo_tl070wsh30_panel *tdo_tl070wsh30 = to_tdo_tl070wsh30_panel(panel);
+ int err;
+
+ if (!tdo_tl070wsh30->prepared)
+ return 0;
+
+ err = mipi_dsi_dcs_set_display_off(tdo_tl070wsh30->link);
+ if (err < 0)
+ dev_err(panel->dev, "failed to set display off: %d\n", err);
+
+ usleep_range(10000, 11000);
+
+ err = mipi_dsi_dcs_enter_sleep_mode(tdo_tl070wsh30->link);
+ if (err < 0) {
+ dev_err(panel->dev, "failed to enter sleep mode: %d\n", err);
+ return err;
+ }
+
+ usleep_range(10000, 11000);
+
+ regulator_disable(tdo_tl070wsh30->supply);
+
+ tdo_tl070wsh30->prepared = false;
+
+ return 0;
+}
+
+static const struct drm_display_mode default_mode = {
+ .clock = 47250,
+ .hdisplay = 1024,
+ .hsync_start = 1024 + 46,
+ .hsync_end = 1024 + 46 + 80,
+ .htotal = 1024 + 46 + 80 + 100,
+ .vdisplay = 600,
+ .vsync_start = 600 + 5,
+ .vsync_end = 600 + 5 + 5,
+ .vtotal = 600 + 5 + 5 + 20,
+ .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static int tdo_tl070wsh30_panel_get_modes(struct drm_panel *panel,
+ struct drm_connector *connector)
+{
+ struct drm_display_mode *mode;
+
+ mode = drm_mode_duplicate(connector->dev, &default_mode);
+ if (!mode) {
+ dev_err(panel->dev, "failed to add mode %ux%u@%u\n",
+ default_mode.hdisplay, default_mode.vdisplay,
+ drm_mode_vrefresh(&default_mode));
+ return -ENOMEM;
+ }
+
+ drm_mode_set_name(mode);
+
+ drm_mode_probed_add(connector, mode);
+
+ connector->display_info.width_mm = 154;
+ connector->display_info.height_mm = 85;
+ connector->display_info.bpc = 8;
+
+ return 1;
+}
+
+static const struct drm_panel_funcs tdo_tl070wsh30_panel_funcs = {
+ .unprepare = tdo_tl070wsh30_panel_unprepare,
+ .prepare = tdo_tl070wsh30_panel_prepare,
+ .get_modes = tdo_tl070wsh30_panel_get_modes,
+};
+
+static const struct of_device_id tdo_tl070wsh30_of_match[] = {
+ { .compatible = "tdo,tl070wsh30", },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, tdo_tl070wsh30_of_match);
+
+static int tdo_tl070wsh30_panel_add(struct tdo_tl070wsh30_panel *tdo_tl070wsh30)
+{
+ struct device *dev = &tdo_tl070wsh30->link->dev;
+ int err;
+
+ tdo_tl070wsh30->supply = devm_regulator_get(dev, "power");
+ if (IS_ERR(tdo_tl070wsh30->supply))
+ return PTR_ERR(tdo_tl070wsh30->supply);
+
+ tdo_tl070wsh30->reset_gpio = devm_gpiod_get(dev, "reset",
+ GPIOD_OUT_LOW);
+ if (IS_ERR(tdo_tl070wsh30->reset_gpio)) {
+ err = PTR_ERR(tdo_tl070wsh30->reset_gpio);
+ dev_dbg(dev, "failed to get reset gpio: %d\n", err);
+ return err;
+ }
+
+ drm_panel_init(&tdo_tl070wsh30->base, &tdo_tl070wsh30->link->dev,
+ &tdo_tl070wsh30_panel_funcs, DRM_MODE_CONNECTOR_DSI);
+
+ err = drm_panel_of_backlight(&tdo_tl070wsh30->base);
+ if (err)
+ return err;
+
+ drm_panel_add(&tdo_tl070wsh30->base);
+
+ return 0;
+}
+
+static int tdo_tl070wsh30_panel_probe(struct mipi_dsi_device *dsi)
+{
+ struct tdo_tl070wsh30_panel *tdo_tl070wsh30;
+ int err;
+
+ dsi->lanes = 4;
+ dsi->format = MIPI_DSI_FMT_RGB888;
+ dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_LPM;
+
+ tdo_tl070wsh30 = devm_kzalloc(&dsi->dev, sizeof(*tdo_tl070wsh30),
+ GFP_KERNEL);
+ if (!tdo_tl070wsh30)
+ return -ENOMEM;
+
+ mipi_dsi_set_drvdata(dsi, tdo_tl070wsh30);
+ tdo_tl070wsh30->link = dsi;
+
+ err = tdo_tl070wsh30_panel_add(tdo_tl070wsh30);
+ if (err < 0)
+ return err;
+
+ return mipi_dsi_attach(dsi);
+}
+
+static int tdo_tl070wsh30_panel_remove(struct mipi_dsi_device *dsi)
+{
+ struct tdo_tl070wsh30_panel *tdo_tl070wsh30 = mipi_dsi_get_drvdata(dsi);
+ int err;
+
+ err = mipi_dsi_detach(dsi);
+ if (err < 0)
+ dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err);
+
+ drm_panel_remove(&tdo_tl070wsh30->base);
+ drm_panel_disable(&tdo_tl070wsh30->base);
+ drm_panel_unprepare(&tdo_tl070wsh30->base);
+
+ return 0;
+}
+
+static void tdo_tl070wsh30_panel_shutdown(struct mipi_dsi_device *dsi)
+{
+ struct tdo_tl070wsh30_panel *tdo_tl070wsh30 = mipi_dsi_get_drvdata(dsi);
+
+ drm_panel_disable(&tdo_tl070wsh30->base);
+ drm_panel_unprepare(&tdo_tl070wsh30->base);
+}
+
+static struct mipi_dsi_driver tdo_tl070wsh30_panel_driver = {
+ .driver = {
+ .name = "panel-tdo-tl070wsh30",
+ .of_match_table = tdo_tl070wsh30_of_match,
+ },
+ .probe = tdo_tl070wsh30_panel_probe,
+ .remove = tdo_tl070wsh30_panel_remove,
+ .shutdown = tdo_tl070wsh30_panel_shutdown,
+};
+module_mipi_dsi_driver(tdo_tl070wsh30_panel_driver);
+
+MODULE_AUTHOR("Neil Armstrong <narmstrong@baylibre.com>");
+MODULE_DESCRIPTION("TDO TL070WSH30 panel driver");
+MODULE_LICENSE("GPL v2");
--
2.22.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix
2020-09-15 12:19 ` [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix Neil Armstrong
@ 2020-09-23 1:28 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2020-09-23 1:28 UTC (permalink / raw)
To: Neil Armstrong
Cc: devicetree, linux-kernel, dri-devel, thierry.reding, linux-amlogic, sam
On Tue, 15 Sep 2020 14:19:09 +0200, Neil Armstrong wrote:
> Shanghai Top Display Optolelectronics Co., Ltd is a display manufacturer
> from Shanghai.
> Web site of the company: http://www.shtdo.com/
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/4] dt-bindings: display: panel-simple-dsi: add optional reset gpio
2020-09-15 12:19 ` [PATCH v4 2/4] dt-bindings: display: panel-simple-dsi: add optional reset gpio Neil Armstrong
@ 2020-09-23 1:28 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2020-09-23 1:28 UTC (permalink / raw)
To: Neil Armstrong
Cc: devicetree, linux-kernel, dri-devel, thierry.reding, linux-amlogic, sam
On Tue, 15 Sep 2020 14:19:10 +0200, Neil Armstrong wrote:
> Simple DSI panels can also have a reset GPIO signal in addition/instead of an
> enable GPIO signal.
>
> This adds an optional reset-gpios property.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/4] dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel bindings
2020-09-15 12:19 ` [PATCH v4 3/4] dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel bindings Neil Armstrong
@ 2020-09-23 1:28 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2020-09-23 1:28 UTC (permalink / raw)
To: Neil Armstrong
Cc: devicetree, linux-kernel, dri-devel, thierry.reding, linux-amlogic, sam
On Tue, 15 Sep 2020 14:19:11 +0200, Neil Armstrong wrote:
> This add the bindings for the 1024x600 TFT LCD TL070WSH30 DSI panel to panel-simple-dsi.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel
2020-09-15 12:19 [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel Neil Armstrong
` (3 preceding siblings ...)
2020-09-15 12:19 ` [PATCH v4 4/4] drm: panel: add TDO tl070wsh30 panel driver Neil Armstrong
@ 2020-09-29 9:25 ` Neil Armstrong
2020-10-17 6:08 ` Sam Ravnborg
4 siblings, 1 reply; 11+ messages in thread
From: Neil Armstrong @ 2020-09-29 9:25 UTC (permalink / raw)
To: thierry.reding, sam; +Cc: linux-amlogic, linux-kernel, dri-devel
Hi Sam,
Is there anything more to change ?
Thanks,
Neil
On 15/09/2020 14:19, Neil Armstrong wrote:
> This adds support bindings and support for the TDO TL070WSH30 TFT-LCD panel
> module shipped with the Amlogic S400 Development Kit.
> The panel has a 1024×600 resolution and uses 24 bit RGB per pixel.
> It provides a MIPI DSI interface to the host, a built-in LED backlight
> and touch controller.
>
> Changes since v3 at [3]:
> - reordered tdo vendor prefix
>
> Changes since v2 at [2]:
> - added reset gpio to panel-simple-dsi bindings
> - moved bindings to panel-simple
> - re-ordered prepare/unprepare
> - added back refresh print
> - moved regulator/reset handling in prepare/unprepare
> - aligned remove/shutdown with panel-simple
> - added sentinel comment into dt match table
>
> Changes since v1 at [1]:
> - added missing vendor-prefixes patch
> - removed vrefresh
> - fixed warning on add_panel return
> - removed DRM logging
>
> [1] https://patchwork.freedesktop.org/series/81376/#rev1
> [2] https://patchwork.freedesktop.org/series/81376/#rev2
> [3] https://patchwork.freedesktop.org/series/81376/#rev3
>
> Neil Armstrong (4):
> dt-bindings: vendor-prefixes: Add Shanghai Top Display
> Optolelectronics vendor prefix
> dt-bindings: display: panel-simple-dsi: add optional reset gpio
> dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel
> bindings
> drm: panel: add TDO tl070wsh30 panel driver
>
> .../display/panel/panel-simple-dsi.yaml | 3 +
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> drivers/gpu/drm/panel/Kconfig | 11 +
> drivers/gpu/drm/panel/Makefile | 1 +
> drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c | 250 ++++++++++++++++++
> 5 files changed, 267 insertions(+)
> create mode 100644 drivers/gpu/drm/panel/panel-tdo-tl070wsh30.c
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel
2020-09-29 9:25 ` [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel Neil Armstrong
@ 2020-10-17 6:08 ` Sam Ravnborg
2020-10-19 8:57 ` Neil Armstrong
0 siblings, 1 reply; 11+ messages in thread
From: Sam Ravnborg @ 2020-10-17 6:08 UTC (permalink / raw)
To: Neil Armstrong; +Cc: linux-amlogic, thierry.reding, linux-kernel, dri-devel
Hi Neil.
On Tue, Sep 29, 2020 at 11:25:17AM +0200, Neil Armstrong wrote:
> Hi Sam,
>
> Is there anything more to change ?
Sorry for taking so long to get back to you on this.
All patches looks good and are:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I assume you will apply the patches.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel
2020-10-17 6:08 ` Sam Ravnborg
@ 2020-10-19 8:57 ` Neil Armstrong
0 siblings, 0 replies; 11+ messages in thread
From: Neil Armstrong @ 2020-10-19 8:57 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: linux-amlogic, thierry.reding, linux-kernel, dri-devel
On 17/10/2020 08:08, Sam Ravnborg wrote:
> Hi Neil.
>
> On Tue, Sep 29, 2020 at 11:25:17AM +0200, Neil Armstrong wrote:
>> Hi Sam,
>>
>> Is there anything more to change ?
> Sorry for taking so long to get back to you on this.
>
> All patches looks good and are:
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>
> I assume you will apply the patches.
Indeed,
Thanks !
Applying to drm-misc-next
>
> Sam
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-10-19 8:57 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 12:19 [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel Neil Armstrong
2020-09-15 12:19 ` [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add Shanghai Top Display Optolelectronics vendor prefix Neil Armstrong
2020-09-23 1:28 ` Rob Herring
2020-09-15 12:19 ` [PATCH v4 2/4] dt-bindings: display: panel-simple-dsi: add optional reset gpio Neil Armstrong
2020-09-23 1:28 ` Rob Herring
2020-09-15 12:19 ` [PATCH v4 3/4] dt-bindings: display: panel-simple-dsi: add TDO TL070WSH30 DSI panel bindings Neil Armstrong
2020-09-23 1:28 ` Rob Herring
2020-09-15 12:19 ` [PATCH v4 4/4] drm: panel: add TDO tl070wsh30 panel driver Neil Armstrong
2020-09-29 9:25 ` [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel Neil Armstrong
2020-10-17 6:08 ` Sam Ravnborg
2020-10-19 8:57 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).