* [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
@ 2021-05-21 4:08 Vidya Srinivas
2021-05-21 11:29 ` [igt-dev] " Juha-Pekka Heikkila
0 siblings, 1 reply; 3+ messages in thread
From: Vidya Srinivas @ 2021-05-21 4:08 UTC (permalink / raw)
To: intel-gfx, dri-devel, igt-dev
Cc: markyacoub, Charlton.Lin, Vidya Srinivas, khaled.almahallawy
Without wait for vblank, CRC mismatch is seen
between big and small CRC on few systems
Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
tests/kms_big_fb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index b2027b6b9d1b..7d78ff829d41 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
static bool test_plane(data_t *data)
{
igt_plane_t *plane = data->plane;
+ igt_display_t *display = &data->display;
struct igt_fb *small_fb = &data->small_fb;
struct igt_fb *big_fb = &data->big_fb;
int w = data->big_fb_width - small_fb->width;
@@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
igt_plane_set_fb(plane, big_fb);
igt_fb_set_position(big_fb, plane, x, y);
igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
+
igt_plane_set_size(plane, data->width, data->height);
igt_display_commit2(&data->display, data->display.is_atomic ?
COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-
+ igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
igt_plane_set_fb(plane, NULL);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-21 4:08 [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC Vidya Srinivas
@ 2021-05-21 11:29 ` Juha-Pekka Heikkila
2021-05-21 14:22 ` Srinivas, Vidya
0 siblings, 1 reply; 3+ messages in thread
From: Juha-Pekka Heikkila @ 2021-05-21 11:29 UTC (permalink / raw)
To: Vidya Srinivas, intel-gfx, dri-devel, igt-dev; +Cc: Charlton.Lin
Hi Vidya,
on which machines this would help? I see there's many vblanks already
being waited. There's igt_display_commit2 which probably will block and
even if it didn't there's igt_pipe_crc_collect_crc(..) where crc
calculation is started after flip and then get one crc before disabling
crc counting again.
/Juha-Pekka
On 21.5.2021 7.08, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen
> between big and small CRC on few systems
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
> index b2027b6b9d1b..7d78ff829d41 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width;
> @@ -337,16 +338,17 @@ static bool test_plane(data_t *data)
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>
> -
> + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
2021-05-21 11:29 ` [igt-dev] " Juha-Pekka Heikkila
@ 2021-05-21 14:22 ` Srinivas, Vidya
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas, Vidya @ 2021-05-21 14:22 UTC (permalink / raw)
To: juhapekka.heikkila, intel-gfx, dri-devel, igt-dev; +Cc: Lin, Charlton
Hello Juha-Pekka
We are seeing the CRC failures on Jasperlake systems. Sometimes the test passes and sometimes it fails throwing CRC error.
Regards
Vidya
-----Original Message-----
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Sent: Friday, May 21, 2021 5:00 PM
To: Srinivas, Vidya <vidya.srinivas@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; igt-dev@lists.freedesktop.org
Cc: Lin, Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC
Hi Vidya,
on which machines this would help? I see there's many vblanks already being waited. There's igt_display_commit2 which probably will block and even if it didn't there's igt_pipe_crc_collect_crc(..) where crc calculation is started after flip and then get one crc before disabling crc counting again.
/Juha-Pekka
On 21.5.2021 7.08, Vidya Srinivas wrote:
> Without wait for vblank, CRC mismatch is seen between big and small
> CRC on few systems
>
> Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_big_fb.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index
> b2027b6b9d1b..7d78ff829d41 100644
> --- a/tests/kms_big_fb.c
> +++ b/tests/kms_big_fb.c
> @@ -254,6 +254,7 @@ static void unset_lut(data_t *data)
> static bool test_plane(data_t *data)
> {
> igt_plane_t *plane = data->plane;
> + igt_display_t *display = &data->display;
> struct igt_fb *small_fb = &data->small_fb;
> struct igt_fb *big_fb = &data->big_fb;
> int w = data->big_fb_width - small_fb->width; @@ -337,16 +338,17 @@
> static bool test_plane(data_t *data)
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>
> -
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc);
>
> igt_plane_set_fb(plane, big_fb);
> igt_fb_set_position(big_fb, plane, x, y);
> igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height);
> +
> igt_plane_set_size(plane, data->width, data->height);
> igt_display_commit2(&data->display, data->display.is_atomic ?
> COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -
> + igt_wait_for_vblank(data->drm_fd,
> +display->pipes[data->pipe].crtc_offset);
> igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc);
>
> igt_plane_set_fb(plane, NULL);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-21 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 4:08 [PATCH i-g-t] tests/kms_big_fb: Wait for vblank before collecting CRC Vidya Srinivas
2021-05-21 11:29 ` [igt-dev] " Juha-Pekka Heikkila
2021-05-21 14:22 ` Srinivas, Vidya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).