* [PATCH] dt-bindings: display/msm: Drop bogus interrupt flags cell on MDSS nodes
@ 2022-03-01 21:05 Rob Herring
2022-03-01 23:16 ` Dmitry Baryshkov
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2022-03-01 21:05 UTC (permalink / raw)
To: Rob Clark, Sean Paul, Abhinav Kumar, David Airlie, Daniel Vetter,
Krzysztof Kozlowski, Del Regno, Loic Poulain
Cc: linux-arm-msm, freedreno, linux-kernel, dri-devel, devicetree
The MDSS interrupt provider is a single cell, so specifying interrupt flags
on the consumers is incorrect.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/display/msm/dpu-msm8998.yaml | 4 ++--
.../devicetree/bindings/display/msm/dpu-qcm2290.yaml | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
index 167bc48748d7..2df64afb76e6 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
@@ -155,7 +155,7 @@ examples:
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/power/qcom-rpmpd.h>
- display-subsystem@c900000 {
+ mdss: display-subsystem@c900000 {
compatible = "qcom,msm8998-mdss";
reg = <0x0c900000 0x1000>;
reg-names = "mdss";
@@ -192,7 +192,7 @@ examples:
clock-names = "iface", "bus", "mnoc", "core", "vsync";
interrupt-parent = <&mdss>;
- interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <0>;
operating-points-v2 = <&mdp_opp_table>;
power-domains = <&rpmpd MSM8998_VDDMX>;
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
index 8766b13f0c46..28617bc1d2ff 100644
--- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
@@ -197,7 +197,7 @@ examples:
power-domains = <&rpmpd QCM2290_VDDCX>;
interrupt-parent = <&mdss>;
- interrupts = <0 IRQ_TYPE_NONE>;
+ interrupts = <0>;
ports {
#address-cells = <1>;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: display/msm: Drop bogus interrupt flags cell on MDSS nodes
2022-03-01 21:05 [PATCH] dt-bindings: display/msm: Drop bogus interrupt flags cell on MDSS nodes Rob Herring
@ 2022-03-01 23:16 ` Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2022-03-01 23:16 UTC (permalink / raw)
To: Rob Herring
Cc: freedreno, Loic Poulain, Krzysztof Kozlowski, David Airlie,
linux-arm-msm, Abhinav Kumar, dri-devel, linux-kernel, Del Regno,
Sean Paul, devicetree
On Wed, 2 Mar 2022 at 00:05, Rob Herring <robh@kernel.org> wrote:
>
> The MDSS interrupt provider is a single cell, so specifying interrupt flags
> on the consumers is incorrect.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../devicetree/bindings/display/msm/dpu-msm8998.yaml | 4 ++--
> .../devicetree/bindings/display/msm/dpu-qcm2290.yaml | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
> index 167bc48748d7..2df64afb76e6 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml
> @@ -155,7 +155,7 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/qcom-rpmpd.h>
>
> - display-subsystem@c900000 {
> + mdss: display-subsystem@c900000 {
> compatible = "qcom,msm8998-mdss";
> reg = <0x0c900000 0x1000>;
> reg-names = "mdss";
> @@ -192,7 +192,7 @@ examples:
> clock-names = "iface", "bus", "mnoc", "core", "vsync";
>
> interrupt-parent = <&mdss>;
> - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <0>;
> operating-points-v2 = <&mdp_opp_table>;
> power-domains = <&rpmpd MSM8998_VDDMX>;
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> index 8766b13f0c46..28617bc1d2ff 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> @@ -197,7 +197,7 @@ examples:
> power-domains = <&rpmpd QCM2290_VDDCX>;
>
> interrupt-parent = <&mdss>;
> - interrupts = <0 IRQ_TYPE_NONE>;
> + interrupts = <0>;
>
> ports {
> #address-cells = <1>;
> --
> 2.32.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-01 23:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01 21:05 [PATCH] dt-bindings: display/msm: Drop bogus interrupt flags cell on MDSS nodes Rob Herring
2022-03-01 23:16 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).