* [PATCH] drm/msm/dpu: add writeback support for sc7180
@ 2022-05-10 23:54 Abhinav Kumar
2022-05-11 0:20 ` Dmitry Baryshkov
0 siblings, 1 reply; 2+ messages in thread
From: Abhinav Kumar @ 2022-05-10 23:54 UTC (permalink / raw)
To: freedreno
Cc: markyacoub, Abhinav Kumar, dri-devel, swboyd, seanpaul,
dmitry.baryshkov, quic_jesszhan, quic_aravindh, quic_khsieh
Add writeback support for sc7180 devices. This has been
validated on sc7180 chromebook using IGT writeback test
suite.
localhost /usr/local/libexec/igt-gpu-tools # ./kms_writeback
Starting subtest: writeback-pixel-formats
Subtest writeback-pixel-formats: SUCCESS (0.001s)
Starting subtest: writeback-invalid-parameters
Subtest writeback-invalid-parameters: SUCCESS (0.004s)
Starting subtest: writeback-fb-id
Subtest writeback-fb-id: SUCCESS (0.009s)
Starting subtest: writeback-check-output
Subtest writeback-check-output: SUCCESS (0.203s)
Adding this will increase IGT coverage on chromebooks and also
allow using writeback functionality for other use-cases as
necessary.
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index 400ebceb56bb..210becd2a9b7 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -1803,6 +1803,8 @@ static void sc7180_cfg_init(struct dpu_mdss_cfg *dpu_cfg)
.pingpong = sc7180_pp,
.intf_count = ARRAY_SIZE(sc7180_intf),
.intf = sc7180_intf,
+ .wb_count = ARRAY_SIZE(sm8250_wb),
+ .wb = sm8250_wb,
.vbif_count = ARRAY_SIZE(sdm845_vbif),
.vbif = sdm845_vbif,
.reg_dma_count = 1,
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/msm/dpu: add writeback support for sc7180
2022-05-10 23:54 [PATCH] drm/msm/dpu: add writeback support for sc7180 Abhinav Kumar
@ 2022-05-11 0:20 ` Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2022-05-11 0:20 UTC (permalink / raw)
To: Abhinav Kumar
Cc: markyacoub, dri-devel, swboyd, seanpaul, quic_jesszhan,
quic_aravindh, quic_khsieh, freedreno
On Wed, 11 May 2022 at 02:55, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>
> Add writeback support for sc7180 devices. This has been
> validated on sc7180 chromebook using IGT writeback test
> suite.
>
> localhost /usr/local/libexec/igt-gpu-tools # ./kms_writeback
> Starting subtest: writeback-pixel-formats
> Subtest writeback-pixel-formats: SUCCESS (0.001s)
> Starting subtest: writeback-invalid-parameters
> Subtest writeback-invalid-parameters: SUCCESS (0.004s)
> Starting subtest: writeback-fb-id
> Subtest writeback-fb-id: SUCCESS (0.009s)
> Starting subtest: writeback-check-output
> Subtest writeback-check-output: SUCCESS (0.203s)
>
> Adding this will increase IGT coverage on chromebooks and also
> allow using writeback functionality for other use-cases as
> necessary.
>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 400ebceb56bb..210becd2a9b7 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -1803,6 +1803,8 @@ static void sc7180_cfg_init(struct dpu_mdss_cfg *dpu_cfg)
> .pingpong = sc7180_pp,
> .intf_count = ARRAY_SIZE(sc7180_intf),
> .intf = sc7180_intf,
> + .wb_count = ARRAY_SIZE(sm8250_wb),
> + .wb = sm8250_wb,
> .vbif_count = ARRAY_SIZE(sdm845_vbif),
> .vbif = sdm845_vbif,
> .reg_dma_count = 1,
> --
> 2.35.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-11 0:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 23:54 [PATCH] drm/msm/dpu: add writeback support for sc7180 Abhinav Kumar
2022-05-11 0:20 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).