From: Linus Walleij <linus.walleij@linaro.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Dom Cobley <dom@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
David Airlie <airlied@linux.ie>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@intel.com>,
Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH 1/2] drm/vc4: hdmi: Fix error path of hpd-gpios
Date: Fri, 4 Jun 2021 23:44:39 +0200 [thread overview]
Message-ID: <CACRpkdbpfJ6Kc-W3jQNKZqwqy+utSV02NC26KEEA14eXtk9vMw@mail.gmail.com> (raw)
In-Reply-To: <20210524131852.263883-1-maxime@cerno.tech>
On Mon, May 24, 2021 at 3:19 PM Maxime Ripard <maxime@cerno.tech> wrote:
> If the of_get_named_gpio_flags call fails in vc4_hdmi_bind, we jump to
> the err_unprepare_hsm label. That label will then call
> pm_runtime_disable and put_device on the DDC device.
>
> We just retrieved the DDC device, so the latter is definitely justified.
> However at that point we still haven't called pm_runtime_enable, so the
> call to pm_runtime_disable is not supposed to be there.
>
> Fixes: 10ee275cb12f ("drm/vc4: prepare for CEC support")
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
prev parent reply other threads:[~2021-06-04 21:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 13:18 [PATCH 1/2] drm/vc4: hdmi: Fix error path of hpd-gpios Maxime Ripard
2021-05-24 13:18 ` [PATCH 2/2] drm/vc4: hdmi: Convert to gpiod Maxime Ripard
2021-05-27 23:57 ` Linus Walleij
2021-06-04 8:01 ` Maxime Ripard
2021-06-04 21:45 ` Linus Walleij
2021-06-07 7:32 ` Maxime Ripard
2021-07-02 3:29 ` Nathan Chancellor
2021-07-02 13:16 ` Maxime Ripard
2021-07-03 5:01 ` Nathan Chancellor
2021-06-04 21:44 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbpfJ6Kc-W3jQNKZqwqy+utSV02NC26KEEA14eXtk9vMw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=phil@raspberrypi.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).