* [PATCH] drm/hisilicon: Use devm_platform_get_and_ioremap_resource() in dsi_parse_dt()
@ 2024-02-05 8:12 Markus Elfring
2024-02-05 17:55 ` John Stultz
2024-02-05 18:11 ` Doug Anderson
0 siblings, 2 replies; 4+ messages in thread
From: Markus Elfring @ 2024-02-05 8:12 UTC (permalink / raw)
To: dri-devel, kernel-janitors, Daniel Vetter, David Airlie,
Douglas Anderson, John Stultz, Laurent Pinchart,
Maarten Lankhorst, Maxime Ripard, Sumit Semwal,
Thomas Zimmermann, Tian Tao, Uwe Kleine-König, Xinliang Liu,
Xinwei Kong, Yongqin Liu
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 5 Feb 2024 08:58:21 +0100
A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
index 566de4658719..1edf429c49d7 100644
--- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
+++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
@@ -834,8 +834,7 @@ static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
return PTR_ERR(ctx->pclk);
}
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ctx->base = devm_ioremap_resource(&pdev->dev, res);
+ ctx->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(ctx->base)) {
DRM_ERROR("failed to remap dsi io region\n");
return PTR_ERR(ctx->base);
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/hisilicon: Use devm_platform_get_and_ioremap_resource() in dsi_parse_dt()
2024-02-05 8:12 [PATCH] drm/hisilicon: Use devm_platform_get_and_ioremap_resource() in dsi_parse_dt() Markus Elfring
@ 2024-02-05 17:55 ` John Stultz
2024-02-05 18:11 ` Doug Anderson
1 sibling, 0 replies; 4+ messages in thread
From: John Stultz @ 2024-02-05 17:55 UTC (permalink / raw)
To: Markus Elfring
Cc: dri-devel, kernel-janitors, Daniel Vetter, David Airlie,
Douglas Anderson, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Sumit Semwal, Thomas Zimmermann, Tian Tao,
Uwe Kleine-König, Xinliang Liu, Xinwei Kong, Yongqin Liu,
LKML
On Mon, Feb 5, 2024 at 12:13 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 5 Feb 2024 08:58:21 +0100
>
> A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
> ("drivers: provide devm_platform_get_and_ioremap_resource()").
> Thus reuse existing functionality instead of keeping duplicate source code.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
I no longer have hardware to test with this, but this looks reasonable to me.
Acked-by: John Stultz <jstultz@google.com>
thanks
-john
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/hisilicon: Use devm_platform_get_and_ioremap_resource() in dsi_parse_dt()
2024-02-05 8:12 [PATCH] drm/hisilicon: Use devm_platform_get_and_ioremap_resource() in dsi_parse_dt() Markus Elfring
2024-02-05 17:55 ` John Stultz
@ 2024-02-05 18:11 ` Doug Anderson
2024-02-06 19:02 ` [PATCH v2] drm/hisilicon: Use devm_platform_ioremap_resource() " Markus Elfring
1 sibling, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2024-02-05 18:11 UTC (permalink / raw)
To: Markus Elfring
Cc: dri-devel, kernel-janitors, Daniel Vetter, David Airlie,
John Stultz, Laurent Pinchart, Maarten Lankhorst, Maxime Ripard,
Sumit Semwal, Thomas Zimmermann, Tian Tao, Uwe Kleine-König,
Xinliang Liu, Xinwei Kong, Yongqin Liu, LKML
Hi,
On Mon, Feb 5, 2024 at 12:13 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 5 Feb 2024 08:58:21 +0100
>
> A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
> ("drivers: provide devm_platform_get_and_ioremap_resource()").
> Thus reuse existing functionality instead of keeping duplicate source code.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> index 566de4658719..1edf429c49d7 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> @@ -834,8 +834,7 @@ static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
> return PTR_ERR(ctx->pclk);
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ctx->base = devm_ioremap_resource(&pdev->dev, res);
> + ctx->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(ctx->base)) {
> DRM_ERROR("failed to remap dsi io region\n");
> return PTR_ERR(ctx->base);
This function no longer needs the local variable "res". Remove it and
then change the function call to devm_platform_ioremap_resource().
With that:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] drm/hisilicon: Use devm_platform_ioremap_resource() in dsi_parse_dt()
2024-02-05 18:11 ` Doug Anderson
@ 2024-02-06 19:02 ` Markus Elfring
0 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2024-02-06 19:02 UTC (permalink / raw)
To: Douglas Anderson, dri-devel, kernel-janitors, Daniel Vetter,
David Airlie, John Stultz, Laurent Pinchart, Maarten Lankhorst,
Maxime Ripard, Sumit Semwal, Thomas Zimmermann, Tian Tao,
Uwe Kleine-König, Xinliang Liu, Xinwei Kong, Yongqin Liu
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 6 Feb 2024 19:51:25 +0100
A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42
("drivers: provide devm_platform_ioremap_resource()").
* Thus reuse existing functionality instead of keeping duplicate source code.
* Delete a local variable which became unnecessary with this refactoring.
This issue was transformed by using the Coccinelle software.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v2:
The transformation pattern was adjusted based on advices by known contributors.
Examples:
* Douglas Anderson
* Geert Uytterhoeven
* Robin Murphy
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
index 566de4658719..6db6f355394c 100644
--- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
+++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
@@ -826,7 +826,6 @@ static const struct component_ops dsi_ops = {
static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
{
struct dsi_hw_ctx *ctx = dsi->ctx;
- struct resource *res;
ctx->pclk = devm_clk_get(&pdev->dev, "pclk");
if (IS_ERR(ctx->pclk)) {
@@ -834,8 +833,7 @@ static int dsi_parse_dt(struct platform_device *pdev, struct dw_dsi *dsi)
return PTR_ERR(ctx->pclk);
}
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ctx->base = devm_ioremap_resource(&pdev->dev, res);
+ ctx->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ctx->base)) {
DRM_ERROR("failed to remap dsi io region\n");
return PTR_ERR(ctx->base);
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-06 19:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-05 8:12 [PATCH] drm/hisilicon: Use devm_platform_get_and_ioremap_resource() in dsi_parse_dt() Markus Elfring
2024-02-05 17:55 ` John Stultz
2024-02-05 18:11 ` Doug Anderson
2024-02-06 19:02 ` [PATCH v2] drm/hisilicon: Use devm_platform_ioremap_resource() " Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).