dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: make two symbols static
@ 2020-09-28  2:35 Jason Yan
  2020-09-28 14:06 ` Harry Wentland
  0 siblings, 1 reply; 3+ messages in thread
From: Jason Yan @ 2020-09-28  2:35 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	airlied, daniel, Anthony.Koo, amd-gfx, dri-devel

This addresses the following sparse warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6:
warning: symbol 'dce110_set_cursor_position' was not declared. Should it
be static?
drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2785:6:
warning: symbol 'dce110_set_cursor_attribute' was not declared. Should
it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index 1002ce9979dc..31a8d3452e83 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -2737,7 +2737,7 @@ static void program_output_csc(struct dc *dc,
 	}
 }
 
-void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx)
+static void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx)
 {
 	struct dc_cursor_position pos_cpy = pipe_ctx->stream->cursor_position;
 	struct input_pixel_processor *ipp = pipe_ctx->plane_res.ipp;
@@ -2782,7 +2782,7 @@ void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx)
 		mi->funcs->set_cursor_position(mi, &pos_cpy, &param);
 }
 
-void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx)
+static void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx)
 {
 	struct dc_cursor_attributes *attributes = &pipe_ctx->stream->cursor_attributes;
 
-- 
2.25.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: make two symbols static
  2020-09-28  2:35 [PATCH] drm/amd/display: make two symbols static Jason Yan
@ 2020-09-28 14:06 ` Harry Wentland
  2020-09-28 21:36   ` Alex Deucher
  0 siblings, 1 reply; 3+ messages in thread
From: Harry Wentland @ 2020-09-28 14:06 UTC (permalink / raw)
  To: Jason Yan, sunpeng.li, alexander.deucher, christian.koenig,
	airlied, daniel, Anthony.Koo, amd-gfx, dri-devel

On 2020-09-27 10:35 p.m., Jason Yan wrote:
> This addresses the following sparse warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6:
> warning: symbol 'dce110_set_cursor_position' was not declared. Should it
> be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2785:6:
> warning: symbol 'dce110_set_cursor_attribute' was not declared. Should
> it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index 1002ce9979dc..31a8d3452e83 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -2737,7 +2737,7 @@ static void program_output_csc(struct dc *dc,
>  	}
>  }
>  
> -void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx)
> +static void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx)
>  {
>  	struct dc_cursor_position pos_cpy = pipe_ctx->stream->cursor_position;
>  	struct input_pixel_processor *ipp = pipe_ctx->plane_res.ipp;
> @@ -2782,7 +2782,7 @@ void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx)
>  		mi->funcs->set_cursor_position(mi, &pos_cpy, &param);
>  }
>  
> -void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx)
> +static void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx)
>  {
>  	struct dc_cursor_attributes *attributes = &pipe_ctx->stream->cursor_attributes;
>  
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: make two symbols static
  2020-09-28 14:06 ` Harry Wentland
@ 2020-09-28 21:36   ` Alex Deucher
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2020-09-28 21:36 UTC (permalink / raw)
  To: Harry Wentland
  Cc: Jason Yan, Leo (Sunpeng) Li, amd-gfx list, Dave Airlie,
	Maling list - DRI developers, Deucher, Alexander, Anthony Koo,
	Christian Koenig

Applied.  Thanks!

Alex

On Mon, Sep 28, 2020 at 10:06 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2020-09-27 10:35 p.m., Jason Yan wrote:
> > This addresses the following sparse warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2740:6:
> > warning: symbol 'dce110_set_cursor_position' was not declared. Should it
> > be static?
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2785:6:
> > warning: symbol 'dce110_set_cursor_attribute' was not declared. Should
> > it be static?
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Jason Yan <yanaijie@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > index 1002ce9979dc..31a8d3452e83 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> > @@ -2737,7 +2737,7 @@ static void program_output_csc(struct dc *dc,
> >       }
> >  }
> >
> > -void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx)
> > +static void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx)
> >  {
> >       struct dc_cursor_position pos_cpy = pipe_ctx->stream->cursor_position;
> >       struct input_pixel_processor *ipp = pipe_ctx->plane_res.ipp;
> > @@ -2782,7 +2782,7 @@ void dce110_set_cursor_position(struct pipe_ctx *pipe_ctx)
> >               mi->funcs->set_cursor_position(mi, &pos_cpy, &param);
> >  }
> >
> > -void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx)
> > +static void dce110_set_cursor_attribute(struct pipe_ctx *pipe_ctx)
> >  {
> >       struct dc_cursor_attributes *attributes = &pipe_ctx->stream->cursor_attributes;
> >
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-28 21:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28  2:35 [PATCH] drm/amd/display: make two symbols static Jason Yan
2020-09-28 14:06 ` Harry Wentland
2020-09-28 21:36   ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).