Re: [Intel-gfx] [RFC 0/8] Per client GPU stats

[Alex Deucher <alexdeucher@gmail.com>]

On Fri, Jul 23, 2021 at 9:51 AM Tvrtko Ursulin
<tvrtko.ursulin@linux.intel.com> wrote:
>
>
> On 23/07/2021 12:23, Christian König wrote:
> > Am 23.07.21 um 13:21 schrieb Tvrtko Ursulin:
> >>
> >> On 15/07/2021 10:18, Tvrtko Ursulin wrote:
> >>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>>
> >>> Same old work but now rebased and series ending with some DRM docs
> >>> proposing
> >>> the common specification which should enable nice common userspace
> >>> tools to be
> >>> written.
> >>>
> >>> For the moment I only have intel_gpu_top converted to use this and
> >>> that seems to
> >>> work okay.
> >>>
> >>> v2:
> >>>   * Added prototype of possible amdgpu changes and spec updates to
> >>> align with the
> >>>     common spec.
> >>
> >> Not much interest for the common specification?
> >
> > Well I would rather say not much opposition :)
>
> Hah, thanks, that's good to hear!
>
> > Of hand everything you do in this patch set sounds absolutely sane to
> > me, just don't have any time to review it in detail.
>
> That's fine - could you maybe suggest who on the AMD side could have a
> look at the relevant patches?

Adding David and Roy who did the implementation for the AMD side.  Can
you take a look at these patches when you get a chance?

Thanks,

Alex


>
> Regards,
>
> Tvrtko
>
> >> For reference I've just posted the intel-gpu-top adaptation required
> >> to parse it here:
> >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fpatch%2F446041%2F%3Fseries%3D90464%26rev%3D2&amp;data=04%7C01%7Cchristian.koenig%40amd.com%7Cc967de8b8c2b499eb25b08d94dcbff2e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637626360837958764%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=07hzP1RuVQkFi8AXWK8i%2Ffu9ajnldcF36PLRrey5wXA%3D&amp;reserved=0.
> >>
> >>
> >> Note that this is not attempting to be a vendor agnostic tool but is
> >> adding per client data to existing i915 tool which uses PMU counters
> >> for global stats.
> >>
> >> intel-gpu-top: Intel Skylake (Gen9) @ /dev/dri/card0 -  335/ 339 MHz;
> >> 10% RC6;  1.24/ 4.18 W;      527 irqs/s
> >>
> >>       IMC reads:     3297 MiB/s
> >>      IMC writes:     2767 MiB/s
> >>
> >>          ENGINES BUSY MI_SEMA MI_WAIT
> >>        Render/3D   78.74%
> >> |██████████████████████████████████████████████████████████████████████████▏
> >> |      0%      0%
> >>          Blitter    0.00% | |      0%      0%
> >>            Video    0.00% | |      0%      0%
> >>     VideoEnhance    0.00% | |      0%      0%
> >>
> >>    PID              NAME          Render/3D
> >> Blitter                      Video                    VideoEnhance
> >>  10202         neverball |███████████████▎ || ||
> >> ||                          |
> >>   5665              Xorg |███████▍ ||                          ||
> >> ||                          |
> >>   5679     xfce4-session | ||                          ||
> >> ||                          |
> >>   5772      ibus-ui-gtk3 | ||                          ||
> >> ||                          |
> >>   5775   ibus-extension- | ||                          ||
> >> ||                          |
> >>   5777          ibus-x11 | ||                          ||
> >> ||                          |
> >>   5823             xfwm4 | ||                          ||
> >> ||                          |
> >>
> >>
> >> Regards,
> >>
> >> Tvrtko
> >>
> >>> Tvrtko Ursulin (8):
> >>>    drm/i915: Explicitly track DRM clients
> >>>    drm/i915: Make GEM contexts track DRM clients
> >>>    drm/i915: Track runtime spent in closed and unreachable GEM contexts
> >>>    drm/i915: Track all user contexts per client
> >>>    drm/i915: Track context current active time
> >>>    drm: Document fdinfo format specification
> >>>    drm/i915: Expose client engine utilisation via fdinfo
> >>>    drm/amdgpu: Convert to common fdinfo format
> >>>
> >>>   Documentation/gpu/amdgpu.rst                  |  26 ++++
> >>>   Documentation/gpu/drm-usage-stats.rst         | 108 +++++++++++++
> >>>   Documentation/gpu/i915.rst                    |  27 ++++
> >>>   Documentation/gpu/index.rst                   |   1 +
> >>>   drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c    |  18 ++-
> >>>   drivers/gpu/drm/i915/Makefile                 |   5 +-
> >>>   drivers/gpu/drm/i915/gem/i915_gem_context.c   |  42 ++++-
> >>>   .../gpu/drm/i915/gem/i915_gem_context_types.h |   6 +
> >>>   drivers/gpu/drm/i915/gt/intel_context.c       |  27 +++-
> >>>   drivers/gpu/drm/i915/gt/intel_context.h       |  15 +-
> >>>   drivers/gpu/drm/i915/gt/intel_context_types.h |  24 ++-
> >>>   .../drm/i915/gt/intel_execlists_submission.c  |  23 ++-
> >>>   .../gpu/drm/i915/gt/intel_gt_clock_utils.c    |   4 +
> >>>   drivers/gpu/drm/i915/gt/intel_lrc.c           |  27 ++--
> >>>   drivers/gpu/drm/i915/gt/intel_lrc.h           |  24 +++
> >>>   drivers/gpu/drm/i915/gt/selftest_lrc.c        |  10 +-
> >>>   drivers/gpu/drm/i915/i915_drm_client.c        | 143 ++++++++++++++++++
> >>>   drivers/gpu/drm/i915/i915_drm_client.h        |  66 ++++++++
> >>>   drivers/gpu/drm/i915/i915_drv.c               |   9 ++
> >>>   drivers/gpu/drm/i915/i915_drv.h               |   5 +
> >>>   drivers/gpu/drm/i915/i915_gem.c               |  21 ++-
> >>>   drivers/gpu/drm/i915/i915_gpu_error.c         |   9 +-
> >>>   drivers/gpu/drm/i915/i915_gpu_error.h         |   2 +-
> >>>   23 files changed, 581 insertions(+), 61 deletions(-)
> >>>   create mode 100644 Documentation/gpu/drm-usage-stats.rst
> >>>   create mode 100644 drivers/gpu/drm/i915/i915_drm_client.c
> >>>   create mode 100644 drivers/gpu/drm/i915/i915_drm_client.h
> >>>
> >