dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Intel-gfx@lists.freedesktop.org
Cc: "Christian König" <christian.koenig@amd.com>,
	dri-devel@lists.freedesktop.org, "Nieto,
	David M" <David.Nieto@amd.com>
Subject: Re: [Intel-gfx] [RFC 0/8] Per client GPU stats
Date: Fri, 23 Jul 2021 12:21:12 +0100	[thread overview]
Message-ID: <e6f53b40-b8bf-3d2b-2dbe-a568254e15d3@linux.intel.com> (raw)
In-Reply-To: <20210715091820.1613726-1-tvrtko.ursulin@linux.intel.com>


On 15/07/2021 10:18, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> Same old work but now rebased and series ending with some DRM docs proposing
> the common specification which should enable nice common userspace tools to be
> written.
> 
> For the moment I only have intel_gpu_top converted to use this and that seems to
> work okay.
> 
> v2:
>   * Added prototype of possible amdgpu changes and spec updates to align with the
>     common spec.

Not much interest for the common specification?

For reference I've just posted the intel-gpu-top adaptation required to parse it here: https://patchwork.freedesktop.org/patch/446041/?series=90464&rev=2.

Note that this is not attempting to be a vendor agnostic tool but is adding per client data to existing i915 tool which uses PMU counters for global stats.

intel-gpu-top: Intel Skylake (Gen9) @ /dev/dri/card0 -  335/ 339 MHz;  10% RC6;  1.24/ 4.18 W;      527 irqs/s

       IMC reads:     3297 MiB/s
      IMC writes:     2767 MiB/s

          ENGINES     BUSY                                                                                                  MI_SEMA MI_WAIT
        Render/3D   78.74% |██████████████████████████████████████████████████████████████████████████▏                   |      0%      0%
          Blitter    0.00% |                                                                                              |      0%      0%
            Video    0.00% |                                                                                              |      0%      0%
     VideoEnhance    0.00% |                                                                                              |      0%      0%

    PID              NAME          Render/3D                    Blitter                      Video                    VideoEnhance
  10202         neverball |███████████████▎          ||                          ||                          ||                          |
   5665              Xorg |███████▍                  ||                          ||                          ||                          |
   5679     xfce4-session |                          ||                          ||                          ||                          |
   5772      ibus-ui-gtk3 |                          ||                          ||                          ||                          |
   5775   ibus-extension- |                          ||                          ||                          ||                          |
   5777          ibus-x11 |                          ||                          ||                          ||                          |
   5823             xfwm4 |                          ||                          ||                          ||                          |


Regards,

Tvrtko
  
> Tvrtko Ursulin (8):
>    drm/i915: Explicitly track DRM clients
>    drm/i915: Make GEM contexts track DRM clients
>    drm/i915: Track runtime spent in closed and unreachable GEM contexts
>    drm/i915: Track all user contexts per client
>    drm/i915: Track context current active time
>    drm: Document fdinfo format specification
>    drm/i915: Expose client engine utilisation via fdinfo
>    drm/amdgpu: Convert to common fdinfo format
> 
>   Documentation/gpu/amdgpu.rst                  |  26 ++++
>   Documentation/gpu/drm-usage-stats.rst         | 108 +++++++++++++
>   Documentation/gpu/i915.rst                    |  27 ++++
>   Documentation/gpu/index.rst                   |   1 +
>   drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c    |  18 ++-
>   drivers/gpu/drm/i915/Makefile                 |   5 +-
>   drivers/gpu/drm/i915/gem/i915_gem_context.c   |  42 ++++-
>   .../gpu/drm/i915/gem/i915_gem_context_types.h |   6 +
>   drivers/gpu/drm/i915/gt/intel_context.c       |  27 +++-
>   drivers/gpu/drm/i915/gt/intel_context.h       |  15 +-
>   drivers/gpu/drm/i915/gt/intel_context_types.h |  24 ++-
>   .../drm/i915/gt/intel_execlists_submission.c  |  23 ++-
>   .../gpu/drm/i915/gt/intel_gt_clock_utils.c    |   4 +
>   drivers/gpu/drm/i915/gt/intel_lrc.c           |  27 ++--
>   drivers/gpu/drm/i915/gt/intel_lrc.h           |  24 +++
>   drivers/gpu/drm/i915/gt/selftest_lrc.c        |  10 +-
>   drivers/gpu/drm/i915/i915_drm_client.c        | 143 ++++++++++++++++++
>   drivers/gpu/drm/i915/i915_drm_client.h        |  66 ++++++++
>   drivers/gpu/drm/i915/i915_drv.c               |   9 ++
>   drivers/gpu/drm/i915/i915_drv.h               |   5 +
>   drivers/gpu/drm/i915/i915_gem.c               |  21 ++-
>   drivers/gpu/drm/i915/i915_gpu_error.c         |   9 +-
>   drivers/gpu/drm/i915/i915_gpu_error.h         |   2 +-
>   23 files changed, 581 insertions(+), 61 deletions(-)
>   create mode 100644 Documentation/gpu/drm-usage-stats.rst
>   create mode 100644 drivers/gpu/drm/i915/i915_drm_client.c
>   create mode 100644 drivers/gpu/drm/i915/i915_drm_client.h
> 

  parent reply	other threads:[~2021-07-23 11:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15  9:18 [RFC 0/8] Per client GPU stats Tvrtko Ursulin
2021-07-15  9:18 ` [RFC 1/8] drm/i915: Explicitly track DRM clients Tvrtko Ursulin
2021-07-15  9:18 ` [RFC 2/8] drm/i915: Make GEM contexts " Tvrtko Ursulin
2021-07-15  9:18 ` [RFC 3/8] drm/i915: Track runtime spent in closed and unreachable GEM contexts Tvrtko Ursulin
2021-07-15  9:18 ` [RFC 4/8] drm/i915: Track all user contexts per client Tvrtko Ursulin
2021-07-15  9:18 ` [RFC 5/8] drm/i915: Track context current active time Tvrtko Ursulin
2021-07-15  9:18 ` [RFC 6/8] drm: Document fdinfo format specification Tvrtko Ursulin
2021-07-23 16:43   ` Daniel Stone
2021-07-23 16:47     ` Daniel Vetter
2021-07-23 17:45       ` Nieto, David M
2021-07-26  9:01         ` Tvrtko Ursulin
2021-07-26  8:57     ` Tvrtko Ursulin
2021-07-15  9:18 ` [RFC 7/8] drm/i915: Expose client engine utilisation via fdinfo Tvrtko Ursulin
2021-07-15  9:18 ` [RFC 8/8] drm/amdgpu: Convert to common fdinfo format Tvrtko Ursulin
2021-07-23 13:56   ` Alex Deucher
2021-07-23 11:21 ` Tvrtko Ursulin [this message]
2021-07-23 11:23   ` [Intel-gfx] [RFC 0/8] Per client GPU stats Christian König
2021-07-23 13:50     ` Tvrtko Ursulin
2021-07-23 13:55       ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6f53b40-b8bf-3d2b-2dbe-a568254e15d3@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=David.Nieto@amd.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).