dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/amd: add missing fill of the array`s first element
@ 2020-06-12 11:58 Bernard Zhao
  2020-06-12 15:27 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: Bernard Zhao @ 2020-06-12 11:58 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
	David Airlie, Daniel Vetter, Anthony Koo, Rodrigo Siqueira,
	Wyatt Wood, Josip Pavic, Bernard Zhao, amd-gfx, dri-devel,
	linux-kernel
  Cc: opensource.kernel

In function fill_iram_v_2, the ram_table->bright_neg_gain`s
first element [0][0] seems to be missing. This change is just
to make the code a bit readable.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
index 8c37bcc27132..7604a01be19c 100644
--- a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
+++ b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
@@ -350,6 +350,7 @@ void fill_iram_v_2(struct iram_table_v_2 *ram_table, struct dmcu_iram_parameters
 	ram_table->bright_pos_gain[4][1] = 0x20;
 	ram_table->bright_pos_gain[4][2] = 0x20;
 	ram_table->bright_pos_gain[4][3] = 0x20;
+	ram_table->bright_neg_gain[0][0] = 0x00;
 	ram_table->bright_neg_gain[0][1] = 0x00;
 	ram_table->bright_neg_gain[0][2] = 0x00;
 	ram_table->bright_neg_gain[0][3] = 0x00;
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amd: add missing fill of the array`s first element
  2020-06-12 11:58 [PATCH] drm/amd: add missing fill of the array`s first element Bernard Zhao
@ 2020-06-12 15:27 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2020-06-12 15:27 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: opensource.kernel, Josip Pavic, Leo Li, Anthony Koo,
	Rodrigo Siqueira, LKML, amd-gfx list, David Airlie,
	Maling list - DRI developers, Wyatt Wood, Alex Deucher,
	Christian König

On Fri, Jun 12, 2020 at 9:22 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> In function fill_iram_v_2, the ram_table->bright_neg_gain`s
> first element [0][0] seems to be missing. This change is just
> to make the code a bit readable.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
> index 8c37bcc27132..7604a01be19c 100644
> --- a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
> +++ b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c
> @@ -350,6 +350,7 @@ void fill_iram_v_2(struct iram_table_v_2 *ram_table, struct dmcu_iram_parameters
>         ram_table->bright_pos_gain[4][1] = 0x20;
>         ram_table->bright_pos_gain[4][2] = 0x20;
>         ram_table->bright_pos_gain[4][3] = 0x20;
> +       ram_table->bright_neg_gain[0][0] = 0x00;
>         ram_table->bright_neg_gain[0][1] = 0x00;
>         ram_table->bright_neg_gain[0][2] = 0x00;
>         ram_table->bright_neg_gain[0][3] = 0x00;
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-13 10:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 11:58 [PATCH] drm/amd: add missing fill of the array`s first element Bernard Zhao
2020-06-12 15:27 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).