* linux-next: build warnings after merge of the drm-misc tree
@ 2021-01-15 1:23 Stephen Rothwell
2021-01-15 15:02 ` [PATCH] drm/amdgpu: Remove unused variable Nirmoy Das
2021-01-15 15:03 ` linux-next: build warnings after merge of the drm-misc tree Nirmoy
0 siblings, 2 replies; 4+ messages in thread
From: Stephen Rothwell @ 2021-01-15 1:23 UTC (permalink / raw)
To: Daniel Vetter, Intel Graphics, DRI
Cc: Nirmoy Das, Linux Kernel Mailing List, Linux Next Mailing List,
Thomas Zimmermann, Darren Salt, Christian König
[-- Attachment #1.1: Type: text/plain, Size: 988 bytes --]
Hi all,
After merging the drm-misc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c: In function 'amdgpu_display_user_framebuffer_create':
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:929:24: warning: unused variable 'adev' [-Wunused-variable]
929 | struct amdgpu_device *adev = drm_to_adev(dev);
| ^~~~
Introduced by commit
8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev")
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function 'amdgpu_device_resize_fb_bar':
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1109:6: warning: unused variable 'space_needed' [-Wunused-variable]
1109 | u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
| ^~~~~~~~~~~~
Introduced by commit
453f617a30aa ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
--
Cheers,
Stephen Rothwell
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] drm/amdgpu: Remove unused variable
2021-01-15 1:23 linux-next: build warnings after merge of the drm-misc tree Stephen Rothwell
@ 2021-01-15 15:02 ` Nirmoy Das
2021-01-15 15:08 ` Alex Deucher
2021-01-15 15:03 ` linux-next: build warnings after merge of the drm-misc tree Nirmoy
1 sibling, 1 reply; 4+ messages in thread
From: Nirmoy Das @ 2021-01-15 15:02 UTC (permalink / raw)
To: tzimmermann, Christian.Koenig; +Cc: sfr, Nirmoy Das, dri-devel
Remove unused adev variable
Fixes: 8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index 0150a51b65ef..f764803c53a4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -926,7 +926,6 @@ amdgpu_display_user_framebuffer_create(struct drm_device *dev,
struct drm_file *file_priv,
const struct drm_mode_fb_cmd2 *mode_cmd)
{
- struct amdgpu_device *adev = drm_to_adev(dev);
struct drm_gem_object *obj;
struct amdgpu_framebuffer *amdgpu_fb;
int ret;
--
2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amdgpu: Remove unused variable
2021-01-15 15:02 ` [PATCH] drm/amdgpu: Remove unused variable Nirmoy Das
@ 2021-01-15 15:08 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2021-01-15 15:08 UTC (permalink / raw)
To: Nirmoy Das
Cc: Stephen Rothwell, Maling list - DRI developers, Christian Koenig,
Thomas Zimmermann
On Fri, Jan 15, 2021 at 10:02 AM Nirmoy Das <nirmoy.das@amd.com> wrote:
>
> Remove unused adev variable
>
> Fixes: 8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 0150a51b65ef..f764803c53a4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -926,7 +926,6 @@ amdgpu_display_user_framebuffer_create(struct drm_device *dev,
> struct drm_file *file_priv,
> const struct drm_mode_fb_cmd2 *mode_cmd)
> {
> - struct amdgpu_device *adev = drm_to_adev(dev);
> struct drm_gem_object *obj;
> struct amdgpu_framebuffer *amdgpu_fb;
> int ret;
> --
> 2.29.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build warnings after merge of the drm-misc tree
2021-01-15 1:23 linux-next: build warnings after merge of the drm-misc tree Stephen Rothwell
2021-01-15 15:02 ` [PATCH] drm/amdgpu: Remove unused variable Nirmoy Das
@ 2021-01-15 15:03 ` Nirmoy
1 sibling, 0 replies; 4+ messages in thread
From: Nirmoy @ 2021-01-15 15:03 UTC (permalink / raw)
To: Stephen Rothwell, Daniel Vetter, Intel Graphics, DRI
Cc: Nirmoy Das, Linux Kernel Mailing List, Linux Next Mailing List,
Thomas Zimmermann, Darren Salt, Christian König
Hi Stephen,
On 1/15/21 2:23 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the drm-misc tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c: In function 'amdgpu_display_user_framebuffer_create':
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:929:24: warning: unused variable 'adev' [-Wunused-variable]
> 929 | struct amdgpu_device *adev = drm_to_adev(dev);
> | ^~~~
>
> Introduced by commit
>
> 8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev")
I just sent a patch for this.
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function 'amdgpu_device_resize_fb_bar':
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1109:6: warning: unused variable 'space_needed' [-Wunused-variable]
> 1109 | u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
> | ^~~~~~~~~~~~
>
> Introduced by commit
>
> 453f617a30aa ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
We have a fix already merged in drm-misc-next for this.
Thanks,
Nirmoy
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-15 15:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 1:23 linux-next: build warnings after merge of the drm-misc tree Stephen Rothwell
2021-01-15 15:02 ` [PATCH] drm/amdgpu: Remove unused variable Nirmoy Das
2021-01-15 15:08 ` Alex Deucher
2021-01-15 15:03 ` linux-next: build warnings after merge of the drm-misc tree Nirmoy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).