dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH resend] drm: radeon: fix printk format warnings
@ 2012-10-15 22:59 Randy Dunlap
  2012-10-15 23:10 ` Alex Deucher
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2012-10-15 22:59 UTC (permalink / raw)
  To: LKML, Linus Torvalds; +Cc: Dave Airlie, dri-devel

From: Randy Dunlap <rdunlap@xenotime.net>

Fix printk format warnings in gpu/drm/radeon/:

drivers/gpu/drm/radeon/radeon_atpx_handler.c:151:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
drivers/gpu/drm/radeon/radeon_acpi.c:204:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
drivers/gpu/drm/radeon/radeon_acpi.c:488:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc:	David Airlie <airlied@linux.ie>
Cc:	dri-devel@lists.freedesktop.org
---
Originally posted for linux-next, but now needed in mainline.

 drivers/gpu/drm/radeon/radeon_acpi.c         |    4 ++--
 drivers/gpu/drm/radeon/radeon_atpx_handler.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--- lnx-37-rc1.orig/drivers/gpu/drm/radeon/radeon_atpx_handler.c
+++ lnx-37-rc1/drivers/gpu/drm/radeon/radeon_atpx_handler.c
@@ -148,7 +148,7 @@ static int radeon_atpx_verify_interface(
 
 	size = *(u16 *) info->buffer.pointer;
 	if (size < 8) {
-		printk("ATPX buffer is too small: %lu\n", size);
+		printk("ATPX buffer is too small: %zu\n", size);
 		err = -EINVAL;
 		goto out;
 	}
--- lnx-37-rc1.orig/drivers/gpu/drm/radeon/radeon_acpi.c
+++ lnx-37-rc1/drivers/gpu/drm/radeon/radeon_acpi.c
@@ -201,7 +201,7 @@ static int radeon_atif_verify_interface(
 
 	size = *(u16 *) info->buffer.pointer;
 	if (size < 12) {
-		DRM_INFO("ATIF buffer is too small: %lu\n", size);
+		DRM_INFO("ATIF buffer is too small: %zu\n", size);
 		err = -EINVAL;
 		goto out;
 	}
@@ -485,7 +485,7 @@ static int radeon_atcs_verify_interface(
 
 	size = *(u16 *) info->buffer.pointer;
 	if (size < 8) {
-		DRM_INFO("ATCS buffer is too small: %lu\n", size);
+		DRM_INFO("ATCS buffer is too small: %zu\n", size);
 		err = -EINVAL;
 		goto out;
 	}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH resend] drm: radeon: fix printk format warnings
  2012-10-15 22:59 [PATCH resend] drm: radeon: fix printk format warnings Randy Dunlap
@ 2012-10-15 23:10 ` Alex Deucher
  0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2012-10-15 23:10 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Linus Torvalds, LKML, dri-devel

Already partially fixed in:
http://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-fixes-3.7&id=a1871936c0f4f10850a5671c5deb1a92fcca1155
which is in my radeon -fixes pull request. But Luca's patch missed the
one in radeon_atpx_handler.c.  I can fix that one separately or Dave
can drop Luca's patch and pull in yours instead.

Alex

On Mon, Oct 15, 2012 at 6:59 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix printk format warnings in gpu/drm/radeon/:
>
> drivers/gpu/drm/radeon/radeon_atpx_handler.c:151:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
> drivers/gpu/drm/radeon/radeon_acpi.c:204:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
> drivers/gpu/drm/radeon/radeon_acpi.c:488:3: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc:     David Airlie <airlied@linux.ie>
> Cc:     dri-devel@lists.freedesktop.org
> ---
> Originally posted for linux-next, but now needed in mainline.
>
>  drivers/gpu/drm/radeon/radeon_acpi.c         |    4 ++--
>  drivers/gpu/drm/radeon/radeon_atpx_handler.c |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> --- lnx-37-rc1.orig/drivers/gpu/drm/radeon/radeon_atpx_handler.c
> +++ lnx-37-rc1/drivers/gpu/drm/radeon/radeon_atpx_handler.c
> @@ -148,7 +148,7 @@ static int radeon_atpx_verify_interface(
>
>         size = *(u16 *) info->buffer.pointer;
>         if (size < 8) {
> -               printk("ATPX buffer is too small: %lu\n", size);
> +               printk("ATPX buffer is too small: %zu\n", size);
>                 err = -EINVAL;
>                 goto out;
>         }
> --- lnx-37-rc1.orig/drivers/gpu/drm/radeon/radeon_acpi.c
> +++ lnx-37-rc1/drivers/gpu/drm/radeon/radeon_acpi.c
> @@ -201,7 +201,7 @@ static int radeon_atif_verify_interface(
>
>         size = *(u16 *) info->buffer.pointer;
>         if (size < 12) {
> -               DRM_INFO("ATIF buffer is too small: %lu\n", size);
> +               DRM_INFO("ATIF buffer is too small: %zu\n", size);
>                 err = -EINVAL;
>                 goto out;
>         }
> @@ -485,7 +485,7 @@ static int radeon_atcs_verify_interface(
>
>         size = *(u16 *) info->buffer.pointer;
>         if (size < 8) {
> -               DRM_INFO("ATCS buffer is too small: %lu\n", size);
> +               DRM_INFO("ATCS buffer is too small: %zu\n", size);
>                 err = -EINVAL;
>                 goto out;
>         }
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-15 23:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-15 22:59 [PATCH resend] drm: radeon: fix printk format warnings Randy Dunlap
2012-10-15 23:10 ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).