* [PATCH -next] drm/amd/display: make dcn32_mpc_funcs static
@ 2022-10-19 6:23 ruanjinjie
2022-10-19 13:28 ` Harry Wentland
0 siblings, 1 reply; 3+ messages in thread
From: ruanjinjie @ 2022-10-19 6:23 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, jiapeng.chong,
hanyihao, aurabindo.pillai, Martin.Leung, amd-gfx, dri-devel,
linux-kernel
Cc: ruanjinjie
The symbol is not used outside of the file, so mark it static.
Fixes the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:985:24: warning:
symbol 'dcn32_mpc_funcs' was not declared. Should it be static?
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
index 4edd0655965b..206a5ddbaf6d 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
@@ -982,7 +982,7 @@ static bool mpc32_program_3dlut(
return true;
}
-const struct mpc_funcs dcn32_mpc_funcs = {
+static const struct mpc_funcs dcn32_mpc_funcs = {
.read_mpcc_state = mpc1_read_mpcc_state,
.insert_plane = mpc1_insert_plane,
.remove_mpcc = mpc1_remove_mpcc,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/amd/display: make dcn32_mpc_funcs static
2022-10-19 6:23 [PATCH -next] drm/amd/display: make dcn32_mpc_funcs static ruanjinjie
@ 2022-10-19 13:28 ` Harry Wentland
2022-10-20 13:12 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Harry Wentland @ 2022-10-19 13:28 UTC (permalink / raw)
To: ruanjinjie, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, jiapeng.chong,
hanyihao, aurabindo.pillai, Martin.Leung, amd-gfx, dri-devel,
linux-kernel
On 2022-10-19 02:23, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:985:24: warning:
> symbol 'dcn32_mpc_funcs' was not declared. Should it be static?
>
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> index 4edd0655965b..206a5ddbaf6d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> @@ -982,7 +982,7 @@ static bool mpc32_program_3dlut(
> return true;
> }
>
> -const struct mpc_funcs dcn32_mpc_funcs = {
> +static const struct mpc_funcs dcn32_mpc_funcs = {
> .read_mpcc_state = mpc1_read_mpcc_state,
> .insert_plane = mpc1_insert_plane,
> .remove_mpcc = mpc1_remove_mpcc,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/amd/display: make dcn32_mpc_funcs static
2022-10-19 13:28 ` Harry Wentland
@ 2022-10-20 13:12 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2022-10-20 13:12 UTC (permalink / raw)
To: Harry Wentland
Cc: jiapeng.chong, hanyihao, sunpeng.li, ruanjinjie, Xinhui.Pan,
Rodrigo.Siqueira, linux-kernel, amd-gfx, aurabindo.pillai,
dri-devel, Martin.Leung, alexander.deucher, christian.koenig
Applied. Thanks!
Alex
On Wed, Oct 19, 2022 at 9:28 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2022-10-19 02:23, ruanjinjie wrote:
> > The symbol is not used outside of the file, so mark it static.
> >
> > Fixes the following warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:985:24: warning:
> > symbol 'dcn32_mpc_funcs' was not declared. Should it be static?
> >
> > Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> > index 4edd0655965b..206a5ddbaf6d 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
> > @@ -982,7 +982,7 @@ static bool mpc32_program_3dlut(
> > return true;
> > }
> >
> > -const struct mpc_funcs dcn32_mpc_funcs = {
> > +static const struct mpc_funcs dcn32_mpc_funcs = {
> > .read_mpcc_state = mpc1_read_mpcc_state,
> > .insert_plane = mpc1_insert_plane,
> > .remove_mpcc = mpc1_remove_mpcc,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-20 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-19 6:23 [PATCH -next] drm/amd/display: make dcn32_mpc_funcs static ruanjinjie
2022-10-19 13:28 ` Harry Wentland
2022-10-20 13:12 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).