* [PATCH] drm/radeon/kms/atom: Remove redundant code
@ 2023-09-28 9:45 Jiapeng Chong
2023-09-28 15:49 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2023-09-28 9:45 UTC (permalink / raw)
To: alexander.deucher
Cc: Jiapeng Chong, Xinhui.Pan, Abaci Robot, linux-kernel, amd-gfx,
dri-devel, christian.koenig
drivers/gpu/drm/radeon/atom.c:396 atom_skip_src_int() warn: ignoring unreachable code.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6713
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/radeon/atom.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c
index ceb6d772ef94..3082d08a06c2 100644
--- a/drivers/gpu/drm/radeon/atom.c
+++ b/drivers/gpu/drm/radeon/atom.c
@@ -393,7 +393,6 @@ static void atom_skip_src_int(atom_exec_context *ctx, uint8_t attr, int *ptr)
(*ptr)++;
return;
}
- return;
}
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/radeon/kms/atom: Remove redundant code
2023-09-28 9:45 [PATCH] drm/radeon/kms/atom: Remove redundant code Jiapeng Chong
@ 2023-09-28 15:49 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2023-09-28 15:49 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Xinhui.Pan, Abaci Robot, linux-kernel, dri-devel, amd-gfx,
alexander.deucher, christian.koenig
On Thu, Sep 28, 2023 at 5:46 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> drivers/gpu/drm/radeon/atom.c:396 atom_skip_src_int() warn: ignoring unreachable code.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6713
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/radeon/atom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c
> index ceb6d772ef94..3082d08a06c2 100644
> --- a/drivers/gpu/drm/radeon/atom.c
> +++ b/drivers/gpu/drm/radeon/atom.c
> @@ -393,7 +393,6 @@ static void atom_skip_src_int(atom_exec_context *ctx, uint8_t attr, int *ptr)
> (*ptr)++;
> return;
> }
> - return;
I think this should be a break.
Alex
> }
> }
>
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-28 15:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-28 9:45 [PATCH] drm/radeon/kms/atom: Remove redundant code Jiapeng Chong
2023-09-28 15:49 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).