* [PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning
@ 2023-03-07 17:46 Randy Dunlap
2023-03-07 18:47 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2023-03-07 17:46 UTC (permalink / raw)
To: linux-kernel
Cc: Rob Clark, kernel test robot, Paul Gazzillo,
Necip Fazil Yildiran, Randy Dunlap, Abhinav Kumar, dri-devel,
linux-arm-msm, Dmitry Baryshkov, freedreno
Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter
should either be selected or DRM_MSM should depend on PM_DEVFREQ.
Since most drivers select PM_DEVFREQ instead of depending on it,
add a select here to satisfy kconfig.
WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND
Depends on [n]: PM_DEVFREQ [=n]
Selected by [y]:
- DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=n] || QCOM_LLCC [=n]=n) && (QCOM_COMMAND_DB [=y] || QCOM_COMMAND_DB [=y]=n)
Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: lore.kernel.org/r/202303071922.wJqDWQpe-lkp@intel.com
Cc: Rob Clark <robdclark@chromium.org>
Cc: Paul Gazzillo <paul@pgazz.com>
Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: Chia-I Wu <olvaffe@gmail.com>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
---
drivers/gpu/drm/msm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -23,6 +23,7 @@ config DRM_MSM
select SHMEM
select TMPFS
select QCOM_SCM
+ select PM_DEVFREQ
select DEVFREQ_GOV_SIMPLE_ONDEMAND
select WANT_DEV_COREDUMP
select SND_SOC_HDMI_CODEC if SND_SOC
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning
2023-03-07 17:46 [PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning Randy Dunlap
@ 2023-03-07 18:47 ` Fabio Estevam
2023-03-07 19:21 ` [Freedreno] " Rob Clark
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2023-03-07 18:47 UTC (permalink / raw)
To: Randy Dunlap
Cc: Rob Clark, kernel test robot, Paul Gazzillo,
Necip Fazil Yildiran, linux-kernel, dri-devel, Abhinav Kumar,
linux-arm-msm, Dmitry Baryshkov, freedreno
On Tue, Mar 7, 2023 at 2:46 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter
> should either be selected or DRM_MSM should depend on PM_DEVFREQ.
> Since most drivers select PM_DEVFREQ instead of depending on it,
> add a select here to satisfy kconfig.
>
> WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND
> Depends on [n]: PM_DEVFREQ [=n]
> Selected by [y]:
> - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=n] || QCOM_LLCC [=n]=n) && (QCOM_COMMAND_DB [=y] || QCOM_COMMAND_DB [=y]=n)
>
> Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: lore.kernel.org/r/202303071922.wJqDWQpe-lkp@intel.com
> Cc: Rob Clark <robdclark@chromium.org>
> Cc: Paul Gazzillo <paul@pgazz.com>
> Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> Cc: Chia-I Wu <olvaffe@gmail.com>
> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: freedreno@lists.freedesktop.org
This fixes the warning after running 'make imx_v6_v7_defconfig', thanks:
Tested-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Freedreno] [PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning
2023-03-07 18:47 ` Fabio Estevam
@ 2023-03-07 19:21 ` Rob Clark
0 siblings, 0 replies; 3+ messages in thread
From: Rob Clark @ 2023-03-07 19:21 UTC (permalink / raw)
To: Fabio Estevam
Cc: Rob Clark, kernel test robot, Paul Gazzillo,
Necip Fazil Yildiran, Randy Dunlap, linux-kernel, dri-devel,
Abhinav Kumar, linux-arm-msm, Dmitry Baryshkov, freedreno
On Tue, Mar 7, 2023 at 10:48 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Tue, Mar 7, 2023 at 2:46 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > Since DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, the latter
> > should either be selected or DRM_MSM should depend on PM_DEVFREQ.
> > Since most drivers select PM_DEVFREQ instead of depending on it,
> > add a select here to satisfy kconfig.
> >
> > WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND
> > Depends on [n]: PM_DEVFREQ [=n]
> > Selected by [y]:
> > - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=n] || QCOM_LLCC [=n]=n) && (QCOM_COMMAND_DB [=y] || QCOM_COMMAND_DB [=y]=n)
> >
> > Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Link: lore.kernel.org/r/202303071922.wJqDWQpe-lkp@intel.com
> > Cc: Rob Clark <robdclark@chromium.org>
> > Cc: Paul Gazzillo <paul@pgazz.com>
> > Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> > Cc: Chia-I Wu <olvaffe@gmail.com>
> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Cc: linux-arm-msm@vger.kernel.org
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: freedreno@lists.freedesktop.org
>
> This fixes the warning after running 'make imx_v6_v7_defconfig', thanks:
>
> Tested-by: Fabio Estevam <festevam@gmail.com>
https://patchwork.freedesktop.org/patch/523353 is the fix we actually
want.. I thought I'd already pulled that into msm-fixes but it seems
like it got lost somewhere.. I'll rectify that
BR,
-R
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-07 19:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 17:46 [PATCH] drm/msm: fix PM_DEVFREQ kconfig dependency warning Randy Dunlap
2023-03-07 18:47 ` Fabio Estevam
2023-03-07 19:21 ` [Freedreno] " Rob Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).