From: Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Harigovindan P <harigovi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-arm-msm <linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, dri-devel <dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Abhinav Kumar <abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, "Kristian H. Kristensen" <hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, freedreno <freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>, Jeykumar Sankaran <jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, Chandan Uddaraju <chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Subject: Re: [PATCH v1 2/2] drm/msm: add DSI config changes to support DSI version Date: Thu, 14 Nov 2019 09:47:02 -0800 [thread overview] Message-ID: <CAF6AEGurmTxwhBeWf1Q2U7_jSwmofBq49G5dsZN0qRmAFfvDNQ@mail.gmail.com> (raw) In-Reply-To: <1573726588-18897-3-git-send-email-harigovi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> On Thu, Nov 14, 2019 at 2:16 AM Harigovindan P <harigovi@codeaurora.org> wrote: > > Add DSI config changes to support DSI version. > > Signed-off-by: Harigovindan P <harigovi@codeaurora.org> Reviewed-by: Rob Clark <robdclark@gmail.com> For patch 1/2 with the panel driver, probably best to split that out into a different patch(set), since panel drivers are merged into drm-next via a different tree BR, -R > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 21 +++++++++++++++++++++ > drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + > 2 files changed, 22 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index b7b7c1a..d2c4592 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -133,6 +133,10 @@ static const char * const dsi_sdm845_bus_clk_names[] = { > "iface", "bus", > }; > > +static const char * const dsi_sc7180_bus_clk_names[] = { > + "iface", "bus", > +}; > + > static const struct msm_dsi_config sdm845_dsi_cfg = { > .io_offset = DSI_6G_REG_SHIFT, > .reg_cfg = { > @@ -147,6 +151,20 @@ static const struct msm_dsi_config sdm845_dsi_cfg = { > .num_dsi = 2, > }; > > +static const struct msm_dsi_config sc7180_dsi_cfg = { > + .io_offset = DSI_6G_REG_SHIFT, > + .reg_cfg = { > + .num = 1, > + .regs = { > + {"vdda", 21800, 4 }, /* 1.2 V */ > + }, > + }, > + .bus_clk_names = dsi_sc7180_bus_clk_names, > + .num_bus_clks = ARRAY_SIZE(dsi_sc7180_bus_clk_names), > + .io_start = { 0xae94000 }, > + .num_dsi = 1, > +}; > + > const static struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops = { > .link_clk_enable = dsi_link_clk_enable_v2, > .link_clk_disable = dsi_link_clk_disable_v2, > @@ -201,6 +219,9 @@ static const struct msm_dsi_cfg_handler dsi_cfg_handlers[] = { > &msm8998_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_2_1, > &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > + {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_1, > + &sc7180_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > + > }; > > const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 major, u32 minor) > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h > index e2b7a7d..9919536 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h > @@ -19,6 +19,7 @@ > #define MSM_DSI_6G_VER_MINOR_V1_4_1 0x10040001 > #define MSM_DSI_6G_VER_MINOR_V2_2_0 0x20000000 > #define MSM_DSI_6G_VER_MINOR_V2_2_1 0x20020001 > +#define MSM_DSI_6G_VER_MINOR_V2_4_1 0x20040001 > > #define MSM_DSI_V2_VER_MINOR_8064 0x0 > > -- > 2.7.4 > _______________________________________________ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno
WARNING: multiple messages have this Message-ID (diff)
From: Rob Clark <robdclark@gmail.com> To: Harigovindan P <harigovi@codeaurora.org> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Sean Paul <seanpaul@chromium.org>, Abhinav Kumar <abhinavk@codeaurora.org>, "Kristian H. Kristensen" <hoegsberg@chromium.org>, freedreno <freedreno@lists.freedesktop.org>, Chandan Uddaraju <chandanu@codeaurora.org> Subject: Re: [PATCH v1 2/2] drm/msm: add DSI config changes to support DSI version Date: Thu, 14 Nov 2019 09:47:02 -0800 [thread overview] Message-ID: <CAF6AEGurmTxwhBeWf1Q2U7_jSwmofBq49G5dsZN0qRmAFfvDNQ@mail.gmail.com> (raw) Message-ID: <20191114174702.HZIIrsT9Oc63c_mBINI1QIM5obF0BI1w6s_yXclqOZg@z> (raw) In-Reply-To: <1573726588-18897-3-git-send-email-harigovi@codeaurora.org> On Thu, Nov 14, 2019 at 2:16 AM Harigovindan P <harigovi@codeaurora.org> wrote: > > Add DSI config changes to support DSI version. > > Signed-off-by: Harigovindan P <harigovi@codeaurora.org> Reviewed-by: Rob Clark <robdclark@gmail.com> For patch 1/2 with the panel driver, probably best to split that out into a different patch(set), since panel drivers are merged into drm-next via a different tree BR, -R > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 21 +++++++++++++++++++++ > drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + > 2 files changed, 22 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index b7b7c1a..d2c4592 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -133,6 +133,10 @@ static const char * const dsi_sdm845_bus_clk_names[] = { > "iface", "bus", > }; > > +static const char * const dsi_sc7180_bus_clk_names[] = { > + "iface", "bus", > +}; > + > static const struct msm_dsi_config sdm845_dsi_cfg = { > .io_offset = DSI_6G_REG_SHIFT, > .reg_cfg = { > @@ -147,6 +151,20 @@ static const struct msm_dsi_config sdm845_dsi_cfg = { > .num_dsi = 2, > }; > > +static const struct msm_dsi_config sc7180_dsi_cfg = { > + .io_offset = DSI_6G_REG_SHIFT, > + .reg_cfg = { > + .num = 1, > + .regs = { > + {"vdda", 21800, 4 }, /* 1.2 V */ > + }, > + }, > + .bus_clk_names = dsi_sc7180_bus_clk_names, > + .num_bus_clks = ARRAY_SIZE(dsi_sc7180_bus_clk_names), > + .io_start = { 0xae94000 }, > + .num_dsi = 1, > +}; > + > const static struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops = { > .link_clk_enable = dsi_link_clk_enable_v2, > .link_clk_disable = dsi_link_clk_disable_v2, > @@ -201,6 +219,9 @@ static const struct msm_dsi_cfg_handler dsi_cfg_handlers[] = { > &msm8998_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_2_1, > &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > + {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_1, > + &sc7180_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > + > }; > > const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 major, u32 minor) > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h > index e2b7a7d..9919536 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h > @@ -19,6 +19,7 @@ > #define MSM_DSI_6G_VER_MINOR_V1_4_1 0x10040001 > #define MSM_DSI_6G_VER_MINOR_V2_2_0 0x20000000 > #define MSM_DSI_6G_VER_MINOR_V2_2_1 0x20020001 > +#define MSM_DSI_6G_VER_MINOR_V2_4_1 0x20040001 > > #define MSM_DSI_V2_VER_MINOR_8064 0x0 > > -- > 2.7.4 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-14 17:47 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-14 10:16 [PATCH v1 0/2] Add suppport for rm69299 Visionox panel driver and add DSI config to support DSI version Harigovindan P 2019-11-14 10:16 ` Harigovindan P 2019-11-14 10:16 ` [PATCH v1 1/2] drm/panel: add support for rm69299 visionox panel driver Harigovindan P 2019-11-14 10:16 ` Harigovindan P 2019-11-14 17:15 ` Stephen Boyd 2019-11-14 17:15 ` Stephen Boyd [not found] ` <1573726588-18897-2-git-send-email-harigovi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2019-11-14 18:12 ` Rob Clark 2019-11-14 18:12 ` Rob Clark 2019-11-14 10:16 ` [PATCH v1 2/2] drm/msm: add DSI config changes to support DSI version Harigovindan P 2019-11-14 10:16 ` Harigovindan P [not found] ` <1573726588-18897-3-git-send-email-harigovi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2019-11-14 17:47 ` Rob Clark [this message] 2019-11-14 17:47 ` Rob Clark 2019-11-14 17:56 ` [Freedreno] " Jeffrey Hugo 2019-11-14 17:56 ` Jeffrey Hugo 2019-11-14 17:15 ` [PATCH v1 0/2] Add suppport for rm69299 Visionox panel driver and add DSI config " Stephen Boyd 2019-11-14 17:15 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAF6AEGurmTxwhBeWf1Q2U7_jSwmofBq49G5dsZN0qRmAFfvDNQ@mail.gmail.com \ --to=robdclark-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=chandanu-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=harigovi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=hoegsberg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ --cc=jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=nganji-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).