* [PATCH] drm/msm: always parse interconnects
@ 2021-04-17 16:21 Caleb Connolly
2021-04-17 17:52 ` Rob Clark
0 siblings, 1 reply; 2+ messages in thread
From: Caleb Connolly @ 2021-04-17 16:21 UTC (permalink / raw)
To: caleb, Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Kalyan Thota
Cc: Rob Clark, linux-arm-msm, linux-kernel, dri-devel,
~postmarketos/upstreaming, freedreno
The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180
platforms. As SDM845 now has interconnects hooked up we should always
try and parse them.
Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume")
Signed-off-by: Caleb Connolly <caleb@connolly.tech>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 85f2c3564c96..fb061e666faa 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -933,8 +933,7 @@ static int dpu_kms_hw_init(struct msm_kms *kms)
DPU_DEBUG("REG_DMA is not defined");
}
- if (of_device_is_compatible(dev->dev->of_node, "qcom,sc7180-mdss"))
- dpu_kms_parse_data_bus_icc_path(dpu_kms);
+ dpu_kms_parse_data_bus_icc_path(dpu_kms);
pm_runtime_get_sync(&dpu_kms->pdev->dev);
--
2.30.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/msm: always parse interconnects
2021-04-17 16:21 [PATCH] drm/msm: always parse interconnects Caleb Connolly
@ 2021-04-17 17:52 ` Rob Clark
0 siblings, 0 replies; 2+ messages in thread
From: Rob Clark @ 2021-04-17 17:52 UTC (permalink / raw)
To: Caleb Connolly
Cc: Rob Clark, freedreno, David Airlie, linux-arm-msm,
Linux Kernel Mailing List, dri-devel, ~postmarketos/upstreaming,
Sean Paul, Kalyan Thota
On Sat, Apr 17, 2021 at 9:21 AM Caleb Connolly <caleb@connolly.tech> wrote:
>
> The WARN_ON in dpu_runtime_resume() fires constantly on non-SC7180
> platforms. As SDM845 now has interconnects hooked up we should always
> try and parse them.
>
> Fixes: 627dc55c273d ("drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume")
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
I believe this series in msm-next already solves this
https://patchwork.freedesktop.org/series/88644/
BR,
-R
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 85f2c3564c96..fb061e666faa 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -933,8 +933,7 @@ static int dpu_kms_hw_init(struct msm_kms *kms)
> DPU_DEBUG("REG_DMA is not defined");
> }
>
> - if (of_device_is_compatible(dev->dev->of_node, "qcom,sc7180-mdss"))
> - dpu_kms_parse_data_bus_icc_path(dpu_kms);
> + dpu_kms_parse_data_bus_icc_path(dpu_kms);
>
> pm_runtime_get_sync(&dpu_kms->pdev->dev);
>
> --
> 2.30.2
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-17 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-17 16:21 [PATCH] drm/msm: always parse interconnects Caleb Connolly
2021-04-17 17:52 ` Rob Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).