* [PATCH] drm/bridge: tc358775: Do not soft reset i2c-slave controller
@ 2022-09-01 13:19 Teresa Remmet
2022-10-04 18:08 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Teresa Remmet @ 2022-09-01 13:19 UTC (permalink / raw)
To: dri-devel
Cc: Jonas Karlman, Robert Foss, Neil Armstrong, Jernej Skrabec,
Laurent Pinchart, Andrzej Hajda, upstream
Soft reset during tc_bridge_enable() is triggered by setting all available
reset control bits in the SYSRST register.
But as noted in the data sheet resetting the i2c-slave controller should
be only done over DSI and is only useful for chip debugging.
So do not set RSTI2CS (bit0).
Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
---
drivers/gpu/drm/bridge/tc358775.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
index f1c6e62b0e1d..a5f5eae1e80f 100644
--- a/drivers/gpu/drm/bridge/tc358775.c
+++ b/drivers/gpu/drm/bridge/tc358775.c
@@ -408,7 +408,7 @@ static void tc_bridge_enable(struct drm_bridge *bridge)
(val >> 8) & 0xFF, val & 0xFF);
d2l_write(tc->i2c, SYSRST, SYS_RST_REG | SYS_RST_DSIRX | SYS_RST_BM |
- SYS_RST_LCD | SYS_RST_I2CM | SYS_RST_I2CS);
+ SYS_RST_LCD | SYS_RST_I2CM);
usleep_range(30000, 40000);
d2l_write(tc->i2c, PPI_TX_RX_TA, TTA_GET | TTA_SURE);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: tc358775: Do not soft reset i2c-slave controller
2022-09-01 13:19 [PATCH] drm/bridge: tc358775: Do not soft reset i2c-slave controller Teresa Remmet
@ 2022-10-04 18:08 ` Robert Foss
2022-10-10 12:38 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Robert Foss @ 2022-10-04 18:08 UTC (permalink / raw)
To: Teresa Remmet
Cc: Jonas Karlman, dri-devel, Neil Armstrong, Jernej Skrabec,
Laurent Pinchart, Andrzej Hajda, upstream
On Thu, 1 Sept 2022 at 15:20, Teresa Remmet <t.remmet@phytec.de> wrote:
>
> Soft reset during tc_bridge_enable() is triggered by setting all available
> reset control bits in the SYSRST register.
> But as noted in the data sheet resetting the i2c-slave controller should
> be only done over DSI and is only useful for chip debugging.
> So do not set RSTI2CS (bit0).
>
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
> drivers/gpu/drm/bridge/tc358775.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c
> index f1c6e62b0e1d..a5f5eae1e80f 100644
> --- a/drivers/gpu/drm/bridge/tc358775.c
> +++ b/drivers/gpu/drm/bridge/tc358775.c
> @@ -408,7 +408,7 @@ static void tc_bridge_enable(struct drm_bridge *bridge)
> (val >> 8) & 0xFF, val & 0xFF);
>
> d2l_write(tc->i2c, SYSRST, SYS_RST_REG | SYS_RST_DSIRX | SYS_RST_BM |
> - SYS_RST_LCD | SYS_RST_I2CM | SYS_RST_I2CS);
> + SYS_RST_LCD | SYS_RST_I2CM);
> usleep_range(30000, 40000);
>
> d2l_write(tc->i2c, PPI_TX_RX_TA, TTA_GET | TTA_SURE);
> --
> 2.25.1
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Waiting a few days before applying this patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: tc358775: Do not soft reset i2c-slave controller
2022-10-04 18:08 ` Robert Foss
@ 2022-10-10 12:38 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2022-10-10 12:38 UTC (permalink / raw)
To: Teresa Remmet
Cc: Jonas Karlman, dri-devel, Neil Armstrong, Jernej Skrabec,
Laurent Pinchart, Andrzej Hajda, upstream
Applied to drm-misc-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-10 12:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 13:19 [PATCH] drm/bridge: tc358775: Do not soft reset i2c-slave controller Teresa Remmet
2022-10-04 18:08 ` Robert Foss
2022-10-10 12:38 ` Robert Foss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).