From: Arnd Bergmann <arnd@kernel.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: David Airlie <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Emil Velikov <emil.velikov@collabora.com>,
Wambui Karuga <wambui.karugax@gmail.com>
Subject: Re: [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure
Date: Tue, 27 Oct 2020 17:47:25 +0100 [thread overview]
Message-ID: <CAK8P3a2Ha+SEmdP9bd-HKN_AwAo9LAfW5LWTkODFOCAUd69QnQ@mail.gmail.com> (raw)
In-Reply-To: <19af29c5-91e7-055f-cffa-0c813ed5233b@ti.com>
On Tue, Oct 27, 2020 at 4:31 PM Jyri Sarha <jsarha@ti.com> wrote:
> On 26/10/2020 21:41, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The -Wmissing-field-initializer warning when building with W=2
> > turns into an error because tilcdc is built with -Werror:
> >
> > drm/tilcdc/tilcdc_drv.c:431:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "regs", tilcdc_regs_show, 0 },
> > drm/tilcdc/tilcdc_drv.c:432:33: error: missing field 'data' initializer [-Werror,-Wmissing-field-initializers] { "mm", tilcdc_mm_show, 0 },
> >
> > Add the missing field initializers to address the warning.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Jyri Sarha <jsarha@ti.com>
Thanks
> Please let me know if you want me to merge this.
Yes, it would be good if you can merge it directly.
Arnd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-10-27 16:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 19:41 [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure Arnd Bergmann
2020-10-26 19:41 ` [PATCH 2/4] drm/imx: tve remove extraneous type qualifier Arnd Bergmann
2020-10-26 19:44 ` Nick Desaulniers
2020-10-27 14:56 ` Philipp Zabel
2020-10-26 19:41 ` [PATCH 3/4] drm/msm: fix -Woverride-init warning Arnd Bergmann
2020-10-26 20:52 ` [Freedreno] " abhinavk
2020-10-26 20:56 ` Stephen Boyd
2020-10-26 19:41 ` [PATCH 4/4] drm/gma500: avoid Woverride-init warning Arnd Bergmann
2020-10-27 9:33 ` Daniel Vetter
2020-10-27 9:54 ` Patrik Jakobsson
2020-10-27 16:49 ` Arnd Bergmann
2020-10-28 14:41 ` Patrik Jakobsson
2020-10-27 15:31 ` [PATCH 1/4] drm/tilcdc: avoid 'make W=2' build failure Jyri Sarha
2020-10-27 16:47 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2Ha+SEmdP9bd-HKN_AwAo9LAfW5LWTkODFOCAUd69QnQ@mail.gmail.com \
--to=arnd@kernel.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tzimmermann@suse.de \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).