From: Qiang Yu <yuq825@gmail.com>
To: Erico Nunes <nunes.erico@gmail.com>
Cc: lima@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Andreas Baierl <ichgeh@imkreisrum.de>
Subject: Re: [PATCH] drm/lima: fix wait pp reset timeout
Date: Mon, 20 Jul 2020 09:00:29 +0800 [thread overview]
Message-ID: <CAKGbVbvm-P7EX9RmCxowyNjwP8K2S+OUQJ3m9uPZdemUt=g_PA@mail.gmail.com> (raw)
In-Reply-To: <CAK4VdL3dDBUK_jpb8Q08XBpKdmFF9MomMnb4mKJr1wotfnzppA@mail.gmail.com>
Thanks, applied to drm-misc-fixes.
Regards,
Qiang
On Sun, Jul 19, 2020 at 6:41 PM Erico Nunes <nunes.erico@gmail.com> wrote:
>
> On Sun, Jul 19, 2020 at 9:31 AM Qiang Yu <yuq825@gmail.com> wrote:
> >
> > PP bcast is marked as doing async reset after job is done.
> > When resume after suspend, each PP is reset individually,
> > so no need to reset in PP bcast resume. But I forgot to
> > clear the PP bcast async reset mark so call into async wait
> > before job run and gets timeout.
> >
> > Fixes: 3446d7e9883d ("drm/lima: add resume/suspend callback for each ip")
> > Signed-off-by: Qiang Yu <yuq825@gmail.com>
> > ---
> > drivers/gpu/drm/lima/lima_pp.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/lima/lima_pp.c b/drivers/gpu/drm/lima/lima_pp.c
> > index 33f01383409c..a5c95bed08c0 100644
> > --- a/drivers/gpu/drm/lima/lima_pp.c
> > +++ b/drivers/gpu/drm/lima/lima_pp.c
> > @@ -271,6 +271,8 @@ void lima_pp_fini(struct lima_ip *ip)
> >
> > int lima_pp_bcast_resume(struct lima_ip *ip)
> > {
> > + /* PP has been reset by individual PP resume */
> > + ip->data.async_reset = false;
> > return 0;
> > }
> >
> > --
>
> Reviewed-by: Erico Nunes <nunes.erico@gmail.com>
>
> This fixes the issue reported at
> https://gitlab.freedesktop.org/lima/linux/-/issues/34 .
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-07-20 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 7:30 [PATCH] drm/lima: fix wait pp reset timeout Qiang Yu
2020-07-19 10:41 ` Erico Nunes
2020-07-20 1:00 ` Qiang Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKGbVbvm-P7EX9RmCxowyNjwP8K2S+OUQJ3m9uPZdemUt=g_PA@mail.gmail.com' \
--to=yuq825@gmail.com \
--cc=airlied@linux.ie \
--cc=anarsoul@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ichgeh@imkreisrum.de \
--cc=lima@lists.freedesktop.org \
--cc=nunes.erico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).