* [PATCH] drm/vmwgfx: Fix Legacy Display Unit
@ 2024-04-25 20:07 Ian Forbes
2024-04-26 0:26 ` Zack Rusin
2024-04-26 8:19 ` Martin Krastev
0 siblings, 2 replies; 3+ messages in thread
From: Ian Forbes @ 2024-04-25 20:07 UTC (permalink / raw)
To: dri-devel
Cc: bcm-kernel-feedback-list, zack.rusin, martin.krastev,
maaz.mombasawala, Ian Forbes, stable
Legacy DU was broken by the referenced fixes commit because the placement
and the busy_placement no longer pointed to the same object. This was later
fixed indirectly by commit a78a8da51b36c7a0c0c16233f91d60aac03a5a49
("drm/ttm: replace busy placement with flags v6") in v6.9.
Fixes: 39985eea5a6d ("drm/vmwgfx: Abstract placement selection")
Signed-off-by: Ian Forbes <ian.forbes@broadcom.com>
Cc: <stable@vger.kernel.org> # v6.4+
---
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
index 2bfac3aad7b7..98e73eb0ccf1 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
@@ -204,6 +204,7 @@ int vmw_bo_pin_in_start_of_vram(struct vmw_private *dev_priv,
VMW_BO_DOMAIN_VRAM,
VMW_BO_DOMAIN_VRAM);
buf->places[0].lpfn = PFN_UP(bo->resource->size);
+ buf->busy_places[0].lpfn = PFN_UP(bo->resource->size);
ret = ttm_bo_validate(bo, &buf->placement, &ctx);
/* For some reason we didn't end up at the start of vram */
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vmwgfx: Fix Legacy Display Unit
2024-04-25 20:07 [PATCH] drm/vmwgfx: Fix Legacy Display Unit Ian Forbes
@ 2024-04-26 0:26 ` Zack Rusin
2024-04-26 8:19 ` Martin Krastev
1 sibling, 0 replies; 3+ messages in thread
From: Zack Rusin @ 2024-04-26 0:26 UTC (permalink / raw)
To: Ian Forbes
Cc: dri-devel, bcm-kernel-feedback-list, martin.krastev,
maaz.mombasawala, stable
On Thu, Apr 25, 2024 at 4:07 PM Ian Forbes <ian.forbes@broadcom.com> wrote:
>
> Legacy DU was broken by the referenced fixes commit because the placement
> and the busy_placement no longer pointed to the same object. This was later
> fixed indirectly by commit a78a8da51b36c7a0c0c16233f91d60aac03a5a49
> ("drm/ttm: replace busy placement with flags v6") in v6.9.
>
> Fixes: 39985eea5a6d ("drm/vmwgfx: Abstract placement selection")
> Signed-off-by: Ian Forbes <ian.forbes@broadcom.com>
> Cc: <stable@vger.kernel.org> # v6.4+
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
> index 2bfac3aad7b7..98e73eb0ccf1 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
> @@ -204,6 +204,7 @@ int vmw_bo_pin_in_start_of_vram(struct vmw_private *dev_priv,
> VMW_BO_DOMAIN_VRAM,
> VMW_BO_DOMAIN_VRAM);
> buf->places[0].lpfn = PFN_UP(bo->resource->size);
> + buf->busy_places[0].lpfn = PFN_UP(bo->resource->size);
> ret = ttm_bo_validate(bo, &buf->placement, &ctx);
>
> /* For some reason we didn't end up at the start of vram */
Looks great. I'll push it through drm-misc-fixes.
Reviewed-by: Zack Rusin <zack.rusin@broadcom.com>
z
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vmwgfx: Fix Legacy Display Unit
2024-04-25 20:07 [PATCH] drm/vmwgfx: Fix Legacy Display Unit Ian Forbes
2024-04-26 0:26 ` Zack Rusin
@ 2024-04-26 8:19 ` Martin Krastev
1 sibling, 0 replies; 3+ messages in thread
From: Martin Krastev @ 2024-04-26 8:19 UTC (permalink / raw)
To: Ian Forbes
Cc: dri-devel, bcm-kernel-feedback-list, zack.rusin,
maaz.mombasawala, stable
Good catch!
Reviewed-by: Martin Krastev <martin.krastev@broadcom.com>
Regards,
Martin
On Thu, Apr 25, 2024 at 11:07 PM Ian Forbes <ian.forbes@broadcom.com> wrote:
>
> Legacy DU was broken by the referenced fixes commit because the placement
> and the busy_placement no longer pointed to the same object. This was later
> fixed indirectly by commit a78a8da51b36c7a0c0c16233f91d60aac03a5a49
> ("drm/ttm: replace busy placement with flags v6") in v6.9.
>
> Fixes: 39985eea5a6d ("drm/vmwgfx: Abstract placement selection")
> Signed-off-by: Ian Forbes <ian.forbes@broadcom.com>
> Cc: <stable@vger.kernel.org> # v6.4+
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
> index 2bfac3aad7b7..98e73eb0ccf1 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
> @@ -204,6 +204,7 @@ int vmw_bo_pin_in_start_of_vram(struct vmw_private *dev_priv,
> VMW_BO_DOMAIN_VRAM,
> VMW_BO_DOMAIN_VRAM);
> buf->places[0].lpfn = PFN_UP(bo->resource->size);
> + buf->busy_places[0].lpfn = PFN_UP(bo->resource->size);
> ret = ttm_bo_validate(bo, &buf->placement, &ctx);
>
> /* For some reason we didn't end up at the start of vram */
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-26 8:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 20:07 [PATCH] drm/vmwgfx: Fix Legacy Display Unit Ian Forbes
2024-04-26 0:26 ` Zack Rusin
2024-04-26 8:19 ` Martin Krastev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).