From: Art Nikpal <email2tema@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Gouwa Wang <gouwa@khadas.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Christian Hewitt <christianshewitt@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-spi@vger.kernel.org, nick@khadas.com,
linux-amlogic@lists.infradead.org, Artem Lapkin <art@khadas.com>,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH] SPI: meson-spifc add missed calls to remove function
Date: Fri, 30 Apr 2021 16:49:35 +0800 [thread overview]
Message-ID: <CAKaHn9JM-KEiz3_Btsz8_fr7hcZ2Sm8B64VyLvgpvKK-NKco3w@mail.gmail.com> (raw)
In-Reply-To: <20210426115645.GB4590@sirena.org.uk>
Yep! but
if i try call spi_master_put(master) or spi_unregister_controller(master);
it's made Segmentation fault for me
what's wrong - may be somebody can help me
On Mon, Apr 26, 2021 at 7:57 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Sat, Apr 24, 2021 at 07:57:19AM +0800, Art Nikpal wrote:
>
> > > I would expect the driver to unregister the controller at the start of
> > > the remove function, suspend doesn't really make sense here
>
> > It's strange - But without spi_master_suspend i have randomly stucks when i
> > try unload this module - as was written before
> > i was test it (load/unload module in loop) and for me suspend make sense
> > here
>
> > If anybody has another solution - or real problem not here - please write
> > to me the right way!
>
> As I said above unregister the controller at the start of the remove
> function.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-04-30 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 3:42 [PATCH] SPI: meson-spifc add missed calls to remove function Artem Lapkin
2021-04-23 11:47 ` Mark Brown
2021-04-23 23:57 ` Art Nikpal
2021-04-26 11:56 ` Mark Brown
2021-04-30 8:49 ` Art Nikpal [this message]
2021-04-30 10:59 ` Mark Brown
2021-04-24 0:08 ` Art Nikpal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKaHn9JM-KEiz3_Btsz8_fr7hcZ2Sm8B64VyLvgpvKK-NKco3w@mail.gmail.com \
--to=email2tema@gmail.com \
--cc=art@khadas.com \
--cc=broonie@kernel.org \
--cc=christianshewitt@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gouwa@khadas.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=nick@khadas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).