From: dillon min <dillon.minfei@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Hua Dillon <dillonhua@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
linux-clk <linux-clk@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Dave Airlie <airlied@linux.ie>,
linux-stm32@st-md-mailman.stormreply.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Mark Brown <broonie@kernel.org>,
thierry.reding@gmail.com,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Sam Ravnborg <sam@ravnborg.org>,
Michael Turquette <mturquette@baylibre.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 5/9] clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate
Date: Wed, 10 Mar 2021 19:43:05 +0800 [thread overview]
Message-ID: <CAL9mu0+Uh84UGQ-1EW4+eVE1cFxuxJxLTLAa0rgJ_5C2pchUgA@mail.gmail.com> (raw)
In-Reply-To: <159056850384.88029.10852284922297394339@swboyd.mtv.corp.google.com>
still need more expert to review, so just a gentle ping for this patch
On Wed, May 27, 2020 at 4:35 PM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting dillon.minfei@gmail.com (2020-05-27 00:27:29)
> > From: dillon min <dillon.minfei@gmail.com>
> >
> > This is due to misuse \u2018PLL_VCO_SAI' and'PLL_SAI' in clk-stm32f4.c
> > 'PLL_SAI' is 2, 'PLL_VCO_SAI' is 7(defined in
> > include/dt-bindings/clock/stm32fx-clock.h).
> >
> > 'post_div' point to 'post_div_data[]', 'post_div->pll_num'
> > is PLL_I2S or PLL_SAI.
> >
> > 'clks[PLL_VCO_SAI]' has valid 'struct clk_hw* ' return
> > from stm32f4_rcc_register_pll() but, at line 1777 of
> > driver/clk/clk-stm32f4.c, use the 'clks[post_div->pll_num]',
> > equal to 'clks[PLL_SAI]', this is invalid array member at that time.
> >
> > Fixes: 517633ef630e ("clk: stm32f4: Add post divisor for I2S & SAI PLLs")
> > Signed-off-by: dillon min <dillon.minfei@gmail.com>
> > ---
>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-10 21:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 7:27 [PATCH v6 0/9] Enable ili9341 and l3gd20 on stm32f429-disco dillon.minfei
2020-05-27 7:27 ` [PATCH v6 1/9] ARM: dts: stm32: Add dma config for spi5 dillon.minfei
2020-05-27 7:27 ` [PATCH v6 2/9] ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco board dillon.minfei
2020-06-15 9:45 ` Alexandre Torgue
2020-06-15 10:05 ` dillon min
2020-05-27 7:27 ` [PATCH v6 3/9] ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on stm32429-disco board dillon.minfei
2020-05-27 7:27 ` [PATCH v6 4/9] dt-bindings: display: panel: Add ilitek ili9341 panel bindings dillon.minfei
2020-05-29 16:17 ` Rob Herring
2020-05-27 7:27 ` [PATCH v6 5/9] clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate dillon.minfei
2020-05-27 8:35 ` Stephen Boyd
2021-03-10 11:43 ` dillon min [this message]
2020-05-27 7:27 ` [PATCH v6 6/9] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after kernel startup dillon.minfei
2020-05-27 8:35 ` Stephen Boyd
2021-03-10 11:43 ` dillon min
2020-05-27 7:27 ` [PATCH v6 7/9] drm/panel: Add ilitek ili9341 panel driver dillon.minfei
2020-05-27 7:27 ` [PATCH v6 8/9] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4 dillon.minfei
2020-05-27 9:51 ` Mark Brown
2020-05-27 10:45 ` dillon min
2020-05-27 11:18 ` Mark Brown
2020-05-27 7:27 ` [PATCH v6 9/9] spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' can't be coexit with 'SPI_3WIRE' mode dillon.minfei
2020-06-15 8:49 ` [PATCH v6 0/9] Enable ili9341 and l3gd20 on stm32f429-disco Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL9mu0+Uh84UGQ-1EW4+eVE1cFxuxJxLTLAa0rgJ_5C2pchUgA@mail.gmail.com \
--to=dillon.minfei@gmail.com \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dillonhua@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).