* Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc [not found] ` <20200414131348.444715-22-hch@lst.de> @ 2020-04-14 15:13 ` Wei Liu 2020-05-01 2:33 ` John Dorminy 0 siblings, 1 reply; 8+ messages in thread From: Wei Liu @ 2020-04-14 15:13 UTC (permalink / raw) To: Christoph Hellwig Cc: linux-hyperv, David Airlie, dri-devel, Michael Kelley, linux-mm, K. Y. Srinivasan, linux-arch, linux-s390, Wei Liu, Stephen Hemminger, x86, Peter Zijlstra, Gao Xiang, Laura Abbott, Nitin Gupta, Haiyang Zhang, linaro-mm-sig, bpf, linux-arm-kernel, Christophe Leroy, Robin Murphy, linux-kernel, Minchan Kim, iommu, Sakari Ailus, Andrew Morton, linuxppc-dev On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove > it. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Michael Kelley <mikelley@microsoft.com> [hyperv] > Acked-by: Gao Xiang <xiang@kernel.org> [erofs] > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> > --- > arch/x86/hyperv/hv_init.c | 3 +-- [...] > > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > index 5a4b363ba67b..a3d689dfc745 100644 > --- a/arch/x86/hyperv/hv_init.c > +++ b/arch/x86/hyperv/hv_init.c > @@ -95,8 +95,7 @@ static int hv_cpu_init(unsigned int cpu) > * not be stopped in the case of CPU offlining and the VM will hang. > */ > if (!*hvp) { > - *hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO, > - PAGE_KERNEL); > + *hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO); > } Acked-by: Wei Liu <wei.liu@kernel.org> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc 2020-04-14 15:13 ` [PATCH 21/29] mm: remove the pgprot argument to __vmalloc Wei Liu @ 2020-05-01 2:33 ` John Dorminy 2020-05-01 2:38 ` John Dorminy 0 siblings, 1 reply; 8+ messages in thread From: John Dorminy @ 2020-05-01 2:33 UTC (permalink / raw) To: Wei Liu Cc: linux-hyperv, David Airlie, dri-devel, Michael Kelley, linux-mm, K. Y. Srinivasan, linux-arch, linux-s390, Stephen Hemminger, x86, Christoph Hellwig, Peter Zijlstra, Gao Xiang, Laura Abbott, Nitin Gupta, Haiyang Zhang, linaro-mm-sig, bpf, linux-arm-kernel, Christophe Leroy, Robin Murphy, Linux Kernel Mailing List, Minchan Kim, iommu, Sakari Ailus, Andrew Morton, linuxppc-dev [-- Attachment #1.1: Type: text/plain, Size: 1671 bytes --] Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy On Tue, Apr 14, 2020 at 11:15 AM Wei Liu <wei.liu@kernel.org> wrote: > On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: > > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove > > it. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Reviewed-by: Michael Kelley <mikelley@microsoft.com> [hyperv] > > Acked-by: Gao Xiang <xiang@kernel.org> [erofs] > > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> > > --- > > arch/x86/hyperv/hv_init.c | 3 +-- > [...] > > > > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > > index 5a4b363ba67b..a3d689dfc745 100644 > > --- a/arch/x86/hyperv/hv_init.c > > +++ b/arch/x86/hyperv/hv_init.c > > @@ -95,8 +95,7 @@ static int hv_cpu_init(unsigned int cpu) > > * not be stopped in the case of CPU offlining and the VM will > hang. > > */ > > if (!*hvp) { > > - *hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO, > > - PAGE_KERNEL); > > + *hvp = __vmalloc(PAGE_SIZE, GFP_KERNEL | __GFP_ZERO); > > } > > Acked-by: Wei Liu <wei.liu@kernel.org> > > [-- Attachment #1.2: Type: text/html, Size: 2519 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc 2020-05-01 2:33 ` John Dorminy @ 2020-05-01 2:38 ` John Dorminy 2020-05-01 22:09 ` Andrew Morton 0 siblings, 1 reply; 8+ messages in thread From: John Dorminy @ 2020-05-01 2:38 UTC (permalink / raw) To: Wei Liu Cc: linux-hyperv, David Airlie, dri-devel, Michael Kelley, linux-mm, K. Y. Srinivasan, linux-arch, linux-s390, Stephen Hemminger, x86, Christoph Hellwig, Peter Zijlstra, Gao Xiang, Laura Abbott, Nitin Gupta, Haiyang Zhang, linaro-mm-sig, bpf, linux-arm-kernel, Christophe Leroy, Robin Murphy, Linux Kernel Mailing List, Minchan Kim, iommu, Sakari Ailus, Andrew Morton, linuxppc-dev >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc 2020-05-01 2:38 ` John Dorminy @ 2020-05-01 22:09 ` Andrew Morton 0 siblings, 0 replies; 8+ messages in thread From: Andrew Morton @ 2020-05-01 22:09 UTC (permalink / raw) To: John Dorminy Cc: linux-hyperv, David Airlie, dri-devel, Michael Kelley, linux-mm, K. Y. Srinivasan, linux-arch, linux-s390, Wei Liu, Stephen Hemminger, x86, Christoph Hellwig, Peter Zijlstra, Gao Xiang, Laura Abbott, Nitin Gupta, Haiyang Zhang, linaro-mm-sig, linux-arm-kernel, Christophe Leroy, Robin Murphy, Linux Kernel Mailing List, Minchan Kim, iommu, Sakari Ailus, bpf, linuxppc-dev On Thu, 30 Apr 2020 22:38:10 -0400 John Dorminy <jdorminy@redhat.com> wrote: > the change > description refers to PROT_KERNEL, which is a symbol which does not > appear to exist; perhaps PAGE_KERNEL was meant? Yes, thanks, fixed. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20200414131348.444715-12-hch@lst.de>]
* Re: [PATCH 11/29] mm: only allow page table mappings for built-in zsmalloc [not found] ` <20200414131348.444715-12-hch@lst.de> @ 2020-04-16 20:43 ` Minchan Kim 0 siblings, 0 replies; 8+ messages in thread From: Minchan Kim @ 2020-04-16 20:43 UTC (permalink / raw) To: Christoph Hellwig Cc: linux-hyperv, sergey.senozhatsky.work, David Airlie, dri-devel, linux-mm, K. Y. Srinivasan, linux-arch, linux-s390, Wei Liu, Stephen Hemminger, x86, Peter Zijlstra, Laura Abbott, Nitin Gupta, Haiyang Zhang, linaro-mm-sig, bpf, linux-arm-kernel, Christophe Leroy, Robin Murphy, linux-kernel, iommu, Sakari Ailus, Andrew Morton, linuxppc-dev On Tue, Apr 14, 2020 at 03:13:30PM +0200, Christoph Hellwig wrote: > This allows to unexport map_vm_area and unmap_kernel_range, which are > rather deep internal and should not be available to modules, as they for > example allow fine grained control of mapping permissions, and also > allow splitting the setup of a vmalloc area and the actual mapping and > thus expose vmalloc internals. > > zsmalloc is typically built-in and continues to work (just like the > percpu-vm code using a similar patter), while modular zsmalloc also > continues to work, but must use copies. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Minchan Kim <minchan@kernel.org> Thanks! _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20200414131348.444715-27-hch@lst.de>]
* Re: [PATCH 26/29] mm: remove vmalloc_user_node_flags [not found] ` <20200414131348.444715-27-hch@lst.de> @ 2020-04-20 9:26 ` Geert Uytterhoeven 0 siblings, 0 replies; 8+ messages in thread From: Geert Uytterhoeven @ 2020-04-20 9:26 UTC (permalink / raw) To: Christoph Hellwig Cc: linux-hyperv, David Airlie, DRI Development, Linux MM, K. Y. Srinivasan, Linux-Arch, linux-s390, Wei Liu, Stephen Hemminger, the arch/x86 maintainers, Peter Zijlstra, Laura Abbott, Nitin Gupta, Haiyang Zhang, linaro-mm-sig, bpf, Linux ARM, Christophe Leroy, Robin Murphy, Linux Kernel Mailing List, Minchan Kim, Linux IOMMU, Sakari Ailus, Johannes Weiner, Andrew Morton, linuxppc-dev Hi Christoph, On Tue, Apr 14, 2020 at 3:22 PM Christoph Hellwig <hch@lst.de> wrote: > Open code it in __bpf_map_area_alloc, which is the only caller. Also > clean up __bpf_map_area_alloc to have a single vmalloc call with > slightly different flags instead of the current two different calls. > > For this to compile for the nommu case add a __vmalloc_node_range stub > to nommu.c. Apparently your nommu-cross-compilers are in quarantaine? ;-) > Signed-off-by: Christoph Hellwig <hch@lst.de> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -150,6 +150,14 @@ void *__vmalloc(unsigned long size, gfp_t gfp_mask) > } > EXPORT_SYMBOL(__vmalloc); > > +void *__vmalloc_node_range(unsigned long size, unsigned long align, > + unsigned long start, unsigned long end, gfp_t gfp_mask, > + pgprot_t prot, unsigned long vm_flags, int node, > + const void *caller) > +{ > + return __vmalloc(size, flags); On Mon, Apr 20, 2020 at 10:39 AM <noreply@ellerman.id.au> wrote: > FAILED linux-next/m5272c3_defconfig/m68k-gcc8 Mon Apr 20, 18:38 > > http://kisskb.ellerman.id.au/kisskb/buildresult/14213623/ > > mm/nommu.c:158:25: error: 'flags' undeclared (first use in this function); did you mean 'class'? "return __vmalloc(size, gfp_mask);", I assume? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20200414131348.444715-25-hch@lst.de>]
* Re: [PATCH 24/29] mm: remove __vmalloc_node_flags_caller [not found] ` <20200414131348.444715-25-hch@lst.de> @ 2020-04-20 9:27 ` Geert Uytterhoeven 0 siblings, 0 replies; 8+ messages in thread From: Geert Uytterhoeven @ 2020-04-20 9:27 UTC (permalink / raw) To: Christoph Hellwig Cc: linux-hyperv, David Airlie, DRI Development, Linux MM, K. Y. Srinivasan, Linux-Arch, linux-s390, Wei Liu, Stephen Hemminger, the arch/x86 maintainers, Peter Zijlstra, Laura Abbott, Nitin Gupta, Haiyang Zhang, linaro-mm-sig, bpf, Linux ARM, Christophe Leroy, Robin Murphy, Linux Kernel Mailing List, Minchan Kim, Linux IOMMU, Sakari Ailus, Andrew Morton, linuxppc-dev Hi Christoph, On Tue, Apr 14, 2020 at 3:21 PM Christoph Hellwig <hch@lst.de> wrote: > Just use __vmalloc_node instead which gets and extra argument. To be > able to to use __vmalloc_node in all caller make it available outside > of vmalloc and implement it in nommu.c. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> One more nommu failure below... > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -150,8 +150,8 @@ void *__vmalloc(unsigned long size, gfp_t gfp_mask) > } > EXPORT_SYMBOL(__vmalloc); > > -void *__vmalloc_node_flags_caller(unsigned long size, int node, gfp_t flags, > - void *caller) > +void *__vmalloc_node(unsigned long size, unsigned long align, gfp_t gfp_mask, > + int node, const void *caller) > { > return __vmalloc(size, flags); On Mon, Apr 20, 2020 at 10:39 AM <noreply@ellerman.id.au> wrote: > FAILED linux-next/m5272c3_defconfig/m68k-gcc8 Mon Apr 20, 18:38 > > http://kisskb.ellerman.id.au/kisskb/buildresult/14213623/ > > mm/nommu.c:164:25: error: 'flags' undeclared (first use in this function); did you mean 'class'? "return __vmalloc(size, gfp_mask);" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20200414131348.444715-5-hch@lst.de>]
* Re: [PATCH 04/29] staging: media: ipu3: use vmap instead of reimplementing it [not found] ` <20200414131348.444715-5-hch@lst.de> @ 2020-04-23 10:32 ` Sakari Ailus 0 siblings, 0 replies; 8+ messages in thread From: Sakari Ailus @ 2020-04-23 10:32 UTC (permalink / raw) To: Christoph Hellwig Cc: linux-hyperv, David Airlie, dri-devel, linux-mm, K. Y. Srinivasan, linux-arch, linux-s390, Wei Liu, Stephen Hemminger, x86, Peter Zijlstra, Laura Abbott, Nitin Gupta, Haiyang Zhang, linaro-mm-sig, bpf, linux-arm-kernel, Christophe Leroy, Robin Murphy, linux-kernel, Minchan Kim, iommu, Andrew Morton, linuxppc-dev On Tue, Apr 14, 2020 at 03:13:23PM +0200, Christoph Hellwig wrote: > Just use vmap instead of messing with vmalloc internals. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Thanks! Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> -- Sakari Ailus _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-05-01 22:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200414131348.444715-1-hch@lst.de>
[not found] ` <20200414131348.444715-22-hch@lst.de>
2020-04-14 15:13 ` [PATCH 21/29] mm: remove the pgprot argument to __vmalloc Wei Liu
2020-05-01 2:33 ` John Dorminy
2020-05-01 2:38 ` John Dorminy
2020-05-01 22:09 ` Andrew Morton
[not found] ` <20200414131348.444715-12-hch@lst.de>
2020-04-16 20:43 ` [PATCH 11/29] mm: only allow page table mappings for built-in zsmalloc Minchan Kim
[not found] ` <20200414131348.444715-27-hch@lst.de>
2020-04-20 9:26 ` [PATCH 26/29] mm: remove vmalloc_user_node_flags Geert Uytterhoeven
[not found] ` <20200414131348.444715-25-hch@lst.de>
2020-04-20 9:27 ` [PATCH 24/29] mm: remove __vmalloc_node_flags_caller Geert Uytterhoeven
[not found] ` <20200414131348.444715-5-hch@lst.de>
2020-04-23 10:32 ` [PATCH 04/29] staging: media: ipu3: use vmap instead of reimplementing it Sakari Ailus
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).