From: Paulo Pavacic <pavacic.p@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: neil.armstrong@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, sam@ravnborg.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v4 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel
Date: Fri, 16 Jun 2023 11:57:29 +0200 [thread overview]
Message-ID: <CAO9szn00vRFm+iM1m7KgkW0WRuKyJEgVU4tVx4f5tF6KPnE=2w@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbrEA54qmfTKSsFRG9ZS4u8hM6P5TXtOjRAiW+TD_v-fQ@mail.gmail.com>
Hello Linus,
thank you for the comments.
čet, 15. lip 2023. u 21:55 Linus Walleij <linus.walleij@linaro.org> napisao je:
>
> Hi Paulo,
>
> thanks for your patch!
>
> Overall this looks very good.
>
> I doubt that the display controller is actually by Fannal, but I guess
> you tried to find out? We usually try to identify the underlying display
> controller so the driver can be named after it and reused for more
> display panels.
Yes, of course, the controller is ST7701S.
>
> Some minor questions/nitpicks below.
>
> On Wed, Jun 7, 2023 at 5:11 PM Paulo Pavacic <pavacic.p@gmail.com> wrote:
>
> > +static int fannal_panel_enable(struct drm_panel *panel)
> > +{
> > + struct mipi_dsi_device *dsi = to_mipi_dsi_device(panel->dev);
> > +
> > + mipi_dsi_generic_write_seq(dsi, 0xFF, 0x77, 0x01, 0x00, 0x00, 0x13);
> > + mipi_dsi_generic_write_seq(dsi, 0xEF, 0x08);
>
> Why is everything using mipi_dsi_generic_write_seq() instead of
> mipi_dsi_dcs_write_seq()?
Okay, I will replace it.
>
> Especially here, because 0x11 is certainly a command:
>
> > + mipi_dsi_generic_write_seq(dsi, 0x11); //MIPI_DCS_EXIT_SLEEP_MODE
>
> Instead use:
>
> ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> if (ret)
> return ret;
>
>
> > + mipi_dsi_generic_write_seq(dsi, 0x29); //MIPI_DCS_SET_DISPLAY_ON
>
> Instead use:
>
> ret = mipi_dsi_dcs_set_display_on(dsi);
> if (ret)
> return ret;
>
Okay I will replace all commands with a functions found here:
https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_mipi_dsi.c#L995
> Yours,
> Linus Walleij
Best regards,
Paulo
next prev parent reply other threads:[~2023-06-16 9:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 15:11 [PATCH v4 0/3] drm/panel: add fannal c3004 panel Paulo Pavacic
2023-06-07 15:11 ` [PATCH v4 1/3] dt-bindings: add fannal vendor prefix Paulo Pavacic
2023-06-07 15:11 ` [PATCH v4 2/3] dt-bindings: display: panel: add fannal,c3004 Paulo Pavacic
2023-06-07 15:11 ` [PATCH v4 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel Paulo Pavacic
2023-06-15 19:54 ` Linus Walleij
2023-06-16 9:57 ` Paulo Pavacic [this message]
2023-06-16 11:43 ` Linus Walleij
2023-06-16 12:31 ` Paulo Pavacic
2023-06-16 12:52 ` Linus Walleij
2023-06-21 15:08 ` Paulo Pavacic
2023-06-22 8:22 ` Linus Walleij
2023-07-06 15:18 ` Paulo Pavacic
2023-07-06 15:26 ` Marek Vasut
2023-07-07 15:26 ` Paulo Pavacic
2023-07-08 11:07 ` Marek Vasut
2023-07-12 12:07 ` Paulo Pavacic
2023-07-12 13:42 ` Marek Vasut
2023-07-12 15:10 ` Paulo Pavacic
2023-07-12 17:25 ` Marek Vasut
2023-09-05 8:32 ` Paulo
2023-07-08 7:11 ` Paulo Pavačić
2023-07-08 8:22 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO9szn00vRFm+iM1m7KgkW0WRuKyJEgVU4tVx4f5tF6KPnE=2w@mail.gmail.com' \
--to=pavacic.p@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).