From: Paulo Pavacic <pavacic.p@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: neil.armstrong@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, sam@ravnborg.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v4 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel
Date: Wed, 21 Jun 2023 17:08:57 +0200 [thread overview]
Message-ID: <CAO9szn0OuKW+-JZMs3TPUHiwLCe6cUPcsUq+og64K2utMyZpqQ@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdYXtQwmZR1u-1fwmyC_8Yq4bMkjDBcUCfuGqSz_UhXWJQ@mail.gmail.com>
pet, 16. lip 2023. u 14:53 Linus Walleij <linus.walleij@linaro.org> napisao je:
>
> On Fri, Jun 16, 2023 at 2:31 PM Paulo Pavacic <pavacic.p@gmail.com> wrote:
> > pet, 16. lip 2023. u 13:44 Linus Walleij <linus.walleij@linaro.org> napisao je:
> > >
> > > On Fri, Jun 16, 2023 at 11:57 AM Paulo Pavacic <pavacic.p@gmail.com> wrote:
> > > > čet, 15. lip 2023. u 21:55 Linus Walleij <linus.walleij@linaro.org> napisao je:
> > > > >
> > > > > I doubt that the display controller is actually by Fannal, but I guess
> > > > > you tried to find out? We usually try to identify the underlying display
> > > > > controller so the driver can be named after it and reused for more
> > > > > display panels.
> > > >
> > > > Yes, of course, the controller is ST7701S.
> > >
> > > Hm did you try to just refactor
> > > drivers/gpu/drm/panel/panel-sitronix-st7701.c
> > > to support your new panel?
> >
> > Yes I have tried, but there are too many changes needed and I wasn't
> > sure whether I would be breaking compatibility with st7701 based
> > panels.
>
> For the community it creates a problem that now two drivers for similar
> hardware need to be maintained, and that burden will land on the DRM
> maintainers. For this reason it would be better if a joint driver could
> be created.
I will try modifying st7701, but that seems like a big task since
currently st7701 crashes kernel (5.15) for me and I have seen
suggestions to use raydium driver over st7701.
Also I guess I should first read some more documentation and compare
st7701 to st7701s. I currently can't reserve a lot of time for that.
>
> I am sure the users of the old driver will be willing to test patches to
> make sure their devices keep working.
A lot of modifications to st7701 are required. I believe it would
result in a driver that doesn't look or work the same. e.g compare
delays between initialization sequences of panel-fannal-c3004 and
panel-st7701. I think it would be optimal to create st7701s driver and
have special handling for st7701s panels. If there was a flag for
whether panel is st7701 or st7701s it would end up looking like a
mess.
>
> Yours,
> Linus Walleij
Thank you for your time,
Paulo
next prev parent reply other threads:[~2023-06-21 15:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 15:11 [PATCH v4 0/3] drm/panel: add fannal c3004 panel Paulo Pavacic
2023-06-07 15:11 ` [PATCH v4 1/3] dt-bindings: add fannal vendor prefix Paulo Pavacic
2023-06-07 15:11 ` [PATCH v4 2/3] dt-bindings: display: panel: add fannal,c3004 Paulo Pavacic
2023-06-07 15:11 ` [PATCH v4 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel Paulo Pavacic
2023-06-15 19:54 ` Linus Walleij
2023-06-16 9:57 ` Paulo Pavacic
2023-06-16 11:43 ` Linus Walleij
2023-06-16 12:31 ` Paulo Pavacic
2023-06-16 12:52 ` Linus Walleij
2023-06-21 15:08 ` Paulo Pavacic [this message]
2023-06-22 8:22 ` Linus Walleij
2023-07-06 15:18 ` Paulo Pavacic
2023-07-06 15:26 ` Marek Vasut
2023-07-07 15:26 ` Paulo Pavacic
2023-07-08 11:07 ` Marek Vasut
2023-07-12 12:07 ` Paulo Pavacic
2023-07-12 13:42 ` Marek Vasut
2023-07-12 15:10 ` Paulo Pavacic
2023-07-12 17:25 ` Marek Vasut
2023-09-05 8:32 ` Paulo
2023-07-08 7:11 ` Paulo Pavačić
2023-07-08 8:22 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO9szn0OuKW+-JZMs3TPUHiwLCe6cUPcsUq+og64K2utMyZpqQ@mail.gmail.com \
--to=pavacic.p@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).