From: Dave Airlie <airlied@gmail.com>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: kernel test robot <lkp@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Dave Airlie <airlied@redhat.com>, Sam Ravnborg <sam@ravnborg.org>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH] drm/mgag200: Set PCI option register in G200SE models
Date: Tue, 4 Aug 2020 16:54:11 +1000 [thread overview]
Message-ID: <CAPM=9txb7qv3oEmQW5LaiSQy-jDmYT4ikbMSZhBiMA8Lxhn13w@mail.gmail.com> (raw)
In-Reply-To: <20200804065158.21049-1-tzimmermann@suse.de>
On Tue, 4 Aug 2020 at 16:52, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> The initial value of the PCI option register got lost while refactoring
> the driver init code. Restore the setting.
>
Ooops,
Reviewed-by: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 2021708e0d6e ("drm/mgag200: Initialize PCI registers early during device setup")
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Emil Velikov <emil.velikov@collabora.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 5c854bc7dc86..09170d46aa53 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -74,6 +74,7 @@ static int mgag200_regs_init(struct mga_device *mdev)
> break;
> case G200_SE_A:
> case G200_SE_B:
> + option = 0x40049120;
> if (mgag200_has_sgram(mdev))
> option |= PCI_MGA_OPTION_HARDPWMSK;
> option2 = 0x00008000;
> --
> 2.28.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-08-04 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 6:51 [PATCH] drm/mgag200: Set PCI option register in G200SE models Thomas Zimmermann
2020-08-04 6:54 ` Dave Airlie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM=9txb7qv3oEmQW5LaiSQy-jDmYT4ikbMSZhBiMA8Lxhn13w@mail.gmail.com' \
--to=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=kraxel@redhat.com \
--cc=lkp@intel.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).