* [PATCH] drm/mgag200: Set PCI option register in G200SE models
@ 2020-08-04 6:51 Thomas Zimmermann
2020-08-04 6:54 ` Dave Airlie
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Zimmermann @ 2020-08-04 6:51 UTC (permalink / raw)
To: airlied, daniel, lyude, sam, kraxel
Cc: Daniel Vetter, Emil Velikov, Thomas Zimmermann, dri-devel,
kernel test robot
The initial value of the PCI option register got lost while refactoring
the driver init code. Restore the setting.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 2021708e0d6e ("drm/mgag200: Initialize PCI registers early during device setup")
Cc: Lyude Paul <lyude@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Emil Velikov <emil.velikov@collabora.com>
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index 5c854bc7dc86..09170d46aa53 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -74,6 +74,7 @@ static int mgag200_regs_init(struct mga_device *mdev)
break;
case G200_SE_A:
case G200_SE_B:
+ option = 0x40049120;
if (mgag200_has_sgram(mdev))
option |= PCI_MGA_OPTION_HARDPWMSK;
option2 = 0x00008000;
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/mgag200: Set PCI option register in G200SE models
2020-08-04 6:51 [PATCH] drm/mgag200: Set PCI option register in G200SE models Thomas Zimmermann
@ 2020-08-04 6:54 ` Dave Airlie
0 siblings, 0 replies; 2+ messages in thread
From: Dave Airlie @ 2020-08-04 6:54 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: kernel test robot, Daniel Vetter, dri-devel, Gerd Hoffmann,
Dave Airlie, Sam Ravnborg, Emil Velikov
On Tue, 4 Aug 2020 at 16:52, Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> The initial value of the PCI option register got lost while refactoring
> the driver init code. Restore the setting.
>
Ooops,
Reviewed-by: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 2021708e0d6e ("drm/mgag200: Initialize PCI registers early during device setup")
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Emil Velikov <emil.velikov@collabora.com>
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 5c854bc7dc86..09170d46aa53 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -74,6 +74,7 @@ static int mgag200_regs_init(struct mga_device *mdev)
> break;
> case G200_SE_A:
> case G200_SE_B:
> + option = 0x40049120;
> if (mgag200_has_sgram(mdev))
> option |= PCI_MGA_OPTION_HARDPWMSK;
> option2 = 0x00008000;
> --
> 2.28.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-04 6:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04 6:51 [PATCH] drm/mgag200: Set PCI option register in G200SE models Thomas Zimmermann
2020-08-04 6:54 ` Dave Airlie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).