From: Daniel Vetter <daniel@ffwll.ch>
To: Felix Kuehling <Felix.Kuehling@amd.com>
Cc: alex.sierra@amd.com, philip.yang@amd.com,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD
Date: Thu, 7 Jan 2021 10:23:33 +0100 [thread overview]
Message-ID: <X/bTFWL3HYVc8LEF@phenom.ffwll.local> (raw)
In-Reply-To: <20210107030127.20393-1-Felix.Kuehling@amd.com>
On Wed, Jan 06, 2021 at 10:00:52PM -0500, Felix Kuehling wrote:
> This is the first version of our HMM based shared virtual memory manager
> for KFD. There are still a number of known issues that we're working through
> (see below). This will likely lead to some pretty significant changes in
> MMU notifier handling and locking on the migration code paths. So don't
> get hung up on those details yet.
>
> But I think this is a good time to start getting feedback. We're pretty
> confident about the ioctl API, which is both simple and extensible for the
> future. (see patches 4,16) The user mode side of the API can be found here:
> https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/blob/fxkamd/hmm-wip/src/svm.c
>
> I'd also like another pair of eyes on how we're interfacing with the GPU VM
> code in amdgpu_vm.c (see patches 12,13), retry page fault handling (24,25),
> and some retry IRQ handling changes (32).
>
>
> Known issues:
> * won't work with IOMMU enabled, we need to dma_map all pages properly
> * still working on some race conditions and random bugs
> * performance is not great yet
Still catching up, but I think there's another one for your list:
* hmm gpu context preempt vs page fault handling. I've had a short
discussion about this one with Christian before the holidays, and also
some private chats with Jerome. It's nasty since no easy fix, much less
a good idea what's the best approach here.
I'll try to look at this more in-depth when I'm catching up on mails.
-Daniel
>
> Alex Sierra (12):
> drm/amdgpu: replace per_device_list by array
> drm/amdkfd: helper to convert gpu id and idx
> drm/amdkfd: add xnack enabled flag to kfd_process
> drm/amdkfd: add ioctl to configure and query xnack retries
> drm/amdkfd: invalidate tables on page retry fault
> drm/amdkfd: page table restore through svm API
> drm/amdkfd: SVM API call to restore page tables
> drm/amdkfd: add svm_bo reference for eviction fence
> drm/amdgpu: add param bit flag to create SVM BOs
> drm/amdkfd: add svm_bo eviction mechanism support
> drm/amdgpu: svm bo enable_signal call condition
> drm/amdgpu: add svm_bo eviction to enable_signal cb
>
> Philip Yang (23):
> drm/amdkfd: select kernel DEVICE_PRIVATE option
> drm/amdkfd: add svm ioctl API
> drm/amdkfd: Add SVM API support capability bits
> drm/amdkfd: register svm range
> drm/amdkfd: add svm ioctl GET_ATTR op
> drm/amdgpu: add common HMM get pages function
> drm/amdkfd: validate svm range system memory
> drm/amdkfd: register overlap system memory range
> drm/amdkfd: deregister svm range
> drm/amdgpu: export vm update mapping interface
> drm/amdkfd: map svm range to GPUs
> drm/amdkfd: svm range eviction and restore
> drm/amdkfd: register HMM device private zone
> drm/amdkfd: validate vram svm range from TTM
> drm/amdkfd: support xgmi same hive mapping
> drm/amdkfd: copy memory through gart table
> drm/amdkfd: HMM migrate ram to vram
> drm/amdkfd: HMM migrate vram to ram
> drm/amdgpu: reserve fence slot to update page table
> drm/amdgpu: enable retry fault wptr overflow
> drm/amdkfd: refine migration policy with xnack on
> drm/amdkfd: add svm range validate timestamp
> drm/amdkfd: multiple gpu migrate vram to vram
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 3 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 4 +-
> .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 16 +-
> .../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 13 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 83 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h | 7 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 5 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 90 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 47 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 10 +
> drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 32 +-
> drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 32 +-
> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
> drivers/gpu/drm/amd/amdkfd/Makefile | 4 +-
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 170 +-
> drivers/gpu/drm/amd/amdkfd/kfd_iommu.c | 8 +-
> drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 866 ++++++
> drivers/gpu/drm/amd/amdkfd/kfd_migrate.h | 59 +
> drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 52 +-
> drivers/gpu/drm/amd/amdkfd/kfd_process.c | 200 +-
> .../amd/amdkfd/kfd_process_queue_manager.c | 6 +-
> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2564 +++++++++++++++++
> drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 135 +
> drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 +
> drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 10 +-
> include/uapi/linux/kfd_ioctl.h | 169 +-
> 26 files changed, 4296 insertions(+), 291 deletions(-)
> create mode 100644 drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> create mode 100644 drivers/gpu/drm/amd/amdkfd/kfd_migrate.h
> create mode 100644 drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> create mode 100644 drivers/gpu/drm/amd/amdkfd/kfd_svm.h
>
> --
> 2.29.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-07 9:23 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 3:00 [PATCH 00/35] Add HMM-based SVM memory manager to KFD Felix Kuehling
2021-01-07 3:00 ` [PATCH 01/35] drm/amdkfd: select kernel DEVICE_PRIVATE option Felix Kuehling
2021-01-07 3:00 ` [PATCH 02/35] drm/amdgpu: replace per_device_list by array Felix Kuehling
2021-01-07 3:00 ` [PATCH 03/35] drm/amdkfd: helper to convert gpu id and idx Felix Kuehling
2021-01-07 3:00 ` [PATCH 04/35] drm/amdkfd: add svm ioctl API Felix Kuehling
2021-01-07 3:00 ` [PATCH 05/35] drm/amdkfd: Add SVM API support capability bits Felix Kuehling
2021-01-07 3:00 ` [PATCH 06/35] drm/amdkfd: register svm range Felix Kuehling
2021-01-07 3:00 ` [PATCH 07/35] drm/amdkfd: add svm ioctl GET_ATTR op Felix Kuehling
2021-01-07 3:01 ` [PATCH 08/35] drm/amdgpu: add common HMM get pages function Felix Kuehling
2021-01-07 10:53 ` Christian König
2021-01-07 3:01 ` [PATCH 09/35] drm/amdkfd: validate svm range system memory Felix Kuehling
2021-01-07 3:01 ` [PATCH 10/35] drm/amdkfd: register overlap system memory range Felix Kuehling
2021-01-07 3:01 ` [PATCH 11/35] drm/amdkfd: deregister svm range Felix Kuehling
2021-01-07 3:01 ` [PATCH 12/35] drm/amdgpu: export vm update mapping interface Felix Kuehling
2021-01-07 10:54 ` Christian König
2021-01-07 3:01 ` [PATCH 13/35] drm/amdkfd: map svm range to GPUs Felix Kuehling
2021-01-07 3:01 ` [PATCH 14/35] drm/amdkfd: svm range eviction and restore Felix Kuehling
2021-01-07 3:01 ` [PATCH 15/35] drm/amdkfd: add xnack enabled flag to kfd_process Felix Kuehling
2021-01-07 3:01 ` [PATCH 16/35] drm/amdkfd: add ioctl to configure and query xnack retries Felix Kuehling
2021-01-07 3:01 ` [PATCH 17/35] drm/amdkfd: register HMM device private zone Felix Kuehling
2021-03-01 8:32 ` Daniel Vetter
2021-03-01 8:46 ` Thomas Hellström (Intel)
2021-03-01 8:58 ` Daniel Vetter
2021-03-01 9:30 ` Thomas Hellström (Intel)
2021-03-04 17:58 ` Felix Kuehling
2021-03-11 12:24 ` Thomas Hellström (Intel)
2021-01-07 3:01 ` [PATCH 18/35] drm/amdkfd: validate vram svm range from TTM Felix Kuehling
2021-01-07 3:01 ` [PATCH 19/35] drm/amdkfd: support xgmi same hive mapping Felix Kuehling
2021-01-07 3:01 ` [PATCH 20/35] drm/amdkfd: copy memory through gart table Felix Kuehling
2021-01-07 3:01 ` [PATCH 21/35] drm/amdkfd: HMM migrate ram to vram Felix Kuehling
2021-01-07 3:01 ` [PATCH 22/35] drm/amdkfd: HMM migrate vram to ram Felix Kuehling
2021-01-07 3:01 ` [PATCH 23/35] drm/amdkfd: invalidate tables on page retry fault Felix Kuehling
2021-01-07 3:01 ` [PATCH 24/35] drm/amdkfd: page table restore through svm API Felix Kuehling
2021-01-07 3:01 ` [PATCH 25/35] drm/amdkfd: SVM API call to restore page tables Felix Kuehling
2021-01-07 3:01 ` [PATCH 26/35] drm/amdkfd: add svm_bo reference for eviction fence Felix Kuehling
2021-01-07 3:01 ` [PATCH 27/35] drm/amdgpu: add param bit flag to create SVM BOs Felix Kuehling
2021-01-07 3:01 ` [PATCH 28/35] drm/amdkfd: add svm_bo eviction mechanism support Felix Kuehling
2021-01-07 3:01 ` [PATCH 29/35] drm/amdgpu: svm bo enable_signal call condition Felix Kuehling
2021-01-07 10:56 ` Christian König
2021-01-07 16:16 ` Felix Kuehling
2021-01-07 16:28 ` Christian König
2021-01-07 16:53 ` Felix Kuehling
2021-01-07 3:01 ` [PATCH 30/35] drm/amdgpu: add svm_bo eviction to enable_signal cb Felix Kuehling
2021-01-07 3:01 ` [PATCH 31/35] drm/amdgpu: reserve fence slot to update page table Felix Kuehling
2021-01-07 10:57 ` Christian König
2021-01-07 3:01 ` [PATCH 32/35] drm/amdgpu: enable retry fault wptr overflow Felix Kuehling
2021-01-07 11:01 ` Christian König
2021-01-07 3:01 ` [PATCH 33/35] drm/amdkfd: refine migration policy with xnack on Felix Kuehling
2021-01-07 3:01 ` [PATCH 34/35] drm/amdkfd: add svm range validate timestamp Felix Kuehling
2021-01-07 3:01 ` [PATCH 35/35] drm/amdkfd: multiple gpu migrate vram to vram Felix Kuehling
2021-01-07 9:23 ` Daniel Vetter [this message]
2021-01-07 16:25 ` [PATCH 00/35] Add HMM-based SVM memory manager to KFD Felix Kuehling
2021-01-08 14:40 ` Daniel Vetter
2021-01-08 14:45 ` Christian König
2021-01-08 15:58 ` Felix Kuehling
2021-01-08 16:06 ` Daniel Vetter
2021-01-08 16:36 ` Felix Kuehling
2021-01-08 16:53 ` Daniel Vetter
2021-01-08 17:56 ` Felix Kuehling
2021-01-11 16:29 ` Daniel Vetter
2021-01-14 5:34 ` Felix Kuehling
2021-01-14 12:19 ` Christian König
2021-01-13 16:56 ` Jerome Glisse
2021-01-13 20:31 ` Daniel Vetter
2021-01-14 3:27 ` Jerome Glisse
2021-01-14 9:26 ` Daniel Vetter
2021-01-14 10:39 ` Daniel Vetter
2021-01-14 10:49 ` Christian König
2021-01-14 11:52 ` Daniel Vetter
2021-01-14 13:37 ` HMM fence (was Re: [PATCH 00/35] Add HMM-based SVM memory manager to KFD) Christian König
2021-01-14 13:57 ` Daniel Vetter
2021-01-14 14:13 ` Christian König
2021-01-14 14:23 ` Daniel Vetter
2021-01-14 15:08 ` Christian König
2021-01-14 15:40 ` Daniel Vetter
2021-01-14 16:01 ` Christian König
2021-01-14 16:36 ` Daniel Vetter
2021-01-14 19:08 ` Christian König
2021-01-14 20:09 ` Daniel Vetter
2021-01-14 16:51 ` Jerome Glisse
2021-01-14 21:13 ` Felix Kuehling
2021-01-15 7:47 ` Christian König
2021-01-13 16:47 ` [PATCH 00/35] Add HMM-based SVM memory manager to KFD Jerome Glisse
2021-01-14 0:06 ` Felix Kuehling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/bTFWL3HYVc8LEF@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Felix.Kuehling@amd.com \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=philip.yang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).