* [PATCH] drm: mali-dp: potential dereference of null pointer
@ 2021-12-14 10:08 Jiasheng Jiang
2021-12-14 11:02 ` Brian Starkey
0 siblings, 1 reply; 3+ messages in thread
From: Jiasheng Jiang @ 2021-12-14 10:08 UTC (permalink / raw)
To: liviu.dudau, brian.starkey, airlied, daniel
Cc: Jiasheng Jiang, linux-kernel, dri-devel
The return value of kzalloc() needs to be checked.
To avoid use of null pointer '&state->base' in case of the
failure of alloc.
Fixes: 99665d072183 ("drm: mali-dp: add malidp_crtc_state struct")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/gpu/drm/arm/malidp_crtc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
index 494075ddbef6..b5928b52e279 100644
--- a/drivers/gpu/drm/arm/malidp_crtc.c
+++ b/drivers/gpu/drm/arm/malidp_crtc.c
@@ -487,7 +487,10 @@ static void malidp_crtc_reset(struct drm_crtc *crtc)
if (crtc->state)
malidp_crtc_destroy_state(crtc, crtc->state);
- __drm_atomic_helper_crtc_reset(crtc, &state->base);
+ if (state)
+ __drm_atomic_helper_crtc_reset(crtc, &state->base);
+ else
+ __drm_atomic_helper_crtc_reset(crtc, NULL);
}
static int malidp_crtc_enable_vblank(struct drm_crtc *crtc)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: mali-dp: potential dereference of null pointer
2021-12-14 10:08 [PATCH] drm: mali-dp: potential dereference of null pointer Jiasheng Jiang
@ 2021-12-14 11:02 ` Brian Starkey
2021-12-20 9:40 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Brian Starkey @ 2021-12-14 11:02 UTC (permalink / raw)
To: Jiasheng Jiang; +Cc: airlied, liviu.dudau, linux-kernel, dri-devel, nd
Hi,
On Tue, Dec 14, 2021 at 06:08:37PM +0800, Jiasheng Jiang wrote:
> The return value of kzalloc() needs to be checked.
> To avoid use of null pointer '&state->base' in case of the
> failure of alloc.
>
> Fixes: 99665d072183 ("drm: mali-dp: add malidp_crtc_state struct")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
You can add my r-b to this one too. Thanks!
> drivers/gpu/drm/arm/malidp_crtc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
> index 494075ddbef6..b5928b52e279 100644
> --- a/drivers/gpu/drm/arm/malidp_crtc.c
> +++ b/drivers/gpu/drm/arm/malidp_crtc.c
> @@ -487,7 +487,10 @@ static void malidp_crtc_reset(struct drm_crtc *crtc)
> if (crtc->state)
> malidp_crtc_destroy_state(crtc, crtc->state);
>
> - __drm_atomic_helper_crtc_reset(crtc, &state->base);
> + if (state)
> + __drm_atomic_helper_crtc_reset(crtc, &state->base);
> + else
> + __drm_atomic_helper_crtc_reset(crtc, NULL);
> }
>
> static int malidp_crtc_enable_vblank(struct drm_crtc *crtc)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: mali-dp: potential dereference of null pointer
2021-12-14 11:02 ` Brian Starkey
@ 2021-12-20 9:40 ` Daniel Vetter
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2021-12-20 9:40 UTC (permalink / raw)
To: Brian Starkey
Cc: airlied, Jiasheng Jiang, liviu.dudau, linux-kernel, dri-devel, nd
On Tue, Dec 14, 2021 at 11:02:02AM +0000, Brian Starkey wrote:
> Hi,
>
> On Tue, Dec 14, 2021 at 06:08:37PM +0800, Jiasheng Jiang wrote:
> > The return value of kzalloc() needs to be checked.
> > To avoid use of null pointer '&state->base' in case of the
> > failure of alloc.
> >
> > Fixes: 99665d072183 ("drm: mali-dp: add malidp_crtc_state struct")
> > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> > ---
>
> You can add my r-b to this one too. Thanks!
Are you (or someone else from arm) also pushing these? Otherwise they'll
get lost.
-Daniel
>
> > drivers/gpu/drm/arm/malidp_crtc.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
> > index 494075ddbef6..b5928b52e279 100644
> > --- a/drivers/gpu/drm/arm/malidp_crtc.c
> > +++ b/drivers/gpu/drm/arm/malidp_crtc.c
> > @@ -487,7 +487,10 @@ static void malidp_crtc_reset(struct drm_crtc *crtc)
> > if (crtc->state)
> > malidp_crtc_destroy_state(crtc, crtc->state);
> >
> > - __drm_atomic_helper_crtc_reset(crtc, &state->base);
> > + if (state)
> > + __drm_atomic_helper_crtc_reset(crtc, &state->base);
> > + else
> > + __drm_atomic_helper_crtc_reset(crtc, NULL);
> > }
> >
> > static int malidp_crtc_enable_vblank(struct drm_crtc *crtc)
> > --
> > 2.25.1
> >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-20 9:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-14 10:08 [PATCH] drm: mali-dp: potential dereference of null pointer Jiasheng Jiang
2021-12-14 11:02 ` Brian Starkey
2021-12-20 9:40 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).