dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Caleb Connolly <caleb@connolly.tech>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	linux-arm-msm@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	dri-devel@lists.freedesktop.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	phone-devel@vger.kernel.org,
	Sumit Semwal <sumit.semwal@linaro.org>,
	linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 3/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel
Date: Tue, 19 Jul 2022 08:10:18 +0200	[thread overview]
Message-ID: <YtZKylMu4jEa/oDp@ravnborg.org> (raw)
In-Reply-To: <20220718213051.1475108-4-caleb@connolly.tech>

Hi Caleb,

On Mon, Jul 18, 2022 at 10:30:50PM +0100, Caleb Connolly wrote:
> From: Sumit Semwal <sumit.semwal@linaro.org>
> 
> LG SW43408 is 1080x2160, 4-lane MIPI-DSI panel.
A few things to improve to this binding.

	Sam
> 
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
> [caleb: convert to yaml]
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> ---
>  .../bindings/display/panel/lg,43408.yaml      | 41 +++++++++++++++++++
>  .../display/panel/panel-simple-dsi.yaml       |  2 +
>  2 files changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/lg,43408.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/lg,43408.yaml b/Documentation/devicetree/bindings/display/panel/lg,43408.yaml
> new file mode 100644
> index 000000000000..0529a3aa2692
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/lg,43408.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LG SW43408 1080x2160 DSI panel
> +
> +maintainers:
> +  - Caleb Connolly <caleb@connolly.tech>
> +
> +description: |
> +  This panel is used on the Pixel 3, it is a 60hz OLED panel which
> +  required DSC (Display Stream Compression) and has rounded corners.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: lg,sw43408
> +
> +  vddi-supply: true
> +  vpnl-supply: true
> +  reset-gpios: true
> +
> +  backlight: false
> +  power-supply: false
No need to say anything is false, this is covered by the statement below.
Also, the driver uses backlight, so it should be true?
> +
> +additionalProperties: false
> +
> +required:
> +  - compatible
> +  - data-mapping
> +  - width-mm
> +  - height-mm
> +  - panel-timing
> +  - port
> +
> +...
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index 2c00813f5d20..4498078cb1ee 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -45,6 +45,8 @@ properties:
>        - lg,acx467akm-7
>          # LG Corporation 7" WXGA TFT LCD panel
>        - lg,ld070wx3-sl01
> +        # LG Corporation sw43408 1080x2160 OLED
> +      - lg,sw43408
The panel uses three power-supplies, so it is not a "panel-simple"
binding. And we cannot have the same compatible twice, so this must be
dropped.

	Sam

  reply	other threads:[~2022-07-19  6:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 21:30 [PATCH 0/4] Initial support for the Pixel 3 Caleb Connolly
2022-07-18 21:30 ` [PATCH 1/4] Documentation: dt-bindings: arm: qcom: add google, blueline Caleb Connolly
2022-07-19  8:36   ` [PATCH 1/4] Documentation: dt-bindings: arm: qcom: add google,blueline Krzysztof Kozlowski
2022-07-18 21:30 ` [PATCH 2/4] arm64: dts: qcom: add sdm845-google-blueline (Pixel 3) Caleb Connolly
2022-07-18 22:13   ` Dmitry Baryshkov
2022-07-18 22:54     ` Caleb Connolly
2022-07-18 23:15       ` Dmitry Baryshkov
2022-07-27  8:47     ` Kalle Valo
2022-07-27 10:55     ` Amit Pundir
2022-07-19  8:45   ` Krzysztof Kozlowski
2022-07-18 21:30 ` [PATCH 3/4] dt-bindings: panel: Add LG SW43408 MIPI-DSI panel Caleb Connolly
2022-07-19  6:10   ` Sam Ravnborg [this message]
2022-07-19  7:57     ` Sam Ravnborg
2022-07-19 14:11   ` Rob Herring
2022-07-18 21:30 ` [PATCH 4/4] drm: panel: Add lg sw43408 panel driver Caleb Connolly
2022-07-18 23:06   ` Dmitry Baryshkov
2022-07-19  7:48   ` Sam Ravnborg
2022-10-01 21:48   ` Marijn Suijten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtZKylMu4jEa/oDp@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=agross@kernel.org \
    --cc=airlied@linux.ie \
    --cc=bjorn.andersson@linaro.org \
    --cc=caleb@connolly.tech \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=thierry.reding@gmail.com \
    --cc=vkoul@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).