From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: thomas.hellstrom@linux.intel.com, mchehab@kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
airlied@linux.ie, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk,
matthew.auld@intel.com, Andi Shyti <andi.shyti@linux.intel.com>,
Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>,
nirmoy.das@intel.com
Subject: Re: [Intel-gfx] [PATCH v5 1/7] drm: Move and add a few utility macros into drm util header
Date: Thu, 4 Aug 2022 11:06:52 +0200 [thread overview]
Message-ID: <YuuMLN4jDnCrE0hq@alfio.lan> (raw)
In-Reply-To: <875yj9qv62.fsf@intel.com>
Hi Jani,
> >> It moves overflows_type utility macro into drm util header from i915_utils
> >> header. The overflows_type can be used to catch the truncation between data
> >> types. And it adds safe_conversion() macro which performs a type conversion
> >> (cast) of an source value into a new variable, checking that the
> >> destination is large enough to hold the source value.
> >> And it adds exact_type and exactly_pgoff_t macro to catch type mis-match
> >> while compiling.
> >>
> >> v3: Add is_type_unsigned() macro (Mauro)
> >> Modify overflows_type() macro to consider signed data types (Mauro)
> >> Fix the problem that safe_conversion() macro always returns true
> >> v4: Fix kernel-doc markups
> >>
> >> Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> >> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> >> Cc: Matthew Auld <matthew.auld@intel.com>
> >> Cc: Nirmoy Das <nirmoy.das@intel.com>
> >> Cc: Jani Nikula <jani.nikula@intel.com>
> >> Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> >> ---
> >> drivers/gpu/drm/i915/i915_utils.h | 5 +-
> >> include/drm/drm_util.h | 77 +++++++++++++++++++++++++++++++
> >> 2 files changed, 78 insertions(+), 4 deletions(-)
> >
> > Jani and Mauro suggested to have this macro in
> > include/drm/drm_util.h.
>
> I can't recall suggesting such a thing. The macros in question have
> nothing specifically to do with i915 *or* drm. They are generic, and
> should be in generic kernel headers.
>
> We must stop piling up generic and generally useful stuff in our own
> headers.
Yes, I agree with you and I think there was already such
discussion whether to move this into generic kernel headers or in
drm header.
Gwan-gyeong, any thoughts or further plans to move this to a
different place? It's been already three people (and I'm
including myself here) recommending to have this in a different
place.
Andi
> I thought I've been clear about this all along.
Thanks, Jani!
Andi
next prev parent reply other threads:[~2022-08-04 9:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 9:25 [PATCH v5 0/7] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation Gwan-gyeong Mun
2022-07-25 9:25 ` [PATCH v5 1/7] drm: Move and add a few utility macros into drm util header Gwan-gyeong Mun
2022-07-25 11:36 ` [Intel-gfx] " Andrzej Hajda
2022-07-26 8:20 ` Gwan-gyeong Mun
2022-07-27 10:26 ` Andi Shyti
2022-08-03 14:05 ` Jani Nikula
2022-08-04 9:06 ` Andi Shyti [this message]
2022-08-09 8:31 ` Gwan-gyeong Mun
2022-07-25 9:25 ` [PATCH v5 2/7] drm/i915/gem: Typecheck page lookups Gwan-gyeong Mun
2022-07-25 11:50 ` [Intel-gfx] " Andrzej Hajda
2022-07-25 9:25 ` [PATCH v5 3/7] drm/i915: Check for integer truncation on scatterlist creation Gwan-gyeong Mun
2022-07-25 11:51 ` [Intel-gfx] " Andrzej Hajda
2022-07-25 9:25 ` [PATCH v5 4/7] drm/i915: Check for integer truncation on the configuration of ttm place Gwan-gyeong Mun
2022-07-25 11:53 ` [Intel-gfx] " Andrzej Hajda
2022-08-03 14:13 ` Jani Nikula
2022-07-25 9:25 ` [PATCH v5 5/7] drm/i915: Check if the size is too big while creating shmem file Gwan-gyeong Mun
2022-07-25 11:59 ` [Intel-gfx] " Andrzej Hajda
2022-07-25 9:25 ` [PATCH v5 6/7] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large Gwan-gyeong Mun
2022-07-25 12:01 ` [Intel-gfx] " Andrzej Hajda
2022-07-25 9:25 ` [PATCH v5 7/7] drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun
2022-07-25 12:02 ` [Intel-gfx] " Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuuMLN4jDnCrE0hq@alfio.lan \
--to=andi.shyti@linux.intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=gwan-gyeong.mun@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=matthew.auld@intel.com \
--cc=mchehab@kernel.org \
--cc=nirmoy.das@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).