From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: kernel@pengutronix.de, etnaviv@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, patchwork-lst@pengutronix.de
Subject: Re: [PATCH] drm/etnaviv: disable MLCG and pulse eater on GPU reset
Date: Wed, 14 Jun 2023 17:46:14 +0100 [thread overview]
Message-ID: <ZInu1lTjiV/UDPI2@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230607125841.3518385-1-l.stach@pengutronix.de>
On Wed, Jun 07, 2023 at 02:58:41PM +0200, Lucas Stach wrote:
> Module level clock gating and the pulse eater might interfere with
> the GPU reset, as they both have the potential to stop the clock
> and thus reset propagation to parts of the GPU.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> I'm not aware of any cases where this would have been an issue, but
> it is what the downstream driver does and fundametally seems like
> the right thing to do.
Maybe Dove, where the PLLs generating the clock to the GPU can be
changed, iirc?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2023-06-14 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 12:58 [PATCH] drm/etnaviv: disable MLCG and pulse eater on GPU reset Lucas Stach
2023-06-13 13:30 ` Christian Gmeiner
2023-06-13 16:42 ` Sui Jingfeng
2023-06-14 7:45 ` Lucas Stach
2023-06-14 17:49 ` Sui Jingfeng
2023-06-15 9:14 ` Lucas Stach
2023-06-15 9:22 ` Sui Jingfeng
2023-06-14 16:46 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZInu1lTjiV/UDPI2@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).