* [PATCH 0/1] Fix the port mux of VP2
@ 2024-04-22 10:19 Andy Yan
2024-04-22 10:19 ` [PATCH 1/1] drm/rockchip: vop2: " Andy Yan
2024-04-25 15:19 ` [PATCH 0/1] " Heiko Stuebner
0 siblings, 2 replies; 5+ messages in thread
From: Andy Yan @ 2024-04-22 10:19 UTC (permalink / raw)
To: heiko
Cc: tzimmermann, mripard, hjc, s.hauer, linux-arm-kernel,
linux-kernel, dri-devel, linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
The port mux bits of VP2 should be defined by RK3568_OVL_PORT_SET__PORT2_MUX,
this maybe a copy and paste error when this driver first introduced.
Hi Heiko:
Maybe thi is the problem you met when you porting the dsi2 driver.
I previously sent you this patch when you ask me about this issue on
email,but I'm not sure if you received it.
Andy Yan (1):
drm/rockchip: vop2: Fix the port mux of VP2
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] drm/rockchip: vop2: Fix the port mux of VP2
2024-04-22 10:19 [PATCH 0/1] Fix the port mux of VP2 Andy Yan
@ 2024-04-22 10:19 ` Andy Yan
2024-04-22 12:34 ` Sascha Hauer
2024-04-25 14:51 ` Heiko Stübner
2024-04-25 15:19 ` [PATCH 0/1] " Heiko Stuebner
1 sibling, 2 replies; 5+ messages in thread
From: Andy Yan @ 2024-04-22 10:19 UTC (permalink / raw)
To: heiko
Cc: tzimmermann, mripard, hjc, s.hauer, linux-arm-kernel,
linux-kernel, dri-devel, linux-rockchip, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
The port mux of VP2 should be RK3568_OVL_PORT_SET__PORT2_MUX.
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 97b0ab4b6db8..1f4250de570f 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -2377,7 +2377,7 @@ static void vop2_setup_layer_mixer(struct vop2_video_port *vp)
port_sel |= FIELD_PREP(RK3568_OVL_PORT_SET__PORT2_MUX,
(vp2->nlayers + vp1->nlayers + vp0->nlayers - 1));
else
- port_sel |= FIELD_PREP(RK3568_OVL_PORT_SET__PORT1_MUX, 8);
+ port_sel |= FIELD_PREP(RK3568_OVL_PORT_SET__PORT2_MUX, 8);
layer_sel = vop2_readl(vop2, RK3568_OVL_LAYER_SEL);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] drm/rockchip: vop2: Fix the port mux of VP2
2024-04-22 10:19 ` [PATCH 1/1] drm/rockchip: vop2: " Andy Yan
@ 2024-04-22 12:34 ` Sascha Hauer
2024-04-25 14:51 ` Heiko Stübner
1 sibling, 0 replies; 5+ messages in thread
From: Sascha Hauer @ 2024-04-22 12:34 UTC (permalink / raw)
To: Andy Yan
Cc: heiko, tzimmermann, mripard, hjc, linux-arm-kernel, linux-kernel,
dri-devel, linux-rockchip, Andy Yan
On Mon, Apr 22, 2024 at 06:19:05PM +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> The port mux of VP2 should be RK3568_OVL_PORT_SET__PORT2_MUX.
>
> Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
>
> ---
>
> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> index 97b0ab4b6db8..1f4250de570f 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
> @@ -2377,7 +2377,7 @@ static void vop2_setup_layer_mixer(struct vop2_video_port *vp)
> port_sel |= FIELD_PREP(RK3568_OVL_PORT_SET__PORT2_MUX,
> (vp2->nlayers + vp1->nlayers + vp0->nlayers - 1));
> else
> - port_sel |= FIELD_PREP(RK3568_OVL_PORT_SET__PORT1_MUX, 8);
> + port_sel |= FIELD_PREP(RK3568_OVL_PORT_SET__PORT2_MUX, 8);
>
> layer_sel = vop2_readl(vop2, RK3568_OVL_LAYER_SEL);
>
> --
> 2.34.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] drm/rockchip: vop2: Fix the port mux of VP2
2024-04-22 10:19 ` [PATCH 1/1] drm/rockchip: vop2: " Andy Yan
2024-04-22 12:34 ` Sascha Hauer
@ 2024-04-25 14:51 ` Heiko Stübner
1 sibling, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2024-04-25 14:51 UTC (permalink / raw)
To: Andy Yan
Cc: tzimmermann, mripard, hjc, s.hauer, linux-arm-kernel,
linux-kernel, dri-devel, linux-rockchip, Andy Yan
Am Montag, 22. April 2024, 12:19:05 CEST schrieb Andy Yan:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> The port mux of VP2 should be RK3568_OVL_PORT_SET__PORT2_MUX.
>
> Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
on a rk3588 with VP3 connected to a DSI display
Tested-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/1] Fix the port mux of VP2
2024-04-22 10:19 [PATCH 0/1] Fix the port mux of VP2 Andy Yan
2024-04-22 10:19 ` [PATCH 1/1] drm/rockchip: vop2: " Andy Yan
@ 2024-04-25 15:19 ` Heiko Stuebner
1 sibling, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2024-04-25 15:19 UTC (permalink / raw)
To: Andy Yan
Cc: Heiko Stuebner, mripard, linux-arm-kernel, linux-kernel,
linux-rockchip, hjc, tzimmermann, dri-devel, s.hauer, Andy Yan
On Mon, 22 Apr 2024 18:19:04 +0800, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
>
> The port mux bits of VP2 should be defined by RK3568_OVL_PORT_SET__PORT2_MUX,
> this maybe a copy and paste error when this driver first introduced.
> Hi Heiko:
> Maybe thi is the problem you met when you porting the dsi2 driver.
> I previously sent you this patch when you ask me about this issue on
> email,but I'm not sure if you received it.
>
> [...]
Applied, thanks!
[1/1] drm/rockchip: vop2: Fix the port mux of VP2
commit: 2bdb481bf7a93c22b9fea8daefa2834aab23a70f
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-04-25 15:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-22 10:19 [PATCH 0/1] Fix the port mux of VP2 Andy Yan
2024-04-22 10:19 ` [PATCH 1/1] drm/rockchip: vop2: " Andy Yan
2024-04-22 12:34 ` Sascha Hauer
2024-04-25 14:51 ` Heiko Stübner
2024-04-25 15:19 ` [PATCH 0/1] " Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).