[PATCH v1 1/1] drm: fixed: Don't use "proxy" headers

[PATCH v1 1/1] drm: fixed: Don't use "proxy" headers

[Andy Shevchenko]

Update header inclusions to follow IWYU (Include What You Use)
principle.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/drm/drm_fixed.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h
index 81572d32db0c..387fb81d5b81 100644
--- a/include/drm/drm_fixed.h
+++ b/include/drm/drm_fixed.h
@@ -25,8 +25,9 @@
 #ifndef DRM_FIXED_H
 #define DRM_FIXED_H
 
-#include <linux/kernel.h>
 #include <linux/math64.h>
+#include <linux/types.h>
+#include <linux/wordpart.h>
 
 typedef union dfixed {
 	u32 full;
-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers

[Jani Nikula]

On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Assuming it builds, and nothing depends on other stuff from kernel.h via
drm_fixed.h,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  include/drm/drm_fixed.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h
> index 81572d32db0c..387fb81d5b81 100644
> --- a/include/drm/drm_fixed.h
> +++ b/include/drm/drm_fixed.h
> @@ -25,8 +25,9 @@
>  #ifndef DRM_FIXED_H
>  #define DRM_FIXED_H
>  
> -#include <linux/kernel.h>
>  #include <linux/math64.h>
> +#include <linux/types.h>
> +#include <linux/wordpart.h>
>  
>  typedef union dfixed {
>  	u32 full;

-- 
Jani Nikula, Intel

Re: [PATCH v1 1/1] drm: fixed: Don't use "proxy" headers

[Andy Shevchenko]

On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote:
> On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Assuming it builds, and nothing depends on other stuff from kernel.h via
> drm_fixed.h,

For the record, I have built-tested this via `make allyesconfig` on x86_64.

> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Thank you!

-- 
With Best Regards,
Andy Shevchenko