* [PATCH] drm/qxl: lost qxl_bo_kunmap_atomic_page in qxl_image_init_helper()
@ 2020-04-27 7:55 Vasily Averin
2020-04-28 10:08 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Vasily Averin @ 2020-04-27 7:55 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann
Cc: David Airlie, spice-devel, dri-devel, virtualization
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
drivers/gpu/drm/qxl/qxl_image.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/qxl/qxl_image.c b/drivers/gpu/drm/qxl/qxl_image.c
index 43688ecdd8a0..7270da62fc29 100644
--- a/drivers/gpu/drm/qxl/qxl_image.c
+++ b/drivers/gpu/drm/qxl/qxl_image.c
@@ -212,6 +212,7 @@ qxl_image_init_helper(struct qxl_device *qdev,
break;
default:
DRM_ERROR("unsupported image bit depth\n");
+ qxl_bo_kunmap_atomic_page(qdev, image_bo, ptr);
return -EINVAL; /* TODO: cleanup */
}
image->u.bitmap.flags = QXL_BITMAP_TOP_DOWN;
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/qxl: lost qxl_bo_kunmap_atomic_page in qxl_image_init_helper()
2020-04-27 7:55 [PATCH] drm/qxl: lost qxl_bo_kunmap_atomic_page in qxl_image_init_helper() Vasily Averin
@ 2020-04-28 10:08 ` Gerd Hoffmann
2020-04-29 9:34 ` [PATCH v2] " Vasily Averin
0 siblings, 1 reply; 3+ messages in thread
From: Gerd Hoffmann @ 2020-04-28 10:08 UTC (permalink / raw)
To: Vasily Averin
Cc: David Airlie, dri-devel, virtualization, spice-devel, Dave Airlie
On Mon, Apr 27, 2020 at 10:55:27AM +0300, Vasily Averin wrote:
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> ---
> drivers/gpu/drm/qxl/qxl_image.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_image.c b/drivers/gpu/drm/qxl/qxl_image.c
> index 43688ecdd8a0..7270da62fc29 100644
> --- a/drivers/gpu/drm/qxl/qxl_image.c
> +++ b/drivers/gpu/drm/qxl/qxl_image.c
> @@ -212,6 +212,7 @@ qxl_image_init_helper(struct qxl_device *qdev,
> break;
> default:
> DRM_ERROR("unsupported image bit depth\n");
> + qxl_bo_kunmap_atomic_page(qdev, image_bo, ptr);
> return -EINVAL; /* TODO: cleanup */
I guess you can ditch the TODO comment now, it's done ;)
take care,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] drm/qxl: lost qxl_bo_kunmap_atomic_page in qxl_image_init_helper()
2020-04-28 10:08 ` Gerd Hoffmann
@ 2020-04-29 9:34 ` Vasily Averin
0 siblings, 0 replies; 3+ messages in thread
From: Vasily Averin @ 2020-04-29 9:34 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann
Cc: David Airlie, spice-devel, dri-devel, virtualization
v2: removed TODO reminder
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
drivers/gpu/drm/qxl/qxl_image.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_image.c b/drivers/gpu/drm/qxl/qxl_image.c
index 43688ecdd8a0..60ab7151b84d 100644
--- a/drivers/gpu/drm/qxl/qxl_image.c
+++ b/drivers/gpu/drm/qxl/qxl_image.c
@@ -212,7 +212,8 @@ qxl_image_init_helper(struct qxl_device *qdev,
break;
default:
DRM_ERROR("unsupported image bit depth\n");
- return -EINVAL; /* TODO: cleanup */
+ qxl_bo_kunmap_atomic_page(qdev, image_bo, ptr);
+ return -EINVAL;
}
image->u.bitmap.flags = QXL_BITMAP_TOP_DOWN;
image->u.bitmap.x = width;
--
2.17.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-30 7:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 7:55 [PATCH] drm/qxl: lost qxl_bo_kunmap_atomic_page in qxl_image_init_helper() Vasily Averin
2020-04-28 10:08 ` Gerd Hoffmann
2020-04-29 9:34 ` [PATCH v2] " Vasily Averin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).