From: "Christian König" <christian.koenig@amd.com>
To: Nirmoy <nirmodas@amd.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RFC PATCH 2/6] drm/radeon: don't use ttm bo->offset
Date: Fri, 14 Feb 2020 15:12:40 +0100 [thread overview]
Message-ID: <aa948297-bee0-0e58-ec68-b9cf1fdda225@amd.com> (raw)
In-Reply-To: <70b9b568-92f3-a257-4011-3a68f3b31a6c@amd.com>
Am 13.02.20 um 14:28 schrieb Nirmoy:
>
> On 2/13/20 2:00 PM, Christian König wrote:
>> Am 13.02.20 um 13:31 schrieb Nirmoy:
>>>
>>> On 2/13/20 1:18 PM, Christian König wrote:
>>>> Looks like most of the patch is missing?
>>>>
>>>> We should have quite a number of uses of the BO offset in radeon or
>>>> do all of those go through radeon_bo_gpu_offset?
>>> Compilation worked so I think all those(bo->offset) accesses went
>>> through radeon_bo_gpu_offset.
>>
>> Cool, than that is a lot easier to implement than I thought it would be.
>>
>> I assume you don't have Radeon hardware lying around to test this?
>>
>> If you can you give me a branch on the AMD (or public) servers I can
>> give it at least a quick round of testing.
>
> huh it seems I have to rebase it a bit for drm/drm-next as it is based
> on our internal branch :/
>
> You can access the branch at
> http://gitlab1.amd.com/nirmodas/linux/tree/ttm_clean.1
>
> I will rebase this for drm-next in next version of the patch series.
Actually you should probably base it on drm-misc-next instead.
And additional to the already noted VRAM helpers the bochs driver fails
to compile on your branch.
The good news is that my old HD5670 still works with the radeon patch
applied. So this patch is Reviewed-and-tested-by: Christian König
<christian.koenig@amd.com>.
Regards,
Christian.
>
>>
>> Christian.
>>
>>>>
>>>> If yes then the change is much smaller than I thought i needs to be.
>>>>
>>>> Christian.
>>>>
>>> Regards,
>>>
>>> Nirmoy
>>>
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@lists.freedesktop.org
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7CNirmoy.Das%40amd.com%7C60aa17c05a2f474663f008d7b084b550%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637171956342728389&sdata=I2n0yMXK5CtrG5tY9Q47igxJv9Onb%2FA7PBeLwrpPb54%3D&reserved=0
>>>
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-14 14:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 12:01 [RFC PATCH 0/6] do not store GPU address in TTM Nirmoy Das
2020-02-13 12:01 ` [RFC PATCH 1/6] drm/amdgpu: move ttm bo->offset to amdgpu_bo Nirmoy Das
2020-02-13 12:01 ` [RFC PATCH 2/6] drm/radeon: don't use ttm bo->offset Nirmoy Das
2020-02-13 12:18 ` Christian König
2020-02-13 12:31 ` Nirmoy
2020-02-13 13:00 ` Christian König
2020-02-13 13:28 ` Nirmoy
2020-02-14 14:12 ` Christian König [this message]
2020-02-13 13:30 ` Nirmoy
2020-02-13 12:02 ` [RFC PATCH 3/6] drm/vmwgfx: " Nirmoy Das
2020-02-13 12:02 ` [RFC PATCH 4/6] drm/nouveau: " Nirmoy Das
2020-02-13 12:02 ` [RFC PATCH 5/6] drm/qxl: " Nirmoy Das
2020-02-13 14:30 ` Gerd Hoffmann
2020-02-13 14:52 ` Nirmoy
2020-02-14 9:08 ` Gerd Hoffmann
2020-02-14 11:55 ` Nirmoy
2020-02-13 17:26 ` Christian König
2020-02-13 12:02 ` [RFC PATCH 6/6] drm/ttm: do not keep GPU dependent addresses Nirmoy Das
2020-02-13 12:19 ` [RFC PATCH 0/6] do not store GPU address in TTM Christian König
2020-02-13 14:35 ` Huang Rui
2020-02-14 9:19 ` Thomas Zimmermann
2020-02-14 10:29 ` Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa948297-bee0-0e58-ec68-b9cf1fdda225@amd.com \
--to=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=nirmodas@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).