Re: [PATCH v1 26/36] dt-bindings: display: convert sony, acx565akm to DT Schema

From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Sam Ravnborg <sam@ravnborg.org>,
	<dri-devel@lists.freedesktop.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Rob Herring <robh@kernel.org>, <devicetree@vger.kernel.org>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	Nikolaus Schaller <hns@goldelico.com>,
	Jonathan Bakker <xc-racer2@live.ca>,
	Sandeep Panda <spanda@codeaurora.org>,
	Paul Cercueil <paul@crapouillou.net>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Chris Zhong <zyw@rock-chips.com>,
	Marco Franchi <marco.franchi@nxp.com>,
	Stefan Mavrodiev <stefan@olimex.com>,
	Jerry Han <hanxu5@huaqin.corp-partner.google.com>,
	Hoegeun Kwon <hoegeun.kwon@samsung.com>,
	Tony Lindgren <tony@atomide.com>,
	Nickey Yang <nickey.yang@rock-chips.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Robert Chiras <robert.chiras@nxp.com>,
	Vinay Simha BN <simhavcs@gmail.com>,
	Marek Belisko <marek@goldelico.com>, Heiko Schocher <hs@denx.de>,
	Brian Masney <masneyb@onstation.org>,
	Guido Gunther <agx@sigxcpu.org>, Mark Brown <broonie@kernel.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Werner Johansson <werner.johansson@sonymobile.com>,
	Purism Kernel Team <kernel@puri.sm>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Lin Huang <hl@rock-chips.com>,
	Douglas Anderson <dianders@chromium.org>,
	linux-spi@vger.kernel.org, Peter Rosin <peda@axentia.se>
Subject: Re: [PATCH v1 26/36] dt-bindings: display: convert sony, acx565akm to DT Schema
Date: Tue, 17 Mar 2020 08:23:47 +0200	[thread overview]
Message-ID: <b2cdb376-c283-fe06-14f3-a9e1a3ee3f4c@ti.com> (raw)
In-Reply-To: <20200315134416.16527-27-sam@ravnborg.org>

On 15/03/2020 15:44, Sam Ravnborg wrote:
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
>   .../bindings/display/panel/sony,acx565akm.txt | 30 -----------
>   .../display/panel/sony,acx565akm.yaml         | 53 +++++++++++++++++++
>   2 files changed, 53 insertions(+), 30 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/display/panel/sony,acx565akm.txt
>   create mode 100644 Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/sony,acx565akm.txt b/Documentation/devicetree/bindings/display/panel/sony,acx565akm.txt
> deleted file mode 100644
> index e12333280749..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/sony,acx565akm.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -Sony ACX565AKM SDI Panel
> -========================
> -
> -Required properties:
> -- compatible: "sony,acx565akm"
> -
> -Optional properties:
> -- label: a symbolic name for the panel
> -- reset-gpios: panel reset gpio
> -
> -Required nodes:
> -- Video port for SDI input
> -
> -Example
> --------
> -
> -acx565akm@2 {
> -	compatible = "sony,acx565akm";
> -	spi-max-frequency = <6000000>;
> -	reg = <2>;
> -
> -	label = "lcd";
> -	reset-gpios = <&gpio3 26 GPIO_ACTIVE_HIGH>; /* 90 */
> -
> -	port {
> -		lcd_in: endpoint {
> -			remote-endpoint = <&sdi_out>;
> -		};
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml b/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml
> new file mode 100644
> index 000000000000..a0b1abb9f33d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/sony,acx565akm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony ACX565AKM SDI Panel
> +
> +maintainers:
> +  - Tomi Valkeinen <tomi.valkeinen@ti.com>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +  - $ref: ../../spi/spi-slave.yaml#
> +
> +properties:
> +  compatible:
> +    const: sony,acx565akm
> +
> +  label: true
> +  reset-gpios: true
> +  port: true
> +
> +required:
> +  - compatible
> +  - port
> +
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        acx565akm@2 {
> +            compatible = "sony,acx565akm";
> +            spi-max-frequency = <6000000>;
> +            reg = <2>;
> +
> +            label = "lcd";
> +            reset-gpios = <&gpio3 26 GPIO_ACTIVE_HIGH>; /* 90 */
> +
> +            port {
> +                lcd_in: endpoint {
> +                    remote-endpoint = <&sdi_out>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> 

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel