* [PATCH] video: fbdev: pvr2fb: fix build warning when compiling as module
[not found] <CGME20190614104355eucas1p236ecb70b6d48f37508f3837cee49b19f@eucas1p2.samsung.com>
@ 2019-06-14 10:43 ` Bartlomiej Zolnierkiewicz
[not found] ` <CGME20190621110647eucas1p2d7b803b54304d653e5755677d28e3117@eucas1p2.samsung.com>
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-06-14 10:43 UTC (permalink / raw)
To: linux-fbdev, dri-devel, linux-kernel; +Cc: Stephen Rothwell
Add missing #ifndef MODULE around pvr2_get_param_val().
Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/video/fbdev/pvr2fb.c | 2 ++
1 file changed, 2 insertions(+)
Index: b/drivers/video/fbdev/pvr2fb.c
===================================================================
--- a/drivers/video/fbdev/pvr2fb.c
+++ b/drivers/video/fbdev/pvr2fb.c
@@ -722,6 +722,7 @@ static struct fb_ops pvr2fb_ops = {
.fb_imageblit = cfb_imageblit,
};
+#ifndef MODULE
static int pvr2_get_param_val(const struct pvr2_params *p, const char *s,
int size)
{
@@ -733,6 +734,7 @@ static int pvr2_get_param_val(const stru
}
return -1;
}
+#endif
static char *pvr2_get_param_name(const struct pvr2_params *p, int val,
int size)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] video: fbdev: pvr2fb: fix build warning when compiling as module
[not found] ` <CGME20190621110647eucas1p2d7b803b54304d653e5755677d28e3117@eucas1p2.samsung.com>
@ 2019-06-21 11:06 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-06-21 11:06 UTC (permalink / raw)
To: linux-fbdev, dri-devel, linux-kernel; +Cc: Stephen Rothwell
On 6/14/19 12:43 PM, Bartlomiej Zolnierkiewicz wrote:
> Add missing #ifndef MODULE around pvr2_get_param_val().
>
> Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
I queued the patch for v5.3.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-21 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190614104355eucas1p236ecb70b6d48f37508f3837cee49b19f@eucas1p2.samsung.com>
2019-06-14 10:43 ` [PATCH] video: fbdev: pvr2fb: fix build warning when compiling as module Bartlomiej Zolnierkiewicz
[not found] ` <CGME20190621110647eucas1p2d7b803b54304d653e5755677d28e3117@eucas1p2.samsung.com>
2019-06-21 11:06 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).