* [Bug 109977] Segmentation fault in drmParsePlatformDeviceInfo
@ 2019-03-12 11:22 bugzilla-daemon
2019-03-12 12:56 ` bugzilla-daemon
0 siblings, 1 reply; 2+ messages in thread
From: bugzilla-daemon @ 2019-03-12 11:22 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1442 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=109977
Bug ID: 109977
Summary: Segmentation fault in drmParsePlatformDeviceInfo
Product: DRI
Version: XOrg git
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: medium
Component: libdrm
Assignee: dri-devel@lists.freedesktop.org
Reporter: ichgeh@imkreisrum.de
Created attachment 143633
--> https://bugs.freedesktop.org/attachment.cgi?id=143633&action=edit
[PATCH libdrm] xf86drm: Fix segmentation fault while parsing device info
Since commit ee798b98479709acdd8d1492689dc93c1a62f239 (xf85drm: de-duplicate
drmParse{Platform.Host1x}{Bus,Device}Info)
I encounter a segfault at line 3632:
*compatible[i] = tmp_name;
Libdrm segfaults as soon as i>0.
This was encountered on armhf platform (Allwinner A10) with kernel 5.0
including drm-misc-next and the lima driver
(https://gitlab.freedesktop.org/lima/linux/commits/lima-drm-misc-next-20190309)
and the lima mesa branch (https://gitlab.freedesktop.org/lima/mesa) while
running glmark2-es2-drm and kmscube.
You can see the original issue including backtrace and strace reported here:
https://gitlab.freedesktop.org/lima/mesa/issues/80#note_129271
The attached patch fixes it.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 3203 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug 109977] Segmentation fault in drmParsePlatformDeviceInfo
2019-03-12 11:22 [Bug 109977] Segmentation fault in drmParsePlatformDeviceInfo bugzilla-daemon
@ 2019-03-12 12:56 ` bugzilla-daemon
0 siblings, 0 replies; 2+ messages in thread
From: bugzilla-daemon @ 2019-03-12 12:56 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1481 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=109977
Eric Engestrom <fdo-bugs@engestrom.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
CC| |emil.l.velikov@gmail.com
--- Comment #1 from Eric Engestrom <fdo-bugs@engestrom.ch> ---
Thanks!
Your fix is correct, although partial: the same bug appears again in the free()
a couple lines below.
I've added it as part of your patch and pushed it:
commit 4735ca71af9f741e2438104d543dc3c5a8107f35
Author: Andreas Baierl <ichgeh@imkreisrum.de>
Date: Mon Mar 11 16:04:08 2019 +0100
xf86drm: Fix segmentation fault while parsing device info
This fixes a bug, which was introduced with commit ee798b98
"xf85drm: de-duplicate drmParse{Platform.Host1x}{Bus,Device}Info".
where accessing *compatible[i] with i>0 results in a segfault.
Signed-off-by: Andreas Baierl <ichgeh@imkreisrum.de>
Fixes: ee798b98479709acdd8d "xf85drm: de-duplicate
drmParse{Platform.Host1x}{Bus,Device}Info"
Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
[Eric: add the same fix to the free() below]
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 3370 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-12 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12 11:22 [Bug 109977] Segmentation fault in drmParsePlatformDeviceInfo bugzilla-daemon
2019-03-12 12:56 ` bugzilla-daemon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).