[Bug 110257] Major artifacts in mpeg2 vaapi hw decoding

[Bug 110257] Major artifacts in mpeg2 vaapi hw decoding

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 2102 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110257

            Bug ID: 110257
           Summary: Major artifacts in mpeg2 vaapi hw decoding
           Product: Mesa
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: 67b0226d@casix.org
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 143787
  --> https://bugs.freedesktop.org/attachment.cgi?id=143787&action=edit
hardware-decoded screenshot

Hi,

on latest Mesa I still get tons of artifacts when decoding MPEG2 on my AMD card
via VAAPI, to the point where it is not usable for video decoding at all to be
honest.
I've attached sample screenshots to show the problem - one software-decoded and
one hardware-decoded via libva in mpv.
The sample video is taken from https://www.w6rz.net/1080p25.zip but the
artifacts are visible more or less on any MPEG2 video including DVDs.

There is this older bug report:
https://bugs.freedesktop.org/show_bug.cgi?id=93760 but I'm not sure it's
related because I do not get any assertion failure and it vaguely reads like it
has been fixed?

For clarification, I see no artifacts with VDPAU.

Tested with Mesa-19.1.0-devel (git-bea540173c), libva 2.5.0-pre1
(git-c98b06d2b8), FFmpeg N-93467-g54655623a8
VAAPI driver string: Mesa Gallium driver 19.1.0-devel for Radeon RX 580 Series
(POLARIS10, DRM 3.27.0, 4.20.13-arch1-1-ARCH, LLVM 7.0.1)

I verified this with mpv, gstreamer and Kodi.
mpv seems to have disabled mpeg2 hw decoding by default due to this problem:
https://github.com/mpv-player/mpv/commit/3dd59dbe
In Kodi we cannot go this route because we want to support low-end hardware
that might have trouble decoding 1080p in software out-of-the-box.
I want to avoid having to blacklist the radeon vaapi driver for mpeg2 if
possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3888 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110257] Major artifacts in mpeg2 vaapi hw decoding

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110257

--- Comment #1 from 67b0226d@casix.org ---
Created attachment 143788
  --> https://bugs.freedesktop.org/attachment.cgi?id=143788&action=edit
software-decoded screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1199 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110257] Major artifacts in mpeg2 vaapi hw decoding

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 352 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110257

67b0226d@casix.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |git

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1020 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110257] Major artifacts in mpeg2 vaapi hw decoding

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 863 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110257

--- Comment #2 from Andrew Randrianasulu <randrik@mail.ru> ---
wasn't this fixed by
https://cgit.freedesktop.org/mesa/mesa/commit/?id=d507bcdcf26b417dea201090165af651253b6b11 

----------
st/va: reverse qt matrix back to its original order
The quantiser matrix that VAAPI provides has been applied with inverse z-scan.
However, what we expect in MPEG2 picture description is the original order.
Therefore, we need to reverse it back to its original order.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110257
Cc: mesa-stable@lists.freedesktop.org
----------

I can only test with Cinelerra-GG, and my nv92 crad decodes 1080p25 mpeg2 very
slowly (video decoder clock problem) - but for me images were ok!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1953 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110257] Major artifacts in mpeg2 vaapi hw decoding

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 687 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110257

67b0226d@casix.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from 67b0226d@casix.org ---
Yes indeed, this bug is even listed in the 19.0.2 release notes. It was
probably just forgotten to comment here. Anyhow, thanks Boyuan Zhang for the
fix, works perfectly fine now with mesa 19.0.3 installed from normal repos!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2122 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel