[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1358 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91444

            Bug ID: 91444
           Summary: regression bisected radeonsi: don't change
                    pipe_resource in resource_copy_region
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: shawn.starr@rogers.com
        QA Contact: dri-devel@lists.freedesktop.org

While playing ARK: Survival Evolved, I ran into image corruption and can
reproduce it easy in game, it came down to this commit:

commit 46b2b3bda8d962fce02838e09c742ac06fbec45f
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Thu Jul 16 13:17:14 2015 +0200

    radeonsi: don't change pipe_resource in resource_copy_region

    Copied from r600g. pipe_resource can be shared by multiple threads, so we
    shouldn't change it.

    Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>


Reverting this fixed corruption seen, I've attached a picture of the corruption
noticed, but it manifests itself in striped transparency of certain objects.

See attachment of image

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2859 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 354 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91444

--- Comment #1 from Shawn Starr <shawn.starr@rogers.com> ---
Created attachment 117328
  --> https://bugs.freedesktop.org/attachment.cgi?id=117328&action=edit
ARK: Survival Evolved corruption

ARK: Survival Evolved corruption

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1340 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91444

Shawn Starr <shawn.starr@rogers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117328|0                           |1
        is obsolete|                            |
 Attachment #117328|text/plain                  |image/jpeg
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1296 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 408 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91444

Shawn Starr <shawn.starr@rogers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #117328|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1105 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 237 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91444

--- Comment #2 from Shawn Starr <shawn.starr@rogers.com> ---
This is for BONAIRE (Saturn XT [FirePro M6100])

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1066 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 284 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91444

--- Comment #3 from Marek Olšák <maraeo@gmail.com> ---
Could you please create and attach (or send a link to) an apitrace reproducing
the issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1129 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 293 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91444

--- Comment #4 from Shawn Starr <shawn.starr@rogers.com> ---
Here is the apitrace, decompress with XZ-
https://drive.google.com/open?id=0Bze7CJKD12nOYkhrdlZERXBKMDA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 460 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91444

--- Comment #5 from Shawn Starr <shawn.starr@rogers.com> ---
http://www.sh0n.net/spstarr/radeon/player-stat-glyph-corrupt.png - Copy region
OK
http://www.sh0n.net/spstarr/radeon/player-stat-glyph-region-corrupt.png - Copy
region corruption

There is glyph corruption but this pre-dates this issue and will be a separate
bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1454 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 349 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91444

--- Comment #6 from Shawn Starr <shawn.starr@rogers.com> ---
Marek's has fixed this in
http://cgit.freedesktop.org/~mareko/mesa/commit/?id=21f4eb11d76d45c8b4099e0df36d1263901c39a2

This has been tested, works for me now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1285 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 91444] regression bisected radeonsi: don't change pipe_resource in resource_copy_region

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 719 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=91444

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Marek Olšák <maraeo@gmail.com> ---
(In reply to Shawn Starr from comment #6)
> Marek's has fixed this in
> http://cgit.freedesktop.org/~mareko/mesa/commit/
> ?id=21f4eb11d76d45c8b4099e0df36d1263901c39a2
> 
> This has been tested, works for me now.

Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2457 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel