* [PATCH] drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy
@ 2022-01-11 13:26 Thomas Zimmermann
2022-01-11 13:32 ` Noralf Trønnes
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Zimmermann @ 2022-01-11 13:26 UTC (permalink / raw)
To: noralf, maarten.lankhorst, mripard, airlied, daniel
Cc: Daniel Vetter, Thomas Zimmermann, dri-devel
Set the source-buffer address after mapping the buffer into the
kernel's address space. Makes MIPI DBI helpers work again.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: c47160d8edcd ("drm/mipi-dbi: Remove dependency on GEM CMA helper library")
Reported-by: Noralf Trønnes <noralf@tronnes.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
---
drivers/gpu/drm/drm_mipi_dbi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mipi_dbi.c b/drivers/gpu/drm/drm_mipi_dbi.c
index ded8968b3e8a..0327d595e028 100644
--- a/drivers/gpu/drm/drm_mipi_dbi.c
+++ b/drivers/gpu/drm/drm_mipi_dbi.c
@@ -209,11 +209,11 @@ int mipi_dbi_buf_copy(void *dst, struct drm_framebuffer *fb,
ret = drm_gem_fb_begin_cpu_access(fb, DMA_FROM_DEVICE);
if (ret)
return ret;
- src = data[0].vaddr; /* TODO: Use mapping abstraction properly */
ret = drm_gem_fb_vmap(fb, map, data);
if (ret)
goto out_drm_gem_fb_end_cpu_access;
+ src = data[0].vaddr; /* TODO: Use mapping abstraction properly */
switch (fb->format->format) {
case DRM_FORMAT_RGB565:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy
2022-01-11 13:26 [PATCH] drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy Thomas Zimmermann
@ 2022-01-11 13:32 ` Noralf Trønnes
2022-01-12 9:27 ` Thomas Zimmermann
0 siblings, 1 reply; 3+ messages in thread
From: Noralf Trønnes @ 2022-01-11 13:32 UTC (permalink / raw)
To: Thomas Zimmermann, maarten.lankhorst, mripard, airlied, daniel
Cc: Daniel Vetter, dri-devel
Den 11.01.2022 14.26, skrev Thomas Zimmermann:
> Set the source-buffer address after mapping the buffer into the
> kernel's address space. Makes MIPI DBI helpers work again.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: c47160d8edcd ("drm/mipi-dbi: Remove dependency on GEM CMA helper library")
> Reported-by: Noralf Trønnes <noralf@tronnes.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> ---
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy
2022-01-11 13:32 ` Noralf Trønnes
@ 2022-01-12 9:27 ` Thomas Zimmermann
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2022-01-12 9:27 UTC (permalink / raw)
To: Noralf Trønnes, maarten.lankhorst, mripard, airlied, daniel
Cc: Daniel Vetter, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 953 bytes --]
Hi
Am 11.01.22 um 14:32 schrieb Noralf Trønnes:
>
>
> Den 11.01.2022 14.26, skrev Thomas Zimmermann:
>> Set the source-buffer address after mapping the buffer into the
>> kernel's address space. Makes MIPI DBI helpers work again.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Fixes: c47160d8edcd ("drm/mipi-dbi: Remove dependency on GEM CMA helper library")
>> Reported-by: Noralf Trønnes <noralf@tronnes.org>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> ---
>
> Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Merged into drm-misc-next.
Best regards
Thomas
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-12 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11 13:26 [PATCH] drm/mipi-dbi: Fix source-buffer address in mipi_dbi_buf_copy Thomas Zimmermann
2022-01-11 13:32 ` Noralf Trønnes
2022-01-12 9:27 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).