dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: display: adi,adv75xx: Document #sound-dai-cells
@ 2023-12-06  1:28 Fabio Estevam
  2023-12-06  2:43 ` [PATCH] dt-bindings: display: adi, adv75xx: " Adam Ford
  2023-12-06  8:57 ` [PATCH] dt-bindings: display: adi,adv75xx: " Krzysztof Kozlowski
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2023-12-06  1:28 UTC (permalink / raw)
  To: Laurent.pinchart
  Cc: devicetree, conor+dt, Fabio Estevam, dri-devel, robh+dt,
	krzysztof.kozlowski+dt, aford173

From: Fabio Estevam <festevam@denx.de>

When using audio from ADV7533 or ADV7535 and describing the audio
card via simple-audio-card, the '#sound-dai-cells' needs to be passed.

Document the '#sound-dai-cells' property to fix the following
dt-schema warning:

imx8mn-beacon-kit.dtb: hdmi@3d: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/display/bridge/adi,adv7533.yaml#
	
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../devicetree/bindings/display/bridge/adi,adv7533.yaml        | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
index 987aa83c2649..e15ae072922e 100644
--- a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
@@ -89,6 +89,9 @@ properties:
     $ref: /schemas/types.yaml#/definitions/uint32
     enum: [ 1, 2, 3, 4 ]
 
+  '#sound-dai-cells':
+    const: 0
+
   ports:
     description:
       The ADV7533/35 has two video ports and one audio port.
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: display: adi, adv75xx: Document #sound-dai-cells
  2023-12-06  1:28 [PATCH] dt-bindings: display: adi,adv75xx: Document #sound-dai-cells Fabio Estevam
@ 2023-12-06  2:43 ` Adam Ford
  2023-12-06  8:57 ` [PATCH] dt-bindings: display: adi,adv75xx: " Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Adam Ford @ 2023-12-06  2:43 UTC (permalink / raw)
  To: Fabio Estevam
  Cc: devicetree, conor+dt, Fabio Estevam, dri-devel, robh+dt,
	Laurent.pinchart, krzysztof.kozlowski+dt

On Tue, Dec 5, 2023 at 7:28 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> When using audio from ADV7533 or ADV7535 and describing the audio
> card via simple-audio-card, the '#sound-dai-cells' needs to be passed.
>
> Document the '#sound-dai-cells' property to fix the following
> dt-schema warning:
>

Thanks for doing that.

> imx8mn-beacon-kit.dtb: hdmi@3d: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/display/bridge/adi,adv7533.yaml#
>

Acked-by: Adam Ford <aford173@gmail.com>

> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  .../devicetree/bindings/display/bridge/adi,adv7533.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> index 987aa83c2649..e15ae072922e 100644
> --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> @@ -89,6 +89,9 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      enum: [ 1, 2, 3, 4 ]
>
> +  '#sound-dai-cells':
> +    const: 0
> +
>    ports:
>      description:
>        The ADV7533/35 has two video ports and one audio port.
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: display: adi,adv75xx: Document #sound-dai-cells
  2023-12-06  1:28 [PATCH] dt-bindings: display: adi,adv75xx: Document #sound-dai-cells Fabio Estevam
  2023-12-06  2:43 ` [PATCH] dt-bindings: display: adi, adv75xx: " Adam Ford
@ 2023-12-06  8:57 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-06  8:57 UTC (permalink / raw)
  To: Fabio Estevam, Laurent.pinchart
  Cc: devicetree, conor+dt, Fabio Estevam, dri-devel, robh+dt,
	krzysztof.kozlowski+dt, aford173

On 06/12/2023 02:28, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> When using audio from ADV7533 or ADV7535 and describing the audio
> card via simple-audio-card, the '#sound-dai-cells' needs to be passed.
> 
> Document the '#sound-dai-cells' property to fix the following
> dt-schema warning:
> 
> imx8mn-beacon-kit.dtb: hdmi@3d: '#sound-dai-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/display/bridge/adi,adv7533.yaml#
> 	
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  .../devicetree/bindings/display/bridge/adi,adv7533.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> index 987aa83c2649..e15ae072922e 100644
> --- a/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/adi,adv7533.yaml
> @@ -89,6 +89,9 @@ properties:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      enum: [ 1, 2, 3, 4 ]
>  

Then please also reference /schemas/sound/dai-common.yaml

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-12-06  8:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-06  1:28 [PATCH] dt-bindings: display: adi,adv75xx: Document #sound-dai-cells Fabio Estevam
2023-12-06  2:43 ` [PATCH] dt-bindings: display: adi, adv75xx: " Adam Ford
2023-12-06  8:57 ` [PATCH] dt-bindings: display: adi,adv75xx: " Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).