* [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER
[not found] <20180414002933.6h3S5%akpm@linux-foundation.org>
@ 2018-04-14 2:49 ` Randy Dunlap
2018-04-19 10:46 ` Anders Roxell
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2018-04-14 2:49 UTC (permalink / raw)
To: akpm, sfr, linux-next, linux-kernel, dri-devel, Oded Gabbay
From: Randy Dunlap <rdunlap@infradead.org>
When CONFIG_MMU_NOTIFIER is not enabled, struct mmu_notifier has an
incomplete type definition, which causes build errors.
../drivers/gpu/drm/amd/amdkfd/kfd_priv.h:607:22: error: field 'mmu_notifier' has incomplete type
../include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type
../include/linux/kernel.h:980:18: error: dereferencing pointer to incomplete type
../drivers/gpu/drm/amd/amdkfd/kfd_process.c:434:2: error: implicit declaration of function 'mmu_notifier_unregister_no_release' [-Werror=implicit-function-declaration]
../drivers/gpu/drm/amd/amdkfd/kfd_process.c:435:2: error: implicit declaration of function 'mmu_notifier_call_srcu' [-Werror=implicit-function-declaration]
../drivers/gpu/drm/amd/amdkfd/kfd_process.c:438:21: error: variable 'kfd_process_mmu_notifier_ops' has initializer but incomplete type
../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: error: unknown field 'release' specified in initializer
../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: excess elements in struct initializer [enabled by default]
../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: (near initialization for 'kfd_process_mmu_notifier_ops') [enabled by default]
../drivers/gpu/drm/amd/amdkfd/kfd_process.c:534:2: error: implicit declaration of function 'mmu_notifier_register' [-Werror=implicit-function-declaration]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Oded Gabbay <oded.gabbay@gmail.com>
Cc: dri-devel@lists.freedesktop.org
---
>From linux-next, not mmotm, but found in mmotm builds.
drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- mmotm-2018-0413-1728.orig/drivers/gpu/drm/amd/amdkfd/Kconfig
+++ mmotm-2018-0413-1728/drivers/gpu/drm/amd/amdkfd/Kconfig
@@ -6,5 +6,6 @@ config HSA_AMD
tristate "HSA kernel driver for AMD GPU devices"
depends on DRM_AMDGPU && X86_64
imply AMD_IOMMU_V2
+ select MMU_NOTIFIER
help
Enable this if you want to use HSA features on AMD GPU devices.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER
2018-04-14 2:49 ` [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER Randy Dunlap
@ 2018-04-19 10:46 ` Anders Roxell
2018-04-24 9:51 ` Oded Gabbay
0 siblings, 1 reply; 3+ messages in thread
From: Anders Roxell @ 2018-04-19 10:46 UTC (permalink / raw)
To: Randy Dunlap
Cc: Andrew Morton, sfr, linux-next, Linux Kernel Mailing List,
dri-devel, Oded Gabbay
On 14 April 2018 at 04:49, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> When CONFIG_MMU_NOTIFIER is not enabled, struct mmu_notifier has an
> incomplete type definition, which causes build errors.
>
> ../drivers/gpu/drm/amd/amdkfd/kfd_priv.h:607:22: error: field 'mmu_notifier' has incomplete type
> ../include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type
> ../include/linux/kernel.h:980:18: error: dereferencing pointer to incomplete type
> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:434:2: error: implicit declaration of function 'mmu_notifier_unregister_no_release' [-Werror=implicit-function-declaration]
> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:435:2: error: implicit declaration of function 'mmu_notifier_call_srcu' [-Werror=implicit-function-declaration]
> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:438:21: error: variable 'kfd_process_mmu_notifier_ops' has initializer but incomplete type
> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: error: unknown field 'release' specified in initializer
> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: excess elements in struct initializer [enabled by default]
> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: (near initialization for 'kfd_process_mmu_notifier_ops') [enabled by default]
> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:534:2: error: implicit declaration of function 'mmu_notifier_register' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Oded Gabbay <oded.gabbay@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
Tested-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> From linux-next, not mmotm, but found in mmotm builds.
>
> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- mmotm-2018-0413-1728.orig/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ mmotm-2018-0413-1728/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -6,5 +6,6 @@ config HSA_AMD
> tristate "HSA kernel driver for AMD GPU devices"
> depends on DRM_AMDGPU && X86_64
> imply AMD_IOMMU_V2
> + select MMU_NOTIFIER
> help
> Enable this if you want to use HSA features on AMD GPU devices.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER
2018-04-19 10:46 ` Anders Roxell
@ 2018-04-24 9:51 ` Oded Gabbay
0 siblings, 0 replies; 3+ messages in thread
From: Oded Gabbay @ 2018-04-24 9:51 UTC (permalink / raw)
To: Anders Roxell
Cc: Stephen Rothwell, Randy Dunlap, Linux Kernel Mailing List,
dri-devel, linux-next, Andrew Morton
On Thu, Apr 19, 2018 at 1:46 PM, Anders Roxell <anders.roxell@linaro.org> wrote:
> On 14 April 2018 at 04:49, Randy Dunlap <rdunlap@infradead.org> wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> When CONFIG_MMU_NOTIFIER is not enabled, struct mmu_notifier has an
>> incomplete type definition, which causes build errors.
>>
>> ../drivers/gpu/drm/amd/amdkfd/kfd_priv.h:607:22: error: field 'mmu_notifier' has incomplete type
>> ../include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete type
>> ../include/linux/kernel.h:980:18: error: dereferencing pointer to incomplete type
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:434:2: error: implicit declaration of function 'mmu_notifier_unregister_no_release' [-Werror=implicit-function-declaration]
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:435:2: error: implicit declaration of function 'mmu_notifier_call_srcu' [-Werror=implicit-function-declaration]
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:438:21: error: variable 'kfd_process_mmu_notifier_ops' has initializer but incomplete type
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: error: unknown field 'release' specified in initializer
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: excess elements in struct initializer [enabled by default]
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: (near initialization for 'kfd_process_mmu_notifier_ops') [enabled by default]
>> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:534:2: error: implicit declaration of function 'mmu_notifier_register' [-Werror=implicit-function-declaration]
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Oded Gabbay <oded.gabbay@gmail.com>
>> Cc: dri-devel@lists.freedesktop.org
>
> Tested-by: Anders Roxell <anders.roxell@linaro.org>
>
>> ---
>> From linux-next, not mmotm, but found in mmotm builds.
>>
>> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> --- mmotm-2018-0413-1728.orig/drivers/gpu/drm/amd/amdkfd/Kconfig
>> +++ mmotm-2018-0413-1728/drivers/gpu/drm/amd/amdkfd/Kconfig
>> @@ -6,5 +6,6 @@ config HSA_AMD
>> tristate "HSA kernel driver for AMD GPU devices"
>> depends on DRM_AMDGPU && X86_64
>> imply AMD_IOMMU_V2
>> + select MMU_NOTIFIER
>> help
>> Enable this if you want to use HSA features on AMD GPU devices.
>>
Thanks, taken to -fixes
Oded
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-24 9:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180414002933.6h3S5%akpm@linux-foundation.org>
2018-04-14 2:49 ` [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER Randy Dunlap
2018-04-19 10:46 ` Anders Roxell
2018-04-24 9:51 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).