From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Aradhya Bhatia <a-bhatia1@ti.com>
Cc: Nishanth Menon <nm@ti.com>,
Devicetree List <devicetree@vger.kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Devarsh Thakkar <devarsht@ti.com>,
David Airlie <airlied@linux.ie>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
DRI Development List <dri-devel@lists.freedesktop.org>,
Darren Etheridge <detheridge@ti.com>,
Rob Herring <robh+dt@kernel.org>, Jyri Sarha <jyri.sarha@iki.fi>,
Rahul T R <r-ravikumar@ti.com>, Krunal Bhargav <k-bhargav@ti.com>
Subject: Re: [PATCH 8/8] drm/tidss: Enable Dual and Duplicate Modes for OLDI
Date: Thu, 28 Jul 2022 14:29:55 +0300 [thread overview]
Message-ID: <ddb4cffd-bf0e-2a5e-2922-9c1ee12cfd25@ideasonboard.com> (raw)
In-Reply-To: <0d9f4301-8af5-4497-8e59-affdc0541285@ti.com>
On 28/07/2022 11:49, Aradhya Bhatia wrote:
> Hi Tomi,
>
> On 28-Jul-22 12:16, Tomi Valkeinen wrote:
>> On 27/07/2022 16:22, Tomi Valkeinen wrote:
>>> Hi,
>>>
>>> On 19/07/2022 11:08, Aradhya Bhatia wrote:
>>>> The AM625 DSS peripheral supports 2 OLDI TXes which can work to
>>>> enable 2
>>>> duplicated displays of smaller resolutions or enable a single Dual-Link
>>>> display with a higher resolution (1920x1200).
>>>>
>>>> Configure the necessary register to enable the different modes.
>>>>
>>>> Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com>
>>>> ---
>>>> drivers/gpu/drm/tidss/tidss_dispc.c | 44
>>>> +++++++++++++++++++++++++++--
>>>> 1 file changed, 41 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c
>>>> b/drivers/gpu/drm/tidss/tidss_dispc.c
>>>> index 0b9689453ee8..28cb61259471 100644
>>>> --- a/drivers/gpu/drm/tidss/tidss_dispc.c
>>>> +++ b/drivers/gpu/drm/tidss/tidss_dispc.c
>>>> @@ -1021,8 +1021,8 @@ static void dispc_enable_oldi(struct
>>>> dispc_device *dispc, u32 hw_videoport,
>>>> int count = 0;
>>>> /*
>>>> - * For the moment DUALMODESYNC, MASTERSLAVE, MODE, and SRC
>>>> - * bits of DISPC_VP_DSS_OLDI_CFG are set statically to 0.
>>>> + * For the moment MASTERSLAVE, and SRC bits of
>>>> DISPC_VP_DSS_OLDI_CFG are
>>>> + * set statically to 0.
>>>> */
>>>> if (fmt->data_width == 24)
>>>> @@ -1039,7 +1039,45 @@ static void dispc_enable_oldi(struct
>>>> dispc_device *dispc, u32 hw_videoport,
>>>> oldi_cfg |= BIT(0); /* ENABLE */
>>>> - dispc_vp_write(dispc, hw_videoport, DISPC_VP_DSS_OLDI_CFG,
>>>> oldi_cfg);
>>>> + /*
>>>> + * As per all the current implementations of DSS, the OLDI TXes
>>>> are present only on
>>>> + * hw_videoport = 0 (OLDI TX 0). However, the config register
>>>> for 2nd OLDI TX (OLDI TX 1)
>>>> + * is present in the address space of hw_videoport = 1. Hence,
>>>> using "hw_videoport + 1" to
>>>> + * configure OLDI TX 1.
>>>> + */
>>>> +
>>>> + switch (dispc->oldi_mode) {
>>>> + case OLDI_MODE_OFF:
>>>> + oldi_cfg &= ~BIT(0); /* DISABLE */
>>>> + dispc_vp_write(dispc, hw_videoport, DISPC_VP_DSS_OLDI_CFG,
>>>> oldi_cfg);
>>>> + dispc_vp_write(dispc, hw_videoport + 1,
>>>> DISPC_VP_DSS_OLDI_CFG, oldi_cfg);
>>>> + break;
>>>> +
>>>> + case OLDI_SINGLE_LINK_SINGLE_MODE_0:
>>>> + dispc_vp_write(dispc, hw_videoport, DISPC_VP_DSS_OLDI_CFG,
>>>> oldi_cfg);
>>>> + break;
>>>> +
>>>> + case OLDI_SINGLE_LINK_SINGLE_MODE_1:
>>>> + dispc_vp_write(dispc, hw_videoport + 1,
>>>> DISPC_VP_DSS_OLDI_CFG, oldi_cfg);
>>>> + break;
>>>> +
>>>> + case OLDI_SINGLE_LINK_DUPLICATE_MODE:
>>>> + oldi_cfg |= BIT(5); /* DUPLICATE MODE */
>>>> + dispc_vp_write(dispc, hw_videoport, DISPC_VP_DSS_OLDI_CFG,
>>>> oldi_cfg);
>>>> + dispc_vp_write(dispc, hw_videoport + 1,
>>>> DISPC_VP_DSS_OLDI_CFG, oldi_cfg);
>>>> + break;
>>>> +
>>>> + case OLDI_DUAL_LINK:
>>>> + oldi_cfg |= BIT(11); /* DUALMODESYNC */
>>>> + dispc_vp_write(dispc, hw_videoport, DISPC_VP_DSS_OLDI_CFG,
>>>> oldi_cfg);
>>>> + dispc_vp_write(dispc, hw_videoport + 1,
>>>> DISPC_VP_DSS_OLDI_CFG, oldi_cfg);
>>>> + break;
>>>> +
>>>> + default:
>>>> + dev_warn(dispc->dev, "%s: Incorrect oldi mode. Returning.\n",
>>>> + __func__);
>>>> + return;
>>>> + }
>>>> while (!(oldi_reset_bit & dispc_read(dispc, DSS_SYSSTATUS)) &&
>>>> count < 10000)
>>>
>>> This feels a bit hacky:
>>>
>>> - The function is dispc_enable_oldi, but the above code also disables
>>> oldi. We have code in dispc_vp_unprepare() which disables OLDI at the
>>> moment.
>>>
>>> - The function takes hw_videoport as a parameter, and is designed to
>>> work on that videoport. The above operates on two videoports. Isn't
>>> the function also called for hw_videoport +1, which would result in
>>> reg writes to hw_videoport + 2?
>>>
>>> - No matching code in dispc_vp_unprepare
>>>
>>> Obviously the duplicate mode (I presume that's "cloning") and the
>>> dual link complicate things here, and I have to say I haven't worked
>>> with such setups. But I think somehow this should be restructured so
>>> that common configuration (common to the OLDIs) is done somewhere else.
>>>
>>> I would guess that there are other drivers that support cloning and
>>> dual mode. Did you have a look how they handle things?
>>
>> Oh, I see now... There's just one dss video port for OLDI, the same as
>> in am65x, but that single video port is now connected to two OLDI
>> TXes. And thus this function will only be called for the single video
>> port.
>> > But... The registers for the second OLDI are part of the second video
>> port (DPI) register block?
>
> Yes! The config register for the second OLDI TX has been (incorrectly)
> added in the register space for the DPI video port. 'dispc_vp_prepare'
> is the only function calling 'dispc_enable_oldi', and
> 'dispc_enable_oldi' would not be called for hw_videoports = 1 (DPI)
> because of the conditional check.
>
> Hence, to activate both the OLDI-TXes connected to the OLDI video port,
> I had to use the (hw_videoport + 1) way.
I think this should be highlighted in the comment more clearly. Also, I
don't think hw_videoport + 1 usage is good. While in this case the
registers are in vp + 1, it's, in a way, a coincidence.
Instead, have a new variable for the VP register block which contains
the OLDI TX 1 registers, and just set that to 1 with a comment
clarifying that the registers for OLDI 1 are in VP1 register block, even
if OLDI 1 is connected to VP0.
And then use that variable when calling dispc_vp_write().
Tomi
prev parent reply other threads:[~2022-07-28 11:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 8:08 sFrom b69208b75f7ae8e223c81783afb04fecd2f5faf8 Mon Sep 17 00:00:00 2001 Aradhya Bhatia
2022-07-19 8:08 ` [PATCH 1/8] dt-bindings: display: ti, am65x-dss: Add port properties for DSS Aradhya Bhatia
2022-07-20 23:28 ` [PATCH 1/8] dt-bindings: display: ti,am65x-dss: " Rob Herring
2022-07-22 16:16 ` Nishanth Menon
2022-07-28 6:28 ` Tomi Valkeinen
2022-07-25 11:26 ` Aradhya Bhatia
2022-07-25 22:14 ` Francesco Dolcini
2022-08-10 17:48 ` Rob Herring
2022-07-28 11:16 ` Tomi Valkeinen
2022-07-19 8:08 ` [PATCH 2/8] dt-bindings: display: ti, am65x-dss: Add IO CTRL property for AM625 OLDI Aradhya Bhatia
2022-07-20 23:32 ` [PATCH 2/8] dt-bindings: display: ti,am65x-dss: " Rob Herring
2022-07-25 11:34 ` Aradhya Bhatia
2022-07-19 8:08 ` [PATCH 3/8] drm/tidss: Add support for DSS port properties Aradhya Bhatia
2022-07-28 12:07 ` Tomi Valkeinen
2022-07-19 8:08 ` [PATCH 4/8] drm/tidss: Add support for Dual Link LVDS Bus Format Aradhya Bhatia
2022-07-28 11:03 ` Tomi Valkeinen
2022-07-28 11:45 ` Tomi Valkeinen
2022-08-09 5:58 ` Aradhya Bhatia
2022-08-09 6:28 ` Tomi Valkeinen
2022-08-09 9:06 ` Aradhya Bhatia
2022-08-09 9:51 ` Tomi Valkeinen
2022-08-09 13:34 ` Aradhya Bhatia
2022-07-19 8:08 ` [PATCH 5/8] drm/tidss: dt property to force 16bit VP output to a 24bit bridge Aradhya Bhatia
2022-07-19 8:08 ` [PATCH 6/8] drm/tidss: Add IO CTRL and Power support for OLDI TX in AM625 Aradhya Bhatia
2022-07-19 8:08 ` [PATCH 7/8] drm/tidss: Fix clock request value for OLDI videoports Aradhya Bhatia
2022-07-28 10:05 ` Tomi Valkeinen
2022-07-29 3:56 ` Aradhya Bhatia
2022-07-29 8:13 ` Tomi Valkeinen
2022-07-19 8:08 ` [PATCH 8/8] drm/tidss: Enable Dual and Duplicate Modes for OLDI Aradhya Bhatia
2022-07-27 13:22 ` Tomi Valkeinen
2022-07-28 6:46 ` Tomi Valkeinen
2022-07-28 8:49 ` Aradhya Bhatia
2022-07-28 11:29 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddb4cffd-bf0e-2a5e-2922-9c1ee12cfd25@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=a-bhatia1@ti.com \
--cc=airlied@linux.ie \
--cc=detheridge@ti.com \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=k-bhargav@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=r-ravikumar@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).