* [PATCH 2/2] video: fbdev: gbefb: Remove unproper information
@ 2022-09-02 2:56 Jiasheng Jiang
2022-09-25 11:24 ` Helge Deller
0 siblings, 1 reply; 3+ messages in thread
From: Jiasheng Jiang @ 2022-09-02 2:56 UTC (permalink / raw)
To: deller, broonie, maarten.lankhorst, daniel.vetter
Cc: linux-fbdev, Jiasheng Jiang, linux-kernel, dri-devel
When drivers are working properly, they are quiet.
Therefore, the fb_info() should be removed.
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
drivers/video/fbdev/gbefb.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
index 1582c718329c..7e39ab939691 100644
--- a/drivers/video/fbdev/gbefb.c
+++ b/drivers/video/fbdev/gbefb.c
@@ -1217,10 +1217,6 @@ static int gbefb_probe(struct platform_device *p_dev)
platform_set_drvdata(p_dev, info);
- fb_info(info, "%s rev %d @ 0x%08x using %dkB memory\n",
- info->fix.id, gbe_revision, (unsigned)GBE_BASE,
- gbe_mem_size >> 10);
-
return 0;
out_gbe_unmap:
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] video: fbdev: gbefb: Remove unproper information
2022-09-02 2:56 [PATCH 2/2] video: fbdev: gbefb: Remove unproper information Jiasheng Jiang
@ 2022-09-25 11:24 ` Helge Deller
2022-09-26 7:09 ` Thomas Zimmermann
0 siblings, 1 reply; 3+ messages in thread
From: Helge Deller @ 2022-09-25 11:24 UTC (permalink / raw)
To: Jiasheng Jiang, broonie, maarten.lankhorst, daniel.vetter
Cc: linux-fbdev, linux-kernel, dri-devel
On 9/2/22 04:56, Jiasheng Jiang wrote:
> When drivers are working properly, they are quiet.
> Therefore, the fb_info() should be removed.
NAK.
This seems to be useful info about the detected card and it's only
printed once.
Helge
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/video/fbdev/gbefb.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
> index 1582c718329c..7e39ab939691 100644
> --- a/drivers/video/fbdev/gbefb.c
> +++ b/drivers/video/fbdev/gbefb.c
> @@ -1217,10 +1217,6 @@ static int gbefb_probe(struct platform_device *p_dev)
>
> platform_set_drvdata(p_dev, info);
>
> - fb_info(info, "%s rev %d @ 0x%08x using %dkB memory\n",
> - info->fix.id, gbe_revision, (unsigned)GBE_BASE,
> - gbe_mem_size >> 10);
> -
> return 0;
>
> out_gbe_unmap:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] video: fbdev: gbefb: Remove unproper information
2022-09-25 11:24 ` Helge Deller
@ 2022-09-26 7:09 ` Thomas Zimmermann
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2022-09-26 7:09 UTC (permalink / raw)
To: Helge Deller, Jiasheng Jiang, broonie, maarten.lankhorst, daniel.vetter
Cc: linux-fbdev, linux-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1406 bytes --]
Hi
Am 25.09.22 um 13:24 schrieb Helge Deller:
> On 9/2/22 04:56, Jiasheng Jiang wrote:
>> When drivers are working properly, they are quiet.
>> Therefore, the fb_info() should be removed.
>
> NAK.
> This seems to be useful info about the detected card and it's only
> printed once.
Well, he has a point. Maybe this could become an fb_dbg() ? (BTW, it's
a bit unfortunate that there's an fb_info macro and an fb_info struct. :/)
Best regards
Thomas
>
> Helge
>
>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>> ---
>> drivers/video/fbdev/gbefb.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/gbefb.c b/drivers/video/fbdev/gbefb.c
>> index 1582c718329c..7e39ab939691 100644
>> --- a/drivers/video/fbdev/gbefb.c
>> +++ b/drivers/video/fbdev/gbefb.c
>> @@ -1217,10 +1217,6 @@ static int gbefb_probe(struct platform_device
>> *p_dev)
>>
>> platform_set_drvdata(p_dev, info);
>>
>> - fb_info(info, "%s rev %d @ 0x%08x using %dkB memory\n",
>> - info->fix.id, gbe_revision, (unsigned)GBE_BASE,
>> - gbe_mem_size >> 10);
>> -
>> return 0;
>>
>> out_gbe_unmap:
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-26 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-02 2:56 [PATCH 2/2] video: fbdev: gbefb: Remove unproper information Jiasheng Jiang
2022-09-25 11:24 ` Helge Deller
2022-09-26 7:09 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).