* [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
@ 2023-06-07 7:22 Sui Jingfeng
2023-06-07 9:46 ` Paul Cercueil
0 siblings, 1 reply; 4+ messages in thread
From: Sui Jingfeng @ 2023-06-07 7:22 UTC (permalink / raw)
To: Paul Cercueil, David Airlie, Daniel Vetter
Cc: linux-mips, dri-devel, linux-kernel
Otherwise its failed to pass basic compile test on platform without
REGMAP_MMIO selected by defconfig
make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
SYNC include/config/auto.conf.cmd
Checking missing-syscalls for N32
CALL scripts/checksyscalls.sh
Checking missing-syscalls for O32
CALL scripts/checksyscalls.sh
CALL scripts/checksyscalls.sh
MODPOST Module.symvers
ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
make: *** [Makefile:1978: modpost] Error 2
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
drivers/gpu/drm/ingenic/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
index a53f475d33df..7457c0b65034 100644
--- a/drivers/gpu/drm/ingenic/Kconfig
+++ b/drivers/gpu/drm/ingenic/Kconfig
@@ -5,6 +5,8 @@ config DRM_INGENIC
depends on CMA
depends on OF
depends on COMMON_CLK
+ select REGMAP
+ select REGMAP_MMIO
select DRM_BRIDGE
select DRM_PANEL_BRIDGE
select DRM_KMS_HELPER
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
2023-06-07 7:22 [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO Sui Jingfeng
@ 2023-06-07 9:46 ` Paul Cercueil
2023-06-07 10:25 ` Sui Jingfeng
2023-06-15 7:14 ` Sui Jingfeng
0 siblings, 2 replies; 4+ messages in thread
From: Paul Cercueil @ 2023-06-07 9:46 UTC (permalink / raw)
To: Sui Jingfeng, David Airlie, Daniel Vetter
Cc: linux-mips, dri-devel, linux-kernel
Hi Sui,
Le mercredi 07 juin 2023 à 15:22 +0800, Sui Jingfeng a écrit :
> Otherwise its failed to pass basic compile test on platform without
> REGMAP_MMIO selected by defconfig
>
> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>
> SYNC include/config/auto.conf.cmd
> Checking missing-syscalls for N32
> CALL scripts/checksyscalls.sh
> Checking missing-syscalls for O32
> CALL scripts/checksyscalls.sh
> CALL scripts/checksyscalls.sh
> MODPOST Module.symvers
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
>
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
> drivers/gpu/drm/ingenic/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ingenic/Kconfig
> b/drivers/gpu/drm/ingenic/Kconfig
> index a53f475d33df..7457c0b65034 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -5,6 +5,8 @@ config DRM_INGENIC
> depends on CMA
> depends on OF
> depends on COMMON_CLK
> + select REGMAP
> + select REGMAP_MMIO
nit: order alphabetically (move them after the DRM_* ones).
Cheers,
-Paul
> select DRM_BRIDGE
> select DRM_PANEL_BRIDGE
> select DRM_KMS_HELPER
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
2023-06-07 9:46 ` Paul Cercueil
@ 2023-06-07 10:25 ` Sui Jingfeng
2023-06-15 7:14 ` Sui Jingfeng
1 sibling, 0 replies; 4+ messages in thread
From: Sui Jingfeng @ 2023-06-07 10:25 UTC (permalink / raw)
To: Paul Cercueil, David Airlie, Daniel Vetter
Cc: linux-mips, dri-devel, linux-kernel
Ok, thanks
On 2023/6/7 17:46, Paul Cercueil wrote:
> Hi Sui,
>
> Le mercredi 07 juin 2023 à 15:22 +0800, Sui Jingfeng a écrit :
>> Otherwise its failed to pass basic compile test on platform without
>> REGMAP_MMIO selected by defconfig
>>
>> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>>
>> SYNC include/config/auto.conf.cmd
>> Checking missing-syscalls for N32
>> CALL scripts/checksyscalls.sh
>> Checking missing-syscalls for O32
>> CALL scripts/checksyscalls.sh
>> CALL scripts/checksyscalls.sh
>> MODPOST Module.symvers
>> ERROR: modpost: "__devm_regmap_init_mmio_clk"
>> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
>> make: *** [Makefile:1978: modpost] Error 2
>>
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
>> drivers/gpu/drm/ingenic/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/ingenic/Kconfig
>> b/drivers/gpu/drm/ingenic/Kconfig
>> index a53f475d33df..7457c0b65034 100644
>> --- a/drivers/gpu/drm/ingenic/Kconfig
>> +++ b/drivers/gpu/drm/ingenic/Kconfig
>> @@ -5,6 +5,8 @@ config DRM_INGENIC
>> depends on CMA
>> depends on OF
>> depends on COMMON_CLK
>> + select REGMAP
>> + select REGMAP_MMIO
> nit: order alphabetically (move them after the DRM_* ones).
>
> Cheers,
> -Paul
>
>> select DRM_BRIDGE
>> select DRM_PANEL_BRIDGE
>> select DRM_KMS_HELPER
--
Jingfeng
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
2023-06-07 9:46 ` Paul Cercueil
2023-06-07 10:25 ` Sui Jingfeng
@ 2023-06-15 7:14 ` Sui Jingfeng
1 sibling, 0 replies; 4+ messages in thread
From: Sui Jingfeng @ 2023-06-15 7:14 UTC (permalink / raw)
To: Paul Cercueil, David Airlie, Daniel Vetter
Cc: linux-mips, dri-devel, linux-kernel
Hi,
On 2023/6/7 17:46, Paul Cercueil wrote:
> Hi Sui,
>
> Le mercredi 07 juin 2023 à 15:22 +0800, Sui Jingfeng a écrit :
>> Otherwise its failed to pass basic compile test on platform without
>> REGMAP_MMIO selected by defconfig
>>
>> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>>
>> SYNC include/config/auto.conf.cmd
>> Checking missing-syscalls for N32
>> CALL scripts/checksyscalls.sh
>> Checking missing-syscalls for O32
>> CALL scripts/checksyscalls.sh
>> CALL scripts/checksyscalls.sh
>> MODPOST Module.symvers
>> ERROR: modpost: "__devm_regmap_init_mmio_clk"
>> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
>> make: *** [Makefile:1978: modpost] Error 2
>>
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
>> drivers/gpu/drm/ingenic/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/ingenic/Kconfig
>> b/drivers/gpu/drm/ingenic/Kconfig
>> index a53f475d33df..7457c0b65034 100644
>> --- a/drivers/gpu/drm/ingenic/Kconfig
>> +++ b/drivers/gpu/drm/ingenic/Kconfig
>> @@ -5,6 +5,8 @@ config DRM_INGENIC
>> depends on CMA
>> depends on OF
>> depends on COMMON_CLK
>> + select REGMAP
>> + select REGMAP_MMIO
> nit: order alphabetically (move them after the DRM_* ones).
Fixed, I already send a updated version[1].
[1]
https://lore.kernel.org/dri-devel/20230607110650.569522-1-suijingfeng@loongson.cn/
> Cheers,
> -Paul
>
>> select DRM_BRIDGE
>> select DRM_PANEL_BRIDGE
>> select DRM_KMS_HELPER
--
Jingfeng
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-15 7:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-07 7:22 [PATCH] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO Sui Jingfeng
2023-06-07 9:46 ` Paul Cercueil
2023-06-07 10:25 ` Sui Jingfeng
2023-06-15 7:14 ` Sui Jingfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).